Skip to content

Commit f19462b

Browse files
authored
Merge pull request #244 from bl-ue/fix-typos
Fix typos
2 parents 07a1e42 + 9c70820 commit f19462b

File tree

3 files changed

+24
-24
lines changed

3 files changed

+24
-24
lines changed

azure/Guidelines.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,15 @@ Developing a new service requires the development of at least 1 (management plan
2626

2727
> A **management plane** API is implemented through the Azure Resource Manager (ARM) and is used by subscription administrators. A **data plane** API is used by developers to implement applications. Rarely, a subset of operations may be useful to both administrators and users, in which case it should appear in both APIs.
2828
29-
* Think about naming from the context of a **developer experience**.
29+
* Think about naming from the context of a **developer experience**.
3030
* Start with the "things" your API manipulates, then think about the operations that a developer needs to do to these "things".
3131
* Keep the verbs present-tense. Avoid the use of past or future tense in most cases.
3232
* Avoid the use of generic names like "Object", "Job", "Task", "Operation" (for example - the list is not exhaustive).
3333
* What happens to the names when the focus of the service expands? It may be worth starting with a less generic name to avoid a breaking change later on.
3434
* Think about the code that a customer will write both before and after the REST API call. How will a developer use this API in the canonical use case?
3535
* Consider multiple languages, and include at least one dynamically typed language (for example, Python or JavaScript) and one statically typed language (for example, Java or C#).
3636
* Use previews to get the shape right. There are different notification, breaking change, and lifetime requirements on preview API versions.
37-
* We recommend a minimum of 2 preview versions prior to your first GA release. However, there is no hard rule for previews.
37+
* We recommend a minimum of 2 preview versions prior to your first GA release. However, there is no hard rule for previews.
3838
* You should gather feedback from your customers and iterate until the API is useful. Actively solicit feedback from your preview customers.
3939

4040
Preventing future breaking changes is a source of concern during initial review. Without a history, the review process attempts to identify patterns that may result in breaking changes later on. For instance, think about the following:
@@ -54,7 +54,7 @@ Preventing future breaking changes is a source of concern during initial review.
5454
* Implement managed identity access controls for accessing the other resource. Do not accept connection strings as a method of specifying access permissions.
5555
* Be concerned about data widths of numeric types. Wider data types (e.g. 64-bit vs. 32-bit) are more future-proof.
5656
* Think about how the interface will be represented by an SDK. For example, JavaScript can only support numbers up to 2<sup>53</sup>, so relying on the full width of a 64-bit number should be avoided.
57-
* Implement (and encourage) the use of PATCH for resource modifications.
57+
* Implement (and encourage) the use of PATCH for resource modifications.
5858
* The PATCH operation should be able to modify any mutable property on the resource.
5959
* Prefer JSON merge-patch ([RFC 7396](https://tools.ietf.org/html/rfc7396)) over JSON patch ([RFC 6902](https://tools.ietf.org/html/rfc6902)) as the accepted data format for PATCH operations.
6060
* Get a security review of your API. You should be especially concerned with PII leakage, GDPR compliance and any other compliance regulations appropriate to your situation.
@@ -172,7 +172,7 @@ Evolutionary changes do not require prior approval (but still need a version bum
172172

173173
#### Changing the API without changing the version
174174

175-
Because the API version represents a contract that a developer can rely on when generating SDKs to communicate with the service, there are a limited set of situations where changing the API is permissable without a version bump. The only changes universally allowed:
175+
Because the API version represents a contract that a developer can rely on when generating SDKs to communicate with the service, there are a limited set of situations where changing the API is permissible without a version bump. The only changes universally allowed:
176176

177177
1. Adding a new (optional) value to an extensible enum.
178178

@@ -191,7 +191,7 @@ This functionality is only available for single cloud deployments because the AP
191191

192192
Do not add computed output values if the computed value can be calculated from other information in the payload. It unnecessarily expands the payload.
193193

194-
All situations where the API definition is changed (irrespective of whether a version change happens or not) **MUST** be reviewed by the Azure REST API Review Board before release.
194+
All situations where the API definition is changed (irrespective of whether a version change happens or not) **MUST** be reviewed by the Azure REST API Review Board before release.
195195

196196
### Preview Versions
197197

@@ -208,7 +208,7 @@ Preview versions are not treated the same way as release versions. In general,
208208

209209
You should follow the axiom "don't surprise your customers" when deciding whether to increment the preview version, and err on the side of incrementing the preview version.
210210

211-
Preview APIs [follow a different path for deprecation and retirement](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37683/Retirement-of-Previews), and are not subject to the same guarantees as APIs marked as generally available. Preview APIs have a life-span of not more than 12 months, after which they must be retired.
211+
Preview APIs [follow a different path for deprecation and retirement](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37683/Retirement-of-Previews), and are not subject to the same guarantees as APIs marked as generally available. Preview APIs have a life-span of not more than 12 months, after which they must be retired.
212212

213213
#### Why Azure recommends conservative API versioning
214214

@@ -220,7 +220,7 @@ There are a few mechanisms that can reduce breaking changes and their effects on
220220

221221
#### Use PATCH instead of PUT for updates
222222

223-
The HTTP PUT verb is an idemopotent apply operation for the API version being used. The [Microsoft API Guidelines already recommend the use of PATCH](https://github.com/microsoft/api-guidelines/blob/vNext/Guidelines.md#742-patch) for updates.
223+
The HTTP PUT verb is an idempotent apply operation for the API version being used. The [Microsoft API Guidelines already recommend the use of PATCH](https://github.com/microsoft/api-guidelines/blob/vNext/Guidelines.md#742-patch) for updates.
224224

225225
Consider the following sequence:
226226

@@ -252,7 +252,7 @@ While removing a value from an enum is a breaking change, adding an enum can be
252252
}
253253
```
254254

255-
Always model an enum as a string unleess you are positive that the symbol set will **NEVER** change over time.
255+
Always model an enum as a string unless you are positive that the symbol set will **NEVER** change over time.
256256

257257
### Group versioning in Azure and Azure Stack
258258

graph/dictionary/client-guidance.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ In **components** in **schemas**:
1313
```json
1414
{
1515
"roleSettings": {
16-
"type": "object",
16+
"type": "object",
1717
"properties": {
18-
"domain": {
19-
"type": "string"
20-
}
21-
}
18+
"domain": {
19+
"type": "string"
20+
}
21+
}
2222
}
2323
}
2424
}
@@ -28,7 +28,7 @@ In **components** in **schemas**:
2828
{
2929
"type": "object",
3030
"patternProperties": {
31-
".*": {
31+
".*": {
3232
"$ref": "#/components/schemas/roleSettings"
3333
},
3434
"additionalProperties": false
@@ -38,11 +38,11 @@ In **components** in **schemas**:
3838

3939
## SDK Support
4040

41-
SDKs need to provide support for dictionary types so SDK consummers get a delightful development experience. Examples are provided below for different languages. Other aspects need to be taken into considerations:
41+
SDKs need to provide support for dictionary types so SDK consumers get a delightful development experience. Examples are provided below for different languages. Other aspects need to be taken into considerations:
4242

4343
- Dictionaries support OData annotations (values prefixed with **@OData**), such annotations should not be inserted directly in the dictionary but rather in the additional properties manager.
4444
- Dictionary types can inherit another dictionary type, this inheritance must be respected.
45-
- Dictionary values can be of union types, if the target langauge doesn't support union types, a wrapper type should be generated as backward compatible solution with properties for each type of the union.
45+
- Dictionary values can be of union types, if the target language doesn't support union types, a wrapper type should be generated as backward compatible solution with properties for each type of the union.
4646

4747
### Dotnet
4848

@@ -72,6 +72,6 @@ or
7272

7373
## Request builder generation annotation
7474

75-
By default SDKs are not required to contain a set of request builders to run CRUD requests on entries in the dictionary. The dictionary will be updated as a whole by consummers by sending requests to the parent entity.
75+
By default SDKs are not required to contain a set of request builders to run CRUD requests on entries in the dictionary. The dictionary will be updated as a whole by consumers by sending requests to the parent entity.
7676

77-
If a **SupportedHttpMethod** annotation is specified for the dictionary type, request builders should be generated to allow consummers to automically update the entries.
77+
If a **SupportedHttpMethod** annotation is specified for the dictionary type, request builders should be generated to allow consumers to automatically update the entries.

graph/dictionary/index.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Before using a dictionary type in your API definition make sure your scenario fi
2222

2323
## JSON payload example
2424

25-
The following example illustrates the resulting JSON for a property of dictionary type. The parent object has been ommitted for brievety.
25+
The following example illustrates the resulting JSON for a property of dictionary type. The parent object has been omitted for brevity.
2626

2727
```json
2828
{
@@ -48,7 +48,7 @@ In this set of examples we're modeling a **roles** property of dictionary type o
4848
GET https://graph.microsoft.com/v1.0/users/10/roles/author
4949
```
5050

51-
Reponse:
51+
Response:
5252

5353
```json
5454
{
@@ -62,7 +62,7 @@ Reponse:
6262
GET https://graph.microsoft.com/v1.0/users/10/roles
6363
```
6464

65-
Reponse:
65+
Response:
6666

6767
```json
6868
{
@@ -84,7 +84,7 @@ Reponse:
8484
GET https://graph.microsoft.com/v1.0/users/10
8585
```
8686

87-
Reponse:
87+
Response:
8888

8989
```json
9090
{
@@ -134,7 +134,7 @@ PATCH https://graph.microsoft.com/v1.0/users/10/roles
134134
```
135135

136136
> Note: setting one of the keys to **null** deletes it from the dictionary.
137-
> Note: the domain values for the existing author and maintainer entries will get udpated.
137+
> Note: the domain values for the existing author and maintainer entries will get updated.
138138
> Note: the reviewer entry will be inserted in the dictionary.
139139
140140
### Updating an entry in the dictionary
@@ -172,7 +172,7 @@ The following example defines a complex type **roleSettings** as well as a dicti
172172
</Collection>
173173
</Annotation>
174174
<Annotation Term="SupportedHttpMethod">
175-
<Collection><!-- use this annotation to indicate you want the SDKs to generate additional request builders to update the dictionary atomtically -->
175+
<Collection><!-- use this annotation to indicate you want the SDKs to generate additional request builders to update the dictionary automatically -->
176176
<String>GET</String>
177177
<String>PATCH</String>
178178
<String>DELETE</String>

0 commit comments

Comments
 (0)