Rework install script validation (#542)

Reworking install script validation pipeline
- reduce script copying
- move to step templates

Author: embetten

.vsts-ci.yml

@@ -21,20 +21,7 @@ stages:
       parameters:
         nuspecProperties: 'VersionSuffix=CI-$(Build.BuildNumber)'
 
-- stage: ValidateInstallScriptWindows
+- stage: Validate
   dependsOn: [] 
-  pool:
-    vmImage: windows-latest
   jobs:
-  - template: build/validate-install-script-ps.yml
-    parameters:
-      repo: 'self'
-
-- stage: ValidateInstallScriptLinux
-  dependsOn: [] 
-  pool:
-    vmImage: ubuntu-latest
-  jobs:
-  - template: build/validate-install-script-sh.yml
-    parameters:
-      repo: 'self'  
+  - template: build/validate-install-script.yml

.vsts-pr.yml

@@ -21,20 +21,7 @@ stages:
       parameters:
         nuspecProperties: 'VersionSuffix=CI-$(Build.BuildNumber)'
 
-- stage: ValidateInstallScriptWindows
+- stage: Validate
   dependsOn: [] 
-  pool:
-    vmImage: windows-latest
   jobs:
-  - template: build/validate-install-script-ps.yml
-    parameters:
-      repo: 'self'
-
-- stage: ValidateInstallScriptLinux
-  dependsOn: [] 
-  pool:
-    vmImage: ubuntu-latest
-  jobs:
-  - template: build/validate-install-script-sh.yml
-    parameters:
-      repo: 'self'  
+  - template: build/validate-install-script.yml

build/validate-install-script-bash.yml

@@ -0,0 +1,34 @@
+parameters:
+- name: repo
+  type: string
+- name: scriptEnvVariables
+  type: string
+- name: expectedCredentialProviderVersion
+  type: string
+
+steps:
+- checkout: ${{ parameters.repo }}
+- bash: |
+    ${{ parameters.scriptEnvVariables }}
+    ./helpers/installcredprovider.sh -Force >> ./output.log
+    cat ./output.log
+
+    if ! grep ${{ parameters.expectedCredentialProviderVersion }} ./output.log; then
+      echo "Expected credential provider not found"
+      exit 1
+    fi
+    if [ ! -d "$HOME/.nuget/plugins/netcore/CredentialProvider.Microsoft" ]; then
+      echo "Credential provider plugin directory not found"
+      exit 1
+    fi
+    
+    echo "Credential provider installed successfully"
+  workingDirectory: $(Build.SourcesDirectory)
+  displayName: Validate Install Script
+- bash: |
+    if grep $'\r' ./helpers/installcredprovider.sh; then 
+      echo "CRLF line ending found"
+      exit 1
+    fi
+  workingDirectory: $(Build.SourcesDirectory)
+  displayName: Check Line Endings

build/validate-install-script-powershell.yml

@@ -0,0 +1,19 @@
+parameters:
+- name: repo
+  type: string
+- name: scriptInputs
+  type: string
+- name: expectedCredentialProviderVersion
+  type: string
+
+steps:
+- checkout: ${{ parameters.repo }}
+- task: PowerShell@2
+  displayName: Validate Install Script
+  inputs:
+    targetType: 'inline'
+    script: |
+      ./helpers/installcredprovider.ps1 ${{ parameters.scriptInputs }} -Force 6>> ./output.log
+      cat ./output.log
+      if( (Select-String -Path .\output.log -Pattern ${{ parameters.expectedCredentialProviderVersion }}) -eq $null) {echo "Expected credential provider file not found."; exit 1}
+    workingDirectory: $(Build.SourcesDirectory)

build/validate-install-script-ps.yml

@@ -0,0 +1,58 @@
+jobs:
+- job: WindowsInstallDefault
+  pool:
+    vmImage: windows-latest
+  steps:
+  - template: validate-install-script-powershell.yml@self
+    parameters:
+      repo: self
+      scriptInputs: ''
+      expectedCredentialProviderVersion: 'Microsoft.Net6.NuGet.CredentialProvider'
+- job: WindowsInstallNet8
+  pool:
+    vmImage: windows-latest
+  steps:
+  - template: validate-install-script-powershell.yml@self
+    parameters:
+      repo: self
+      scriptInputs: '-InstallNet8'
+      expectedCredentialProviderVersion: 'Microsoft.Net8.NuGet.CredentialProvider'
+- job: WindowsInstallNetfxDefault
+  pool:
+    vmImage: windows-latest
+  steps:
+  - template: validate-install-script-powershell.yml@self
+    parameters:
+      repo: self
+      scriptInputs: '-AddNetfx'
+      expectedCredentialProviderVersion: 'Microsoft.NuGet.CredentialProvider'
+- job: WindowsInstallNetfx48
+  pool:
+    vmImage: windows-latest
+  steps:
+  - template: validate-install-script-powershell.yml@self
+    parameters:
+      repo: self
+      scriptInputs: '-AddNetFx48'
+      expectedCredentialProviderVersion: 'Microsoft.NetFx48.NuGet.CredentialProvider'
+- job: LinuxInstallDefault
+  pool:
+    vmImage: ubuntu-latest
+  steps:
+  - template: validate-install-script-bash.yml@self
+    parameters:
+      repo: self
+      scriptEnvVariables: ''
+      expectedCredentialProviderVersion: 'Microsoft.Net6.NuGet.CredentialProvider'
+- job: LinuxInstallNet8
+  pool:
+    vmImage: ubuntu-latest
+  steps:
+  - template: validate-install-script-bash.yml@self
+    parameters:
+      repo: self
+      scriptEnvVariables: |
+        export USE_NET6_ARTIFACTS_CREDENTIAL_PROVIDER=false
+        export USE_NET8_ARTIFACTS_CREDENTIAL_PROVIDER=true
+      expectedCredentialProviderVersion: 'Microsoft.Net8.NuGet.CredentialProvider'
+