Fix dashboard URL logging

[JamesNK]

Description

Fixes #14248

The value returned from EndpointReference is the correct port, but has a localhost host. It doesn't reflect the target host value.

Update places where GetValueAsync is used to resolve dashboard URLs with a helper method that corrects the host.

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Link to aspire-docs issue (consider using one of the following templates):
      • New (or update) doc-idea template
      • New breaking-change template
      • New diagnostic template
  • No

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14287

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14287"

[Copilot]

Pull request overview

This PR fixes a regression where dashboard URLs displayed "localhost" instead of the configured localhost TLD (e.g., "aspire-dashboard.dev.localhost") when using the --localhost-tld template option. The issue affected the Aspire 13.2 project template.

Changes:

• Introduced EndpointHostHelpers.GetUrlWithTargetHostAsync() helper method to resolve endpoint URLs with the configured TLD hostname when applicable
• Updated dashboard URL logging in DashboardEventHandlers.cs to use the new helper method
• Updated API base URL resolution in DashboardUrlsHelper.cs to use the new helper method
• Expanded test coverage to verify correct URL resolution for multiple scenarios including localhost TLDs

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/Aspire.Hosting/ApplicationModel/EndpointHostHelpers.cs	Added internal helper method GetUrlWithTargetHostAsync() to adjust endpoint URLs for localhost TLD configuration
src/Aspire.Hosting/Dashboard/DashboardEventHandlers.cs	Updated dashboard URL logging to use the new helper method instead of direct GetValueAsync()
src/Aspire.Hosting/Backchannel/DashboardUrlsHelper.cs	Updated API base URL resolution to use the new helper method
tests/Aspire.Hosting.Tests/Dashboard/DashboardLifecycleHookTests.cs	Converted test to theory with multiple test cases covering localhost, localhost TLDs, and different schemes

[Copilot]

The Uri constructor on line 138 could throw an exception if allocatedUrl is not a valid absolute URI. While the check on line 127 ensures it's not null or empty, it doesn't validate that it's a well-formed URI. Consider adding a try-catch block or using Uri.TryCreate to handle potential format exceptions gracefully, especially since this is an internal utility method that may be called from various contexts.

Suggested change

	var uri = new Uri(allocatedUrl);
	return $"{uri.Scheme}://{targetHost}:{uri.Port}";
	if (Uri.TryCreate(allocatedUrl, UriKind.Absolute, out var uri))
	{
	return $"{uri.Scheme}://{targetHost}:{uri.Port}";
	}
	// If the allocated URL is not a valid absolute URI, return it unchanged.
	return allocatedUrl;

[github-actions]

🎬 CLI E2E Test Recordings

The following terminal recordings are available for commit a23539e:

Test	Recording
CreateAndDeployToDockerCompose	▶️ View Recording
CreateAndDeployToDockerComposeInteractive	▶️ View Recording
CreateAndRunAspireStarterProject	▶️ View Recording
CreateAndRunJsReactProject	▶️ View Recording
CreateAndRunPythonReactProject	▶️ View Recording
CreateEmptyAppHostProject	▶️ View Recording
CreateStartAndStopAspireProject	▶️ View Recording
CreateTypeScriptAppHostWithViteApp	▶️ View Recording
DoctorCommand_WithSslCertDir_ShowsTrusted	▶️ View Recording
DoctorCommand_WithoutSslCertDir_ShowsPartiallyTrusted	▶️ View Recording
PsCommandListsRunningAppHost	▶️ View Recording

---

_{📹 Recordings uploaded automatically from CI run #21586229647}

[karolz-ms]

There is probably a room for improvement for DCP here as well--opened microsoft/dcp#68 to pursue that.