Skip to content

Commit b719270

Browse files
author
Chinmaya Rath
committed
Reverted the property for sending Notifications to Teams
1 parent 008fb58 commit b719270

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ Step 2: Add/update the values for the following keys in the JSON
100100
| ApprovalsAudienceUrl | ```Microsoft Entra ID Resource (APP ID URL)``` | No |
101101
| ApprovalsBaseUrl | ```Approvals Website Base URL``` | No |
102102
| ApprovalsCoreServicesURL | ```Approvals API's Base URL``` | No |
103+
| Authority | ```URL that indicates a directory that MSAL can request tokens from``` | No |
103104
| AzureSearchServiceName | ```Azure Search``` | No |
104105
| AzureSearchServiceQueryApiKey | ```Azure Search``` | Yes |
105106
| CosmosDbAuthKey | ```Azure Cosmos DB``` | Yes |

source/dotnet/Contract/Approvals.Model/TeamsNotificationControllerInput.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public class TeamsNotificationControllerInput
1616
/// Gets or sets the user objectId for the notification receiver for the approval.
1717
/// </summary>
1818
[JsonProperty(Required = Required.Always)]
19-
public string[] NotificationReceiverObjectId { get; set; }
19+
public string[] NotificationReceiverAadId { get; set; }
2020

2121
/// <summary>
2222
/// Gets or sets the user objectId for the creator of the approval.

source/dotnet/Core/Approvals.NotificationProcessor.BL/NotificationProcessor.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ public async Task<bool> SendTeamsNotifications(ApprovalNotificationDetails reque
253253

254254
TeamsNotificationControllerInput teamsNotificationInput = new TeamsNotificationControllerInput()
255255
{
256-
NotificationReceiverObjectId = new string[approvers.Count],
256+
NotificationReceiverAadId = new string[approvers.Count],
257257
NotificationSender = string.Empty,
258258
Provider = ApprovalProviderType.Extensibility,
259259
EventType = ApprovalEventType.Creation,
@@ -278,7 +278,7 @@ public async Task<bool> SendTeamsNotifications(ApprovalNotificationDetails reque
278278

279279
for (int i = 0; i < approvers.Count; i++)
280280
{
281-
teamsNotificationInput.NotificationReceiverObjectId[i] = _nameResolutionHelper?.GetUser(approvers[i])?.Result?.Id;
281+
teamsNotificationInput.NotificationReceiverAadId[i] = _nameResolutionHelper?.GetUser(approvers[i])?.Result?.Id;
282282
}
283283

284284
teamsNotificationInput.Title = "Approvals - " + requestExpressions?.ApprovalIdentifier?.DisplayDocumentNumber + ": " + (string.IsNullOrWhiteSpace(summaryJson?.Title) ? string.Empty : summaryJson.Title);

0 commit comments

Comments
 (0)