Skip to content

Commit 3048c5d

Browse files
authored
Remove nodeapi hack as the library has been updated
1 parent 52ad24b commit 3048c5d

File tree

1 file changed

+1
-20
lines changed

1 file changed

+1
-20
lines changed

README.md

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -63,23 +63,4 @@ npm run pack:t2 prod // Creates VSIX for pullRequestInsights
6363
```
6464
Note: Option "dev" doesn't create a VSIX file. Instead, it prepares the output task folder ready for upload to an AzureDevOps account and test it.
6565

66-
### HACK for azure-devops-node-api bug
67-
68-
Currently, there's a bug in "queryTestResultsReportForBuild" API of azure-devops-node-api lib which causes a break in the email report data and make it report incorrectly. Until "9.0.2" version of this lib is released - below hack must be done:
69-
Go to "node_modules/azure-devops-node-api/Serialization.js" and change line number 216 from "return false" to "break". Should look like below.
70-
71-
Before publishing the emailreport task, do the same under "dist/emailreportextensions/emailreporttask/node_modules" folder (after running npm run pack:t1 but before tfx command).
72-
73-
```
74-
if (lowerCaseEnumName !== enumName) {
75-
for (var name in enumType.enumValues) {
76-
var value = enumType.enumValues[name];
77-
if (name.toLowerCase() === lowerCaseEnumName) {
78-
resultPart = value;
79-
break; // replacing return false
80-
}
81-
}
82-
}
83-
```
84-
85-
####
66+
####

0 commit comments

Comments
 (0)