Build Email Fixes (#33)

Co-authored-by: Krishna V <[email protected]>

Author: saikrishnav

Tasks/emailReportTask/config/pipeline/PipelineConfiguration.ts

@@ -109,8 +109,10 @@ export class PipelineConfiguration {
     if (this.testTabLink == null) {
       if (this.pipelineType == PipelineType.Release) {
         this.testTabLink = LinkHelper.getTestTabLinkInRelease(this);
+      } else if (this.pipelineType == PipelineType.Build) {
+        this.testTabLink = LinkHelper.getTestTabLinkInBuild(this);
       }
-    }
+    } 
     return this.testTabLink;
   }
 }

Tasks/emailReportTask/model/helpers/LinkHelper.ts

@@ -126,7 +126,7 @@ export class LinkHelper {
     return projectName + "/" + LinkHelper.BuildPipelineExtension;
   }
 
-  private static getTestTabLinkInBuild(config: PipelineConfiguration) {
+  public static getTestTabLinkInBuild(config: PipelineConfiguration) {
     var collectionUri = config.$teamUri;
     var parameters = new Map<string, string>(
       [

Tasks/emailReportTask/model/viewmodel/MailAddressViewModel.ts

@@ -61,7 +61,7 @@ export class MailAddressViewModel {
     if (!isNullOrUndefined(report.$failedTestOwners)) {
       report.$failedTestOwners.forEach(identity => {
         var mailAddress = this.getMailAddressFromIdentityRef(identity);
-        if (StringUtils.isNullOrWhiteSpace(mailAddress)) {
+        if (!StringUtils.isNullOrWhiteSpace(mailAddress)) {
           mailAddresses.push(mailAddress);
         }
       });

Tasks/emailReportTask/model/viewmodel/TestResultViewModel.ts

@@ -9,6 +9,7 @@ import { DisplayNameHelper } from "../../utils/DisplayNameHelper";
 import { ReleaseReferenceViewModel } from "./ReleaseReferenceViewModel";
 import { PipelineType } from "../../config/pipeline/PipelineType";
 import { BuildReferenceViewModel } from "./BuildReferenceViewModel";
+import { isNullOrUndefined } from "util";
 
 export class TestResultViewModelWrapper {
   public TestResultViewModel: TestResultViewModel[];
@@ -65,6 +66,16 @@ export class TestResultViewModel {
       }
     }
 
+    if(isNullOrUndefined(result.durationInMs)) {
+      if(!isNullOrUndefined(result.startedDate) && !isNullOrUndefined(result.completedDate)) {
+        result.durationInMs = result.completedDate.getTime() - result.startedDate.getTime();
+      }
+
+      if(isNullOrUndefined(result.durationInMs) || result.durationInMs < 0) {
+        // unknown duration - assume test didn't run instead of displaying "Undefined/NaN" in email
+        result.durationInMs = 0;
+      }
+    }
     this.Duration = TimeFormatter.FormatDuration(result.durationInMs);
     this.CreateBugLink = LinkHelper.getCreateBugLinkForTest(config, testResultModel.testResult);
   }

Tasks/emailReportTask/providers/restclients/AbstractTestResultsClient.ts

@@ -40,19 +40,15 @@ export abstract class AbstractTestResultsClient extends AbstractClient implement
     var query = new TestResultsQueryImpl();
     query.fields = ["Owner"];
 
-    const tasks: Promise<TestResultsQuery>[] = [];
+    const results: TestCaseResult[] = [];
     const testApi = await this.testApiPromise;
     for (let i = 0, j = resultsToFetch.length; i < j; i += this.MaxItemsSupported) {
       const tempArray = resultsToFetch.slice(i, i + this.MaxItemsSupported);
       query.results = tempArray;
-      tasks.push(RetryablePromise.RetryAsync(async () => testApi.getTestResultsByQuery(query, this.pipelineConfig.$projectName), "GetTestResultOwners"));
+      let queryResult: TestResultsQuery = await RetryablePromise.RetryAsync(async () => testApi.getTestResultsByQuery(query, this.pipelineConfig.$projectName), "GetTestResultOwners");
+      results.push(...queryResult.results);
     }
 
-    await Promise.all(tasks);
-
-    const results: TestCaseResult[] = [];
-    tasks.forEach(async t => results.push(...(await t).results));
-
     const ownerMap = new Map<string, IdentityRef>();
     results.forEach(r => {
       if (this.isValid(r.owner)) {