Skip to content

Commit bd97acf

Browse files
authored
Engineering Fixes: PR Validation, CI runs (#28)
* npm clean * CI only for master * CI only for master * Move npm install to package.json
1 parent 285b4f9 commit bd97acf

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

.github/workflows/build.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
11
name: Node CI
22

3-
on: [push, pull_request]
3+
on:
4+
push:
5+
branches:
6+
- master
7+
- 'releases/**'
8+
9+
pull_request:
10+
branches:
11+
- '*'
412

513
jobs:
614
build:
@@ -18,8 +26,7 @@ jobs:
1826
with:
1927
node-version: ${{ matrix.node-version }}
2028
- name: npm install, build, and test
21-
run: |
22-
npm install --no-optional
29+
run: |
2330
npm run build --if-present
2431
env:
2532
CI: true

Tasks/emailReportTask/config/ConfigurationProvider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,4 +166,4 @@ export class ConfigurationProvider implements IConfigurationProvider {
166166
default: return GroupTestResultsBy.Run;
167167
}
168168
}
169-
}
169+
}

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"description": "",
55
"scripts": {
66
"test": "npm run jest",
7-
"build": "npm run build:t1 && npm run build:t2",
7+
"build": "npm install --no-optional && npm run build:t1 && npm run build:t2",
88
"build:t1": "npm run build:emailreport",
99
"build:t2": "npm run build:prinsights",
1010
"pack:t1": "npm run clean && npm run build:t1 && npm run pack:emailreport",
@@ -17,7 +17,7 @@
1717
"pack:prinsights": "node ./commands/package.js pullRequestInsights",
1818
"e2e:emailreport": "node js/emailReportExtension/emailReportTask/tests/__e_to_e_tests__/InvokeTest.js",
1919
"e2e:prinsights": "node js/pullRequestInsightsExtension/pullRequestInsightsTask/tests/__e_to_e_tests__/InvokeTest.js",
20-
"clean": "rimraf dist *.vsix"
20+
"clean": "rimraf dist && rimraf node_modules"
2121
},
2222
"repository": {
2323
"type": "git",

0 commit comments

Comments
 (0)