Skip to content

User story1804670 : Use new track2 auth lib to replace auth-helper#1230

Merged
andxu merged 9 commits intodevelopfrom
feature-identity
Jan 22, 2021
Merged

User story1804670 : Use new track2 auth lib to replace auth-helper#1230
andxu merged 9 commits intodevelopfrom
feature-identity

Conversation

@wangmingliang-ms
Copy link
Contributor

@wangmingliang-ms wangmingliang-ms commented Jan 20, 2021

No description provided.

andxu and others added 4 commits January 12, 2021 13:38
@andxu
auth type: ServicePrincipal (#1207)
64bd3c4 
* auth type: ServicePrincipal

Co-authored-by: Andy Xu(devdiv) <andxu@microsoft>
@andxu
Resolve code comments in PR review #1207 (#1213)
4168ae3 
Co-authored-by: Andy Xu(devdiv) <andxu@microsoft>
@andxu
add azure cli/chained/device code/oauth/managed identity/vs login sup… (
6c8c0ed 
#1214)

* add azure cli/chained/device code/oauth/managed identity/vs login support

Co-authored-by: Andy Xu(devdiv) <andxu@microsoft>
@andxu
Bug fix for non-global azure cloud environment. (#1219)
554fa88 
* Bug fix for non-global azure cloud environment.

Co-authored-by: Andy Xu(devdiv) <andxu@microsoft>
@codecov-io
Copy link

codecov-io commented Jan 20, 2021 •
edited
Loading

Codecov Report

Merging #1230 (9d9e7d7) into develop (5d8e6b9) will decrease coverage by 11.98%.
The diff coverage is 1.37%.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #1230       +/-   ##
==============================================
- Coverage      31.97%   19.99%   -11.99%     
+ Complexity       453      200      -253     
==============================================
  Files             94       78       -16     
  Lines           4700     4092      -608     
  Branches         800      716       -84     
==============================================
- Hits            1503      818      -685     
- Misses          3053     3187      +134     
+ Partials         144       87       -57
Impacted Files Coverage Δ Complexity Δ
...oft/azure/maven/function/AbstractFunctionMojo.java 54.05% <ø> (ø) 10.00 <0.00> (ø)
...a/com/microsoft/azure/maven/AbstractAzureMojo.java 28.03% <0.00%> (-2.97%) 0.00 <0.00> (ø)
...microsoft/azure/maven/auth/AzureClientFactory.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...microsoft/azure/maven/auth/MavenSettingHelper.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...t/azure/maven/exception/MavenDecryptException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...soft/azure/maven/model/MavenAuthConfiguration.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...icrosoft/azure/maven/model/SubscriptionOption.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...om/microsoft/azure/maven/utils/MavenAuthUtils.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...soft/azure/maven/springcloud/AbstractMojoBase.java 1.28% <0.00%> (-44.80%) 1.00 <0.00> (-13.00)
.../microsoft/azure/maven/springcloud/ConfigMojo.java 0.00% <0.00%> (-77.91%) 0.00 <0.00> (-44.00)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8e6b9...9d9e7d7. Read the comment docs.

@andxu andxu changed the title identity Merge identity feature to develop Jan 20, 2021
andxu and others added 5 commits January 21, 2021 09:30
@andxu
add vscode login and use map to handle all azure environments (#1226)
6493004 
* add vscode login and use map to handle all azure environments


Co-authored-by: Andy Xu(devdiv) <andxu@microsoft>
@andxu
use auth-lib in all maven plugins (#1235)
9d9e7d7 
* use auth-lib in all maven plugins: webapp/functions/azure spring cloud

Co-authored-by: Andy Xu(devdiv) <andxu@microsoft>
@andxu
fix bug of 403 on zipDeploy (#1239)
659eabd 
* fix bug of 403 on zipDeploy

Co-authored-by: Andy Xu(devdiv) <andxu@microsoft>
@andxu
Merge remote-tracking branch 'origin/develop' into feature-identity
1bcd203 
# Conflicts:
#	azure-spring-cloud-maven-plugin/src/main/java/com/microsoft/azure/maven/springcloud/AbstractMojoBase.java
#	azure-spring-cloud-maven-plugin/src/test/java/com/microsoft/azure/maven/springcloud/ConfigMojoTest.java
rename field name: azureCredentialWrapper
ddb6f66
@andxu andxu changed the title Merge identity feature to develop User story1804670 : Use new track2 auth lib to replace auth-helper Jan 22, 2021
@andxu andxu merged commit e7bab76 into develop Jan 22, 2021
@andxu andxu deleted the feature-identity branch July 9, 2021 03:52
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 1.37615% with 215 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.04%. Comparing base (3ae45db) to head (ddb6f66).
⚠️ Report is 3917 commits behind head on develop.

Files with missing lines Patch % Lines
...a/com/microsoft/azure/maven/AbstractAzureMojo.java 0.00% 66 Missing and 1 partial ⚠️
...a/com/microsoft/azure/maven/webapp/ConfigMojo.java 0.00% 43 Missing ⚠️
...microsoft/azure/maven/auth/MavenSettingHelper.java 0.00% 38 Missing ⚠️
...om/microsoft/azure/maven/utils/MavenAuthUtils.java 0.00% 33 Missing ⚠️
...soft/azure/maven/springcloud/AbstractMojoBase.java 0.00% 11 Missing ⚠️
.../microsoft/azure/maven/AbstractAppServiceMojo.java 28.57% 5 Missing ⚠️
...microsoft/azure/maven/auth/AzureClientFactory.java 0.00% 5 Missing ⚠️
...com/microsoft/azure/maven/function/DeployMojo.java 20.00% 4 Missing ⚠️
...soft/azure/maven/model/MavenAuthConfiguration.java 0.00% 3 Missing ⚠️
.../microsoft/azure/maven/springcloud/ConfigMojo.java 0.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@              Coverage Diff               @@
##             develop    #1230       +/-   ##
==============================================
- Coverage      32.15%   20.04%   -12.11%     
+ Complexity       454      200      -254     
==============================================
  Files             94       78       -16     
  Lines           4683     4075      -608     
  Branches         789      705       -84     
==============================================
- Hits            1506      817      -689     
- Misses          3033     3171      +138     
+ Partials         144       87       -57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flanker32 Flanker32 Flanker32 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wangmingliang-ms @codecov-io @codecov-commenter @Flanker32 @andxu