Merge remote-tracking branch 'origin/master' into Localization

Author: vmapetr

.azure-pipelines/pipeline.yml

@@ -69,6 +69,8 @@ resources:
 extends:
   template: v1/1ES.Official.PipelineTemplate.yml@1ESPipelineTemplates
   parameters:
+    settings:
+      skipBuildTagsForGitHubPullRequests: true
     featureFlags:
       autoBaseline: false
     sdl:

.vsts.release.yml

@@ -210,21 +210,21 @@ extends:
             displayName: Upload to Azure Blob
             inputs:
               azurePowerShellVersion: 'LatestVersion'
-              azureSubscription: 'azure-pipelines-agent-vstsagentpackage'
+              azureSubscription: 'azure-pipelines-agent-vstsagentpackage-oauth'
               scriptType: 'InlineScript'
               inline: |
                 Write-Host "Preloading Azure modules." # This is for better performance, to avoid module-autoloading.
                 Import-Module Azure, Az.Accounts, Az.Storage, Az.Cdn -ErrorAction Ignore -PassThru
                 $uploadFiles = New-Object System.Collections.ArrayList
                 Select-AzSubscription -SubscriptionId $(SubscriptionId)
-                $storage = Get-AzStorageAccount -ResourceGroupName vstsagentpackage -AccountName vstsagentpackage
+                $storageContext = New-AzStorageContext -StorageAccountName vstsagentpackage -UseConnectedAccount
                 $versionDir = "$(AgentVersion)"
                 Get-ChildItem -LiteralPath "$(System.ArtifactsDirectory)/agent" | ForEach-Object {
                   $target=$_
                   Get-ChildItem -LiteralPath "$(System.ArtifactsDirectory)/agent/$target" -Include "*.zip","*.tar.gz" | ForEach-Object {
                     $executable = $_
                     Write-Host "Uploading $executable to BlobStorage vstsagentpackage/agent/$versionDir"
-                    Set-AzStorageBlobContent -Context $storage.Context -Container agent -File "$(System.ArtifactsDirectory)/agent/$target/$executable" -Blob "$versionDir/$executable" -Force
+                    Set-AzStorageBlobContent -Context $storageContext -Container agent -File "$(System.ArtifactsDirectory)/agent/$target/$executable" -Blob "$versionDir/$executable" -Force
                     $uploadFiles.Add("/agent/$versionDir/$executable")
                   }
                 }

src/Agent.Worker/TestResults/Utils/FeatureFlagService.cs

@@ -44,9 +44,11 @@ public bool GetFeatureFlagState(string featureFlagName, Guid serviceInstanceId)
                 }
                 _executionContext.Debug(StringUtil.Format("{0} is off", featureFlagName));
             }
-            catch
+            catch(Exception ex)
             {
-                _executionContext.Debug(StringUtil.Format("Failed to get FF {0} Value.", featureFlagName));
+                var exceptionMessage = StringUtil.Format("Failed to get FF {0} Value. Error: {1}", featureFlagName, ex.ToString());
+                _executionContext.Warning(exceptionMessage);
+                Trace.Error(exceptionMessage);
             }
             return false;
         }

src/Misc/externals.sh

@@ -19,8 +19,8 @@ NODE_VERSION="6.17.1"
 NODE10_VERSION="10.24.1"
 NODE16_VERSION="16.20.2"
 NODE20_VERSION="20.13.1"
-MINGIT_VERSION="2.43.0"
-FF_MINGIT_VERSION="2.44.0"
+MINGIT_VERSION="2.39.1"
+FF_MINGIT_VERSION="2.43.0"
 LFS_VERSION="3.3.0"
 
 get_abs_path() {