Validation cleanup (#1179)

* Remove outdated tests

* Remove unnecessary function calls

* Bump versions

Author: LeftTwixWand

Extensions/IISWebAppDeploy/Src/Tasks/IISWebAppDeploy/IISWebAppDeployV1/MsDeployOnTargetMachines.ps1

@@ -59,25 +59,6 @@ function Get-MsDeployLocation
     return (Join-Path $path msDeploy.exe)
 }
 
-function Get-ValidatedAdditionalArguments([string]$msDeployCmdArgs, [string]$additionalArguments)
-{
-    # Remove content within double quotes
-    $noQuotesContent = $additionalArguments -replace '"[^"]*"', ''
-
-    # Check if forbidden characters exist in the remaining content
-    if ($noQuotesContent -match "[&;|]") {
-        $additionalArgumentsValidationErrorMessage = "Additional arguments can't include separator characters '&', ';' and '|'. Please verify input. To learn more about argument validation, please check https://aka.ms/azdo-task-argument-validation"
-        throw $additionalArgumentsValidationErrorMessage
-    }
-    
-    if(-not [string]::IsNullOrWhiteSpace($additionalArguments))
-    {
-        return [string]::Format('{0} {1}', $msDeployCmdArgs, $additionalArguments)
-    }
-
-    return $msDeployCmdArgs
-}
-
 function Get-MsDeployCmdArgs
 {
     param(
@@ -159,8 +140,6 @@ function Get-MsDeployCmdArgs
         $msDeployCmdArgs = [string]::Format('{0} -skip:Directory="\\App_Data"', $msDeployCmdArgs)
     }
 
-    $msDeployCmdArgs = Get-ValidatedAdditionalArguments $msDeployCmdArgs $additionalArguments
-
     $msDeployCmdArgs = [string]::Format('{0} -retryAttempts:3 -retryInterval:3000', $msDeployCmdArgs)
     Write-Verbose "MsDeploy command line arguments: $msDeployCmdArgs"
     return $msDeployCmdArgs

Extensions/IISWebAppDeploy/Src/Tasks/IISWebAppDeploy/IISWebAppDeployV1/task.json

@@ -7,7 +7,7 @@
   "version": {
     "Major": 1,
     "Minor": 5,
-    "Patch": 1
+    "Patch": 2
   },
   "demands": [
   ],

Extensions/IISWebAppDeploy/Src/Tasks/IISWebAppDeploy/IISWebAppDeployV2/MsDeployOnTargetMachines.ps1

@@ -59,25 +59,6 @@ function Get-MsDeployLocation
     return (Join-Path $path msDeploy.exe)
 }
 
-function Get-ValidatedAdditionalArguments([string]$msDeployCmdArgs, [string]$additionalArguments)
-{
-    # Remove content within double quotes
-    $noQuotesContent = $additionalArguments -replace '"[^"]*"', ''
-
-    # Check if forbidden characters exist in the remaining content
-    if ($noQuotesContent -match "[&;|]") {
-        $additionalArgumentsValidationErrorMessage = "Additional arguments can't include separator characters '&', ';' and '|'. Please verify input. To learn more about argument validation, please check https://aka.ms/azdo-task-argument-validation"
-        throw $additionalArgumentsValidationErrorMessage
-    }
-    
-    if(-not [string]::IsNullOrWhiteSpace($additionalArguments))
-    {
-        return [string]::Format('{0} {1}', $msDeployCmdArgs, $additionalArguments)
-    }
-
-    return $msDeployCmdArgs
-}
-
 function Get-MsDeployCmdArgs
 {
     param(
@@ -159,8 +140,6 @@ function Get-MsDeployCmdArgs
         $msDeployCmdArgs = [string]::Format('{0} -skip:Directory="\\App_Data"', $msDeployCmdArgs)
     }
 
-    $msDeployCmdArgs = Get-ValidatedAdditionalArguments $msDeployCmdArgs $additionalArguments
-
     $msDeployCmdArgs = [string]::Format('{0} -retryAttempts:3 -retryInterval:3000', $msDeployCmdArgs)
     Write-Verbose "MsDeploy command line arguments: $msDeployCmdArgs"
     return $msDeployCmdArgs

Extensions/IISWebAppDeploy/Src/Tasks/IISWebAppDeploy/IISWebAppDeployV2/task.json

@@ -16,7 +16,7 @@
   "version": {
     "Major": 2,
     "Minor": 1,
-    "Patch": 1
+    "Patch": 2
   },
   "demands": [
   ],

Extensions/IISWebAppDeploy/Src/Tasks/IISWebAppMgmt/IISWebAppMgmtV1/ManageIISWebApp.ps1

@@ -83,18 +83,6 @@ function Escape-SpecialChars
     return $str.Replace('`', '``').Replace('"', '`"').Replace('$', '`$')
 }
 
-function Validate-AdditionalArguments([string]$additionalArguments)
-{
-    # Remove content within double quotes
-    $noQuotesContent = $additionalArguments -replace '"[^"]*"', ''
-
-    # Check if forbidden characters exist in the remaining content
-    if ($noQuotesContent -match "[&;|]") {
-        $additionalArgumentsValidationErrorMessage = "Additional arguments can't include separator characters '&', ';' and '|'. Please verify input. To learn more about argument validation, please check https://aka.ms/azdo-task-argument-validation"
-        throw $additionalArgumentsValidationErrorMessage
-    }
-}
-
 function Get-ScriptToRun
 {
     param (
@@ -227,7 +215,6 @@ function Main
     Trim-Inputs -siteName ([ref]$websiteName) -physicalPath ([ref]$websitePhysicalPath)  -poolName ([ref]$appPoolName) -websitePathAuthuser ([ref]$websiteAuthUserName) -appPoolUser ([ref]$appPoolUsername) -adminUser ([ref]$adminUserName) -sslCertThumbPrint ([ref]$sslCertThumbPrint)
 
     Validate-Inputs -createWebsite $createWebsite -websiteName $websiteName -createAppPool $createAppPool -appPoolName $appPoolName -addBinding $addBinding -protocol $protocol -sslCertThumbPrint $sslCertThumbPrint
-    Validate-AdditionalArguments $appCmdCommands
 
     $script = Get-ScriptToRun -createWebsite $createWebsite -websiteName $websiteName -websitePhysicalPath $websitePhysicalPath -websitePhysicalPathAuth $websitePhysicalPathAuth -websiteAuthUserName $websiteAuthUserName -websiteAuthUserPassword $websiteAuthUserPassword -addBinding $addBinding -protocol $protocol -ipAddress $ipAddress -port $port -hostName $hostName -serverNameIndication $serverNameIndication -sslCertThumbPrint $sslCertThumbPrint -createAppPool $createAppPool -appPoolName $appPoolName -pipeLineMode $pipeLineMode -dotNetVersion $dotNetVersion -appPoolIdentity $appPoolIdentity -appPoolUsername $appPoolUsername -appPoolPassword $appPoolPassword -appCmdCommands $appCmdCommands
     Run-RemoteDeployment -machinesList $machinesList -scriptToRun $script -adminUserName $adminUserName -adminPassword $adminPassword -winrmProtocol $winrmProtocol -testCertificate $testCertificate -deployInParallel $deployInParallel -websiteName $websiteName

Extensions/IISWebAppDeploy/Src/Tasks/IISWebAppMgmt/IISWebAppMgmtV1/task.json

@@ -16,7 +16,7 @@
   "version": {
     "Major": 1,
     "Minor": 4,
-    "Patch": 1
+    "Patch": 2
   },
   "demands": [
   ],

Extensions/IISWebAppDeploy/Src/Tasks/IISWebAppMgmt/IISWebAppMgmtV2/Main.ps1

@@ -79,7 +79,6 @@ try {
     $appPoolPassword = Escape-SpecialChars -str $appPoolPassword
     $websiteAuthUserPassword = Escape-SpecialChars -str $websiteAuthUserPassword
     $appCmdCommands = Escape-SpecialChars -str $appCmdCommands
-    Validate-AdditionalArguments $appCmdCommands
 
     $invokeMain = ""
     $invokeMainLog = ""

Extensions/IISWebAppDeploy/Src/Tasks/IISWebAppMgmt/IISWebAppMgmtV2/Utility.ps1

@@ -321,18 +321,6 @@ function Validate-Bindings {
     return $bindingsObj.bindings
 }
 
-function Validate-AdditionalArguments([string]$additionalArguments)
-{
-    # Remove content within double quotes
-    $noQuotesContent = $additionalArguments -replace '"[^"]*"', ''
-
-    # Check if forbidden characters exist in the remaining content
-    if ($noQuotesContent -match "[&;|]") {
-        $additionalArgumentsValidationErrorMessage = "Additional arguments can't include separator characters '&', ';' and '|'. Please verify input. To learn more about argument validation, please check https://aka.ms/azdo-task-argument-validation"
-        throw $additionalArgumentsValidationErrorMessage
-    }
-}
-
 function Escape-SpecialChars
 {
     param(

Extensions/IISWebAppDeploy/Src/Tasks/IISWebAppMgmt/IISWebAppMgmtV2/task.json

@@ -16,7 +16,7 @@
   "version": {
     "Major": 2,
     "Minor": 2,
-    "Patch": 1
+    "Patch": 2
   },
   "demands": [
   ],

Extensions/IISWebAppDeploy/Src/Tasks/IISWebAppMgmt/IISWebAppMgmtV3/Main.ps1

@@ -84,7 +84,6 @@ try {
     $appPoolPassword = Escape-SpecialChars -str $appPoolPassword
     $websiteAuthUserPassword = Escape-SpecialChars -str $websiteAuthUserPassword
     $appCmdCommands = Escape-SpecialChars -str $appCmdCommands
-    Validate-AdditionalArguments $appCmdCommands
 
     $invokeMain = ""
     $invokeMainLog = ""