You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since at the moment work is proceeding on migrating to Node16, you need to remember the following:
6
-
7
-
- master branch for SDK v3 (stable and targets Node10)
8
-
- releases/4.x branch for SDK v4 (preview and targets Node16)
9
-
- Changes that were merged for SDK v3 should be cherry-picked for SDK v4 once they are merged to the master branch
10
-
11
3
## Contributing bug fixes
12
4
13
5
We are currently accepting contributions in the form of bug fixes. A bug must have an issue tracking it in the issue tracker. Your pull request should include a link to the bug that you are fixing. If you've submitted a PR for a bug, please post a comment in the bug to avoid duplication of effort.
@@ -22,21 +14,20 @@ Design changes will not be accepted at this time. If you have a design change pr
22
14
23
15
You will need to complete a Contributor License Agreement (CLA). Briefly, this agreement testifies that you are granting us permission to use the submitted change according to the terms of the project's license, and that the work being submitted is under appropriate copyright.
24
16
25
-
Please submit a Contributor License Agreement (CLA) before submitting a pull request. You may visit https://cla.microsoft.com to sign digitally.
17
+
Please submit a Contributor License Agreement (CLA) before submitting a pull request. You may visit <https://cla.microsoft.com> to sign digitally.
26
18
27
19
## Housekeeping
28
20
29
-
Your pull request should:
21
+
Your pull request should:
30
22
31
23
* Include a description of what your change intends to do
32
-
* Be a child commit of a reasonably recent commit in the **master** branch
33
-
* Requests need not be a single commit, but should be a linear sequence of commits (i.e. no merge commits in your PR)
24
+
* Be a child commit of a reasonably recent commit in the **master** branch
25
+
* Requests need not be a single commit, but should be a linear sequence of commits (i.e. no merge commits in your PR)
34
26
* It is desirable, but not necessary, for the tests to pass at each commit
35
-
* Have clear commit messages
36
-
* e.g. "Refactor feature", "Fix issue", "Add tests for issue"
37
-
* Include adequate tests
38
-
* At least one test should fail in the absence of your non-test code changes. If your PR does not match this criteria, please specify why
39
-
* Tests should include reasonable permutations of the target fix/change
40
-
* Include baseline changes with your change
41
-
* All changed code must have 100% code coverage
42
-
27
+
* Have clear commit messages
28
+
* e.g. "Refactor feature", "Fix issue", "Add tests for issue"
29
+
* Include adequate tests
30
+
* At least one test should fail in the absence of your non-test code changes. If your PR does not match this criteria, please specify why
31
+
* Tests should include reasonable permutations of the target fix/change
0 commit comments