Change implicit check in getResponse to explicit (#788)

kuleshovilya · web-flow · commit 96ad5c614248 · 2021-08-19T17:51:53.000+03:00
* change implicit check for explicit

* bump patch version

* bump package lock

Co-authored-by: Ilya Kuleshov &lt;v-ikuleshov@microsoft.com&gt;
diff --git a/node/mock-answer.ts b/node/mock-answer.ts
@@ -47,7 +47,8 @@ export class MockAnswers {
 
         const cmd_answer = this._answers[cmd]!;
 
-        if (cmd_answer[key]) {
+        //use this construction to avoid falsy zero
+        if (cmd_answer[key] != null) {
             debug('found mock response');
             return cmd_answer[key];
         }
diff --git a/node/package-lock.json b/node/package-lock.json
diff --git a/node/package.json b/node/package.json
@@ -1,6 +1,6 @@
 {
   "name": "azure-pipelines-task-lib",
-  "version": "3.1.7",
+  "version": "3.1.8",
   "description": "Azure Pipelines Task SDK",
   "main": "./task.js",
   "typings": "./task.d.ts",

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,8 @@ export class MockAnswers {`
`47`	`47`
`48`	`48`	`const cmd_answer = this._answers[cmd]!;`
`49`	`49`
`50`		`- if (cmd_answer[key]) {`
	`50`	`+ //use this construction to avoid falsy zero`
	`51`	`+ if (cmd_answer[key] != null) {`
`51`	`52`	`debug('found mock response');`
`52`	`53`	`return cmd_answer[key];`
`53`	`54`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "azure-pipelines-task-lib",`
`3`		`- "version": "3.1.7",`
	`3`	`+ "version": "3.1.8",`
`4`	`4`	`"description": "Azure Pipelines Task SDK",`
`5`	`5`	`"main": "./task.js",`
`6`	`6`	`"typings": "./task.d.ts",`