Updated PSLIB_InvalidPattern0 to be more readable (#876)

* Updated PSLIB_InvalidPattern0 to be more readable

* Update LegacyFindFunctions.ps1

Co-authored-by: Kirill Ivlev <[email protected]>

Author: abatishchev

powershell/VstsTaskSdk/LegacyFindFunctions.ps1

@@ -132,7 +132,7 @@ function Find-Files {
         }
 
         # Validate pattern does not end with a \.
-        if ($pattern[$pattern.Length - 1] -eq [System.IO.Path]::DirectorySeparatorChar) {
+        if ($pattern.EndsWith([System.IO.Path]::DirectorySeparatorChar)) {
             throw (Get-LocString -Key PSLIB_InvalidPattern0 -ArgumentList $pattern)
         }
 

powershell/VstsTaskSdk/Strings/resources.resjson/en-US/resources.resjson

@@ -6,7 +6,7 @@
   "loc.messages.PSLIB_EnumeratingSubdirectoriesFailedForPath0": "Enumerating subdirectories failed for path: '{0}'",
   "loc.messages.PSLIB_FileNotFound0": "File not found: '{0}'",
   "loc.messages.PSLIB_Input0": "'{0}' input",
-  "loc.messages.PSLIB_InvalidPattern0": "Invalid pattern: '{0}'",
+  "loc.messages.PSLIB_InvalidPattern0": "Path cannot end with a directory separator character: '{0}'",
   "loc.messages.PSLIB_LeafPathNotFound0": "Leaf path not found: '{0}'",
   "loc.messages.PSLIB_PathLengthNotReturnedFor0": "Path normalization/expansion failed. The path length was not returned by the Kernel32 subsystem for: '{0}'",
   "loc.messages.PSLIB_PathNotFound0": "Path not found: '{0}'",
@@ -15,4 +15,4 @@
   "loc.messages.PSLIB_StringFormatFailed": "String format failed.",
   "loc.messages.PSLIB_StringResourceKeyNotFound0": "String resource key not found: '{0}'",
   "loc.messages.PSLIB_TaskVariable0": "'{0}' task variable"
-}
+}