Skip to content

Commit 8fbb51f

Browse files
azure-arm-rest (#322)
- moved HttpClient to method call - added dispose method to HttpClient
1 parent c6d7d40 commit 8fbb51f

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

common-npm-packages/azure-arm-rest/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common-npm-packages/azure-arm-rest/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "azure-pipelines-tasks-azure-arm-rest",
3-
"version": "3.241.1",
3+
"version": "3.241.2",
44
"description": "Common Lib for Azure ARM REST apis",
55
"repository": {
66
"type": "git",

common-npm-packages/azure-arm-rest/webClient.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ var requestOptions: httpInterfaces.IRequestOptions = proxyUrl ? {
2020
let ignoreSslErrors: string = tl.getVariable("VSTS_ARM_REST_IGNORE_SSL_ERRORS");
2121
requestOptions.ignoreSslError = ignoreSslErrors && ignoreSslErrors.toLowerCase() == "true";
2222

23-
var httpCallbackClient = new httpClient.HttpClient(tl.getVariable("AZURE_HTTP_USER_AGENT"), null, requestOptions);
23+
var azureHttpUserAgent = tl.getVariable("AZURE_HTTP_USER_AGENT");
2424

2525
export class WebRequest {
2626
public method: string;
@@ -112,8 +112,13 @@ export function sleepFor(sleepDurationInSeconds): Promise<any> {
112112

113113
async function sendRequestInternal(request: WebRequest): Promise<WebResponse> {
114114
tl.debug(util.format("[%s]%s", request.method, request.uri));
115+
var httpCallbackClient = new httpClient.HttpClient(azureHttpUserAgent, null, requestOptions);
116+
115117
var response: httpClient.HttpClientResponse = await httpCallbackClient.request(request.method, request.uri, request.body, request.headers);
116-
return await toWebResponse(response);
118+
const weResponse = await toWebResponse(response);
119+
120+
httpCallbackClient.dispose();
121+
return weResponse;
117122
}
118123

119124
async function toWebResponse(response: httpClient.HttpClientResponse): Promise<WebResponse> {

0 commit comments

Comments
 (0)