Fix issues with download tasks. (#6198)

* Using local copy of vso-node-api. (#6116)

* Fix broken url resolution. (#6127)

* Fix issues with encoding. (#6187)

* Fix container path encoding while downloading artifacts.

* Fix artifact download transform filenames with "=" into &#x3D

* bump jenkins download task version

* update artifact engine version for download tasks.

Author: omeshp

Tasks/DownloadBuildArtifacts/main.ts

@@ -3,9 +3,9 @@ var url = require('url');
 var fs = require('fs');
 
 import * as tl from 'vsts-task-lib/task';
-import { IBuildApi } from 'vso-node-api/BuildApi';
-import { IRequestHandler } from 'vso-node-api/interfaces/common/VsoBaseInterfaces';
-import { WebApi, getHandlerFromToken } from 'vso-node-api/WebApi';
+import { IBuildApi } from './vso-node-api/BuildApi';
+import { IRequestHandler } from './vso-node-api/interfaces/common/VsoBaseInterfaces';
+import { WebApi, getHandlerFromToken } from './vso-node-api/WebApi';
 
 import * as models from 'artifact-engine/Models';
 import * as engine from 'artifact-engine/Engine';
@@ -149,7 +149,7 @@ async function main(): Promise<void> {
                     var containerId: number = parseInt(containerParts[1]);
                     var containerPath: string = containerParts[2];
 
-                    var itemsUrl = endpointUrl + "/_apis/resources/Containers/" + containerId + "?itemPath=" + containerPath + "&isShallow=true&api-version=4.1-preview.4";
+                    var itemsUrl = endpointUrl + "/_apis/resources/Containers/" + containerId + "?itemPath=" + encodeURIComponent(containerPath) + "&isShallow=true&api-version=4.1-preview.4";
                     console.log(tl.loc("DownloadArtifacts", itemsUrl));
 
                     var variables = {};
@@ -163,7 +163,7 @@ async function main(): Promise<void> {
                 }
                 else if (artifact.resource.type.toLowerCase() === "filepath") {
                     let downloader = new engine.ArtifactEngine();
-                    let downloadUrl = decodeURI(artifact.resource.downloadUrl.replace("file:", ""));
+                    let downloadUrl = decodeURIComponent(artifact.resource.downloadUrl.replace("file:", ""));
                     let artifactLocation = downloadUrl + '/' + artifact.name;
                     if (!fs.existsSync(artifactLocation)) {
                         console.log(tl.loc("ArtifactNameDirectoryNotFound", artifactLocation, downloadUrl));

Tasks/DownloadBuildArtifacts/package.json

@@ -19,6 +19,6 @@
   "dependencies": {
     "vsts-task-lib": "2.1.0",
     "vso-node-api": "^6.2.8-preview",
-    "artifact-engine": "0.1.14"
+    "artifact-engine": "0.1.15"
   }
 }

Tasks/DownloadBuildArtifacts/task.json

@@ -10,7 +10,7 @@
   "version": {
     "Major": 0,
     "Minor": 127,
-    "Patch": 5
+    "Patch": 6
   },
   "groups": [
     {

Tasks/DownloadBuildArtifacts/task.loc.json

@@ -10,7 +10,7 @@
   "version": {
     "Major": 0,
     "Minor": 127,
-    "Patch": 5
+    "Patch": 6
   },
   "groups": [
     {

Tasks/DownloadBuildArtifacts/vso-node-api/BuildApi.ts

@@ -0,0 +1,51 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import vsom = require('./VsoClient');
+import VsoBaseInterfaces = require('./interfaces/common/VsoBaseInterfaces');
+import serm = require('./Serialization');
+import * as rm from 'artifact-engine/Providers/typed-rest-client/RestClient';
+import * as hm from 'artifact-engine/Providers/typed-rest-client/HttpClient';
+
+export class ClientApiBase {
+    baseUrl: string;
+    userAgent: string;
+    http: hm.HttpClient;
+    rest: rm.RestClient;
+
+    vsoClient: vsom.VsoClient;
+
+    constructor(baseUrl: string, handlers: VsoBaseInterfaces.IRequestHandler[], userAgent?: string, options?: VsoBaseInterfaces.IRequestOptions);
+
+    constructor(baseUrl: string, handlers: VsoBaseInterfaces.IRequestHandler[], userAgent: string, options?: VsoBaseInterfaces.IRequestOptions) {
+        this.baseUrl = baseUrl;
+
+        this.http = new hm.HttpClient(userAgent, handlers, options);
+        this.rest = new rm.RestClient(userAgent, null, handlers, options);
+
+        this.vsoClient = new vsom.VsoClient(baseUrl, this.rest);
+        this.userAgent = userAgent;
+    }
+
+    public createAcceptHeader(type: string, apiVersion?: string): string {
+        return type + (apiVersion ? (';api-version=' + apiVersion) : '');
+    }
+
+    public createRequestOptions(type: string, apiVersion?: string) {
+        let options: rm.IRequestOptions = <rm.IRequestOptions>{};
+        options.acceptHeader = this.createAcceptHeader(type, apiVersion);
+        return options;
+    }
+
+    public formatResponse(data: any, responseTypeMetadata: any, isCollection: boolean): any {
+        let serializationData = {
+            responseTypeMetadata: responseTypeMetadata,
+            responseIsCollection: isCollection
+        };
+        let deserializedResult = serm.ContractSerializer.deserialize(data,
+            serializationData.responseTypeMetadata,
+            false,
+            serializationData.responseIsCollection);
+        return deserializedResult;
+    }
+}