Upgrade MavenV4 to NodeJS 16 (#17013)

* Task and tests upgraded to Node 16

* Fixed task version

Author: Roman-Shchukin

Tasks/MavenV4/Tests/L0RestoreOriginalPomXml.ts

@@ -105,7 +105,7 @@ const originalPomXmlContents = 'original pom.xml contents';
 
 const fsClone = Object.assign({}, fs);
 Object.assign(fsClone, {
-    readFileSync(filename: string, encoding: string): string {
+    readFileSync(filename: string, encoding: BufferEncoding ): string {
         if (filename === 'pom.xml' && encoding === 'utf8') {
             console.log('Reading original pom.xml');
             return originalPomXmlContents;

Tasks/MavenV4/make.json

@@ -0,0 +1,17 @@
+{
+	"rm": [
+        {
+            "items": [
+                "node_modules/azure-pipelines-tasks-codeanalysis-common/node_modules/azure-pipelines-task-lib",
+                "node_modules/azure-pipelines-tasks-codeanalysis-common/node_modules/azure-pipeline-tool-lib",
+                "node_modules/azure-pipelines-tasks-codecoverage-tools/node_modules/azure-pipelines-task-lib",
+                "node_modules/azure-pipelines-tasks-codecoverage-tools/node_modules/azure-pipeline-tool-lib",
+                "node_modules/azure-pipelines-tasks-java-common/node_modules/azure-pipelines-task-lib",
+                "node_modules/azure-pipelines-tasks-java-common/node_modules/azure-pipeline-tool-lib",
+                "node_modules/azure-pipelines-tasks-packaging-common-v3/node_modules/azure-pipelines-task-lib",
+                "node_modules/azure-pipelines-tasks-packaging-common-v3/node_modules/azure-pipeline-tool-lib"
+            ],
+            "options": "-Rf"
+        }
+    ]
+}

Tasks/MavenV4/package-lock.json

@@ -10,8 +10,8 @@
   "dependencies": {
     "@types/jsdom": "^16.2.14",
     "@types/mocha": "^5.2.7",
-    "@types/node": "^10.17.0",
-    "azure-pipelines-task-lib": "^3.1.2",
+    "@types/node": "^16.11.39",
+    "azure-pipelines-task-lib": "^4.0.0-preview",
     "azure-pipelines-tasks-codeanalysis-common": "2.0.3",
     "azure-pipelines-tasks-codecoverage-tools": "3.210.0",
     "azure-pipelines-tasks-java-common": "2.198.1",

Tasks/MavenV4/package.json

@@ -17,7 +17,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 4,
-        "Minor": 210,
+        "Minor": 212,
         "Patch": 0
     },
     "releaseNotes": "Configuration of the SonarQube analysis was moved to the [SonarQube](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarqube) or [SonarCloud](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarcloud) extensions, in task `Prepare Analysis Configuration`",
@@ -471,6 +471,10 @@
         "Node10": {
             "target": "maventask.js",
             "argumentFormat": ""
+        },
+        "Node16": {
+            "target": "maventask.js",
+            "argumentFormat": ""
         }
     },
     "messages": {

Tasks/MavenV4/task.json

@@ -17,8 +17,8 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 4,
-    "Minor": 210,
-    "Patch": 0
+    "Minor": 212,
+    "Patch": 1
   },
   "releaseNotes": "ms-resource:loc.releaseNotes",
   "demands": [
@@ -471,6 +471,10 @@
     "Node10": {
       "target": "maventask.js",
       "argumentFormat": ""
+    },
+    "Node16": {
+      "target": "maventask.js",
+      "argumentFormat": ""
     }
   },
   "messages": {

Tasks/MavenV4/task.loc.json

@@ -9,7 +9,7 @@ import * as shelljs from 'shelljs';
  * @param encoding - encoding of the file. Default is "utf-8"
  * @returns string representation of the content
  */
-export async function readFile(filePath: string, encoding?: string): Promise<string> {
+export async function readFile(filePath: string, encoding?: BufferEncoding): Promise<string> {
     try {
         tl.debug(`Reading file at path: ${filePath}`);
         return new Promise<string>((resolve, reject) =>
@@ -33,7 +33,7 @@ export async function readFile(filePath: string, encoding?: string): Promise<str
  * @param fileContent - Content of the file to write
  * @param encoding - Encoding for the file content
  */
-export function writeFile(filePath: string, fileContent: string, encoding?: string): void {
+export function writeFile(filePath: string, fileContent: string, encoding?: BufferEncoding): void {
     try {
         const dirname = path.dirname(filePath);
         if (!fs.existsSync(dirname)) {