NpmAuth Regression Bugfix (#20453)

* Normalize Registries before reading file

* Update new service connection name and bump task

* Bump packaging-common version

* rebuild

* bump task version

* Fixing alias for WIF input

* WIF->AzureDevops

Author: AlexVTor

Tasks/NpmAuthenticateV0/Strings/resources.resjson/en-US/resources.resjson

@@ -7,10 +7,10 @@
   "loc.input.help.workingFile": "Path to the .npmrc file that specifies the registries you want to work with. Select the file, not the folder e.g. \"/packages/mypackage.npmrc\". If Azure Artifacts URL and Entra Workload ID-backed Azure DevOps user' Service Connection are set, registries in npmrc will be ignored.",
   "loc.input.label.customEndpoint": "Credentials for registries outside this organization/collection",
   "loc.input.help.customEndpoint": "Credentials to use for external registries located in the project's .npmrc. For registries in this organization/collection, leave this blank; the build’s credentials are used automatically.",
-  "loc.input.label.workloadIdentityServiceConnection": "'Entra Workload ID-backed Azure DevOps user' Service Connection",
+  "loc.input.label.workloadIdentityServiceConnection": "'Azure DevOps' Service Connection",
   "loc.input.help.workloadIdentityServiceConnection": "If this is set, feedUrl is required. Service Connections for external organizations/collection and custom endpoints are not compatible.",
   "loc.input.label.feedUrl": "Azure Artifacts URL",
-  "loc.input.help.feedUrl": "If this is set, workloadIdentityServiceConnection is required. Not compatible with customEndpoint. Feed Url should be in the npm registry format, e.g. https://pkgs.dev.azure.com/{ORG_NAME}/{PROJECT}/_packaging/{FEED_NAME}/npm/registry/",
+  "loc.input.help.feedUrl": "If this is set, azureDevOpsServiceConnection is required. Not compatible with customEndpoint. Feed Url should be in the npm registry format, e.g. https://pkgs.dev.azure.com/{ORG_NAME}/{PROJECT}/_packaging/{FEED_NAME}/npm/registry/",
   "loc.messages.FoundBuildCredentials": "Found build credentials",
   "loc.messages.NoBuildCredentials": "Could not find build credentials",
   "loc.messages.ServiceEndpointNotDefined": "Couldn't find the service connection. Make sure the selected service connection still exists.",

Tasks/NpmAuthenticateV0/_buildConfigs/Node20/package-lock.json

@@ -18,7 +18,7 @@
   "homepage": "https://github.com/Microsoft/azure-pipelines-tasks#readme",
   "dependencies": {
     "azure-pipelines-task-lib": "^4.13.0",
-    "azure-pipelines-tasks-packaging-common": "^3.242.0",
+    "azure-pipelines-tasks-packaging-common": "^3.245.0",
     "azure-pipelines-tasks-artifacts-common": "^2.243.0",
     "@types/mocha": "^5.2.7",
     "@types/node": "^20.3.1",

Tasks/NpmAuthenticateV0/_buildConfigs/Node20/package.json

@@ -18,7 +18,7 @@
   "homepage": "https://github.com/Microsoft/azure-pipelines-tasks#readme",
   "dependencies": {
     "azure-pipelines-task-lib": "^4.13.0",
-    "azure-pipelines-tasks-packaging-common": "^3.242.0",
+    "azure-pipelines-tasks-packaging-common": "^3.245.0",
     "azure-pipelines-tasks-artifacts-common": "^2.243.0",
     "@types/mocha": "^5.2.7",
     "@types/node": "^20.3.1",

Tasks/NpmAuthenticateV0/_buildConfigs/Wif/package-lock.json

@@ -70,7 +70,17 @@ async function main(): Promise<void> {
         fs.writeFileSync(indexFile, JSON.stringify(npmrcTable));
         util.saveFileWithName(npmrc, npmrcTable[npmrc], saveNpmrcPath);
     }
-
+    
+    let packagingLocation: pkgLocationUtils.PackagingLocation;
+    try {
+        packagingLocation = await pkgLocationUtils.getPackagingUris(pkgLocationUtils.ProtocolType.Npm);
+    } catch (error) {
+        tl.debug('Unable to get packaging URIs');
+        util.logError(error);
+        throw error;
+    }
+    // Getting local registries will also save normalized registries in the npmrc
+    let LocalNpmRegistries = await npmutil.getLocalNpmRegistries(workingDirectory, packagingLocation.PackagingUris);
     let npmrcFile = fs.readFileSync(npmrc, 'utf8').split(os.EOL);
 
 #if WIF
@@ -133,23 +143,12 @@ async function main(): Promise<void> {
         }));
     }
 
-    let packagingLocation: pkgLocationUtils.PackagingLocation;
-    try {
-        packagingLocation = await pkgLocationUtils.getPackagingUris(pkgLocationUtils.ProtocolType.Npm);
-    } catch (error) {
-        tl.debug('Unable to get packaging URIs');
-        util.logError(error);
-        throw error;
-    }
-    let LocalNpmRegistries = await npmutil.getLocalNpmRegistries(workingDirectory, packagingLocation.PackagingUris);
-
     let addedRegistry = [];
     for (let RegistryURLString of npmrcparser.GetRegistries(npmrc, /* saveNormalizedRegistries */ true)) {
         let registryURL = URL.parse(RegistryURLString);
         let registry: npmregistry.NpmRegistry;
         if (endpointRegistries && endpointRegistries.length > 0) {
             for (let serviceEndpoint of endpointRegistries) {
-
                 if (util.toNerfDart(serviceEndpoint.url) == util.toNerfDart(RegistryURLString)) {
                     let serviceURL = URL.parse(serviceEndpoint.url);
                     console.log(tl.loc("AddingEndpointCredentials", registryURL.host));

Tasks/NpmAuthenticateV0/_buildConfigs/Wif/package.json

@@ -19,7 +19,7 @@
   "homepage": "https://github.com/Microsoft/azure-pipelines-tasks#readme",
   "dependencies": {
     "azure-pipelines-task-lib": "^4.13.0",
-    "azure-pipelines-tasks-packaging-common": "^3.242.0",
+    "azure-pipelines-tasks-packaging-common": "^3.245.0",
     "azure-pipelines-tasks-artifacts-common": "^2.243.0",
     "@types/mocha": "^5.2.7",
     "@types/node": "16.18.11",

Tasks/NpmAuthenticateV0/npmauth.ts

@@ -10,7 +10,7 @@
     "version": {
         "Major": 0,
         "Minor": 246,
-        "Patch": 0
+        "Patch": 3
     },
     "runsOn": [
         "Agent",

Tasks/NpmAuthenticateV0/package.json

@@ -10,7 +10,7 @@
   "version": {
     "Major": 0,
     "Minor": 246,
-    "Patch": 0
+    "Patch": 3
   },
   "runsOn": [
     "Agent",

Tasks/NpmAuthenticateV0/task.json

@@ -2,7 +2,8 @@
   "inputs": [
     {
       "name": "workloadIdentityServiceConnection",
-      "label": "'Entra Workload ID-backed Azure DevOps user' Service Connection",
+      "aliases": ["azureDevOpsServiceConnection"],
+      "label": "'Azure DevOps' Service Connection",
       "helpMarkDown": "If this is set, feedUrl is required. Service Connections for external organizations/collection and custom endpoints are not compatible.",
       "type": "connectedService:workloadidentityuser",
       "required": false,
@@ -14,7 +15,7 @@
     {
       "name": "feedUrl",
       "label": "Azure Artifacts URL",
-      "helpMarkDown": "If this is set, workloadIdentityServiceConnection is required. Not compatible with customEndpoint. Feed Url should be in the npm registry format, e.g. https://pkgs.dev.azure.com/{ORG_NAME}/{PROJECT}/_packaging/{FEED_NAME}/npm/registry/",
+      "helpMarkDown": "If this is set, azureDevOpsServiceConnection is required. Not compatible with customEndpoint. Feed Url should be in the npm registry format, e.g. https://pkgs.dev.azure.com/{ORG_NAME}/{PROJECT}/_packaging/{FEED_NAME}/npm/registry/",
       "type": "string",
       "defaultValue": "",
       "required": false