Skip to content

Commit 2bb6ac7

Browse files
authored
Do not use V2 cred provider by default (#8843)
* Do not use V2 cred provider by default * Use earlier version
1 parent d29a964 commit 2bb6ac7

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

Tasks/Common/nuget-task-common/NuGetToolRunner2.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,11 +208,12 @@ export function isCredentialProviderEnabled(quirks: NuGetQuirks): boolean {
208208
return false;
209209
}
210210

211+
/* Temporarily don't use V2 credential provider based on NuGet version
211212
const isWindows = tl.osType() === "Windows_NT";
212213
if (quirks.hasQuirk(NuGetQuirkName.V2CredentialProvider) === true && isWindows) {
213214
tl.debug("Credential provider V1 is disabled in favor of V2 plugin.");
214215
return false;
215-
}
216+
}*/
216217

217218
if (isAnyCredentialProviderEnabled(quirks)) {
218219
tl.debug("V1 credential provider is enabled");
@@ -239,13 +240,14 @@ export function isCredentialProviderV2Enabled(quirks: NuGetQuirks): boolean {
239240
return false;
240241
}
241242

243+
/* Temporarily don't use V2 credential provider based on NuGet version
242244
const isWindows = tl.osType() === "Windows_NT";
243245
if (quirks.hasQuirk(NuGetQuirkName.V2CredentialProvider) === true && isWindows) {
244246
tl.debug("V2 credential provider is enabled.");
245247
return true;
246-
}
248+
}*/
247249

248-
tl.debug("V2 credential provider is disabled due to quirks. To use V2 credential provider use NuGet version 4.8 or higher.");
250+
tl.debug("V2 credential provider is disabled.");
249251
return false;
250252
}
251253

Tasks/NuGetCommandV2/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nugetcommand",
3-
"version": "2.0.45",
3+
"version": "2.0.48",
44
"description": "Restore, pack, or push NuGet packages, or run a NuGet command.",
55
"main": "nugetcommandmain.js",
66
"scripts": {

Tasks/NuGetCommandV2/task.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"version": {
1010
"Major": 2,
1111
"Minor": 0,
12-
"Patch": 47
12+
"Patch": 48
1313
},
1414
"runsOn": [
1515
"Agent",

0 commit comments

Comments
 (0)