Skip to content

Commit 2dec7f4

Browse files
committed
Handling PR comments
1 parent ce4fb99 commit 2dec7f4

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

Tasks/AzureRmWebAppDeploymentV5/operations/KuduServiceUtility.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import { KUDU_DEPLOYMENT_CONSTANTS } from 'azure-pipelines-tasks-azure-arm-rest/
99
import { Kudu } from 'azure-pipelines-tasks-azure-arm-rest/azure-arm-app-service-kudu';
1010

1111
import webClient = require('azure-pipelines-tasks-azure-arm-rest/webClient');
12+
import { PackageType } from 'azure-pipelines-tasks-webdeployment-common/packageUtility';
1213

1314
var deployUtility = require('azure-pipelines-tasks-webdeployment-common/utility.js');
1415
var zipUtility = require('azure-pipelines-tasks-webdeployment-common/ziputility.js');
@@ -204,7 +205,8 @@ export class KuduServiceUtility {
204205
}
205206

206207
if (!packageType){
207-
packageType = 'Zip'
208+
tl.debug('No package type provided. Defaulting to zip package type');
209+
packageType = PackageType[PackageType.zip];
208210
}
209211

210212
let queryParameters: Array<string> = [
@@ -246,7 +248,7 @@ export class KuduServiceUtility {
246248
await this._appServiceKuduService.zipDeploy(packagePath, queryParameters);
247249

248250
console.log(tl.loc('PackageDeploymentSuccess'));
249-
console.log("NOTE: Run From Package makes wwwroot read-only, so you will receive an error when writing files to this directory.");
251+
console.log(tl.loc('RunFromPackageAppsetting'));
250252

251253
}
252254
catch(error) {

_generated/AzureRmWebAppDeploymentV5/operations/KuduServiceUtility.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import { KUDU_DEPLOYMENT_CONSTANTS } from 'azure-pipelines-tasks-azure-arm-rest/
99
import { Kudu } from 'azure-pipelines-tasks-azure-arm-rest/azure-arm-app-service-kudu';
1010

1111
import webClient = require('azure-pipelines-tasks-azure-arm-rest/webClient');
12+
import { PackageType } from 'azure-pipelines-tasks-webdeployment-common/packageUtility';
1213

1314
var deployUtility = require('azure-pipelines-tasks-webdeployment-common/utility.js');
1415
var zipUtility = require('azure-pipelines-tasks-webdeployment-common/ziputility.js');
@@ -204,7 +205,8 @@ export class KuduServiceUtility {
204205
}
205206

206207
if (!packageType){
207-
packageType = 'Zip'
208+
tl.debug('No package type provided. Defaulting to zip package type');
209+
packageType = PackageType[PackageType.zip];
208210
}
209211

210212
let queryParameters: Array<string> = [
@@ -246,7 +248,7 @@ export class KuduServiceUtility {
246248
await this._appServiceKuduService.zipDeploy(packagePath, queryParameters);
247249

248250
console.log(tl.loc('PackageDeploymentSuccess'));
249-
console.log("NOTE: Run From Package makes wwwroot read-only, so you will receive an error when writing files to this directory.");
251+
console.log(tl.loc('RunFromPackageAppsetting'));
250252

251253
}
252254
catch(error) {

_generated/AzureRmWebAppDeploymentV5_Node20/operations/KuduServiceUtility.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import { KUDU_DEPLOYMENT_CONSTANTS } from 'azure-pipelines-tasks-azure-arm-rest/
99
import { Kudu } from 'azure-pipelines-tasks-azure-arm-rest/azure-arm-app-service-kudu';
1010

1111
import webClient = require('azure-pipelines-tasks-azure-arm-rest/webClient');
12+
import { PackageType } from 'azure-pipelines-tasks-webdeployment-common/packageUtility';
1213

1314
var deployUtility = require('azure-pipelines-tasks-webdeployment-common/utility.js');
1415
var zipUtility = require('azure-pipelines-tasks-webdeployment-common/ziputility.js');
@@ -204,7 +205,8 @@ export class KuduServiceUtility {
204205
}
205206

206207
if (!packageType){
207-
packageType = 'Zip'
208+
tl.debug('No package type provided. Defaulting to zip package type');
209+
packageType = PackageType[PackageType.zip];
208210
}
209211

210212
let queryParameters: Array<string> = [
@@ -246,7 +248,7 @@ export class KuduServiceUtility {
246248
await this._appServiceKuduService.zipDeploy(packagePath, queryParameters);
247249

248250
console.log(tl.loc('PackageDeploymentSuccess'));
249-
console.log("NOTE: Run From Package makes wwwroot read-only, so you will receive an error when writing files to this directory.");
251+
console.log(tl.loc('RunFromPackageAppsetting'));
250252

251253
}
252254
catch(error) {

0 commit comments

Comments
 (0)