Node execution upgrade to Node10 (#14014) (#14186)

* AzureKeyVaultV1

* ContainerBuildV0

* DuffleInstallerV0

* Execution: Node10 AzureKeyVault and ContainerBuild

* GitHubReleaseV0

* GitHubReleaseV1

* KubernetesManifestV0

* Updating common modules to preview

* DockerComposeV0

* DockerInstallerV0

* MochaDone to Mocha.Done

Author: thesattiraju

Tasks/AzureKeyVaultV1/npm-shrinkwrap.json

@@ -2,11 +2,16 @@
   "name": "AzureKeyVault",
   "main": "main.js",
   "dependencies": {
-    "@types/node": "^6.0.101",
+    "@types/node": "^10.17.0",
+    "@types/mocha": "^5.2.7",
+    "@types/uuid": "^8.3.0",
     "@types/q": "^1.5.0",
-    "azure-pipelines-tasks-azure-arm-rest-v2": "1.0.4",
-    "azure-pipelines-task-lib": "2.8.0",
+    "azure-pipelines-tasks-azure-arm-rest-v2": "2.0.0-preview.0",
+    "azure-pipelines-task-lib": "3.0.6-preview.0",
     "moment": "2.21.0",
     "vso-node-api": "6.0.1-preview"
+  },
+  "devDependencies": {
+    "typescript": "4.0.2"
   }
 }

Tasks/AzureKeyVaultV1/package.json

@@ -14,8 +14,8 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 1,
-        "Minor": 175,
-        "Patch": 2
+        "Minor": 181,
+        "Patch": 0
     },
     "demands": [],
     "minimumAgentVersion": "2.0.0",
@@ -74,12 +74,12 @@
     ],
     "instanceNameFormat": "Azure Key Vault: $(KeyVaultName)",
     "prejobexecution": {
-        "Node": {
+        "Node10": {
             "target": "runprejob.js"
         }
     },
     "execution": {
-        "Node": {
+        "Node10": {
             "target": "run.js"
         }
     },

Tasks/AzureKeyVaultV1/task.json

@@ -14,8 +14,8 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 1,
-    "Minor": 175,
-    "Patch": 2
+    "Minor": 181,
+    "Patch": 0
   },
   "demands": [],
   "minimumAgentVersion": "2.0.0",
@@ -74,12 +74,12 @@
   ],
   "instanceNameFormat": "ms-resource:loc.instanceNameFormat",
   "prejobexecution": {
-    "Node": {
+    "Node10": {
       "target": "runprejob.js"
     }
   },
   "execution": {
-    "Node": {
+    "Node10": {
       "target": "run.js"
     }
   },

Tasks/AzureKeyVaultV1/task.loc.json

@@ -45,7 +45,7 @@ describe("ContainerBuildV0 Suite", function () {
     });
 
     // Docker build tests begin
-    it('Runs successfully for docker build', (done:MochaDone) => {
+    it('Runs successfully for docker build', (done:Mocha.Done) => {
         let tp = path.join(__dirname, 'TestSetup.js');
         process.env[shared.TestEnvVars.repository] = "testuser/testrepo";
         let tr : ttm.MockTestRunner = new ttm.MockTestRunner(tp);
@@ -59,7 +59,7 @@ describe("ContainerBuildV0 Suite", function () {
         done();
     });
 
-    it('Runs successfully for docker build with tags', (done:MochaDone) => {
+    it('Runs successfully for docker build with tags', (done:Mocha.Done) => {
         let tp = path.join(__dirname, 'TestSetup.js');
         process.env[shared.TestEnvVars.repository] = "testuser/testrepo";
         process.env[shared.TestEnvVars.tags] = "tag1";
@@ -74,7 +74,7 @@ describe("ContainerBuildV0 Suite", function () {
         done();
     });
 
-    it('Runs successfully for docker build and push', (done:MochaDone) => {
+    it('Runs successfully for docker build and push', (done:Mocha.Done) => {
         let tp = path.join(__dirname, 'TestSetup.js');
         process.env[shared.TestEnvVars.dockerRegistryServiceConnection] = "dockerhubendpoint";
         process.env[shared.TestEnvVars.repository] = "testuser/testrepo";
@@ -90,7 +90,7 @@ describe("ContainerBuildV0 Suite", function () {
         done();
     });
 
-    it('Runs successfully for docker build and push with tags', (done:MochaDone) => {
+    it('Runs successfully for docker build and push with tags', (done:Mocha.Done) => {
         let tp = path.join(__dirname, 'TestSetup.js');
         process.env[shared.TestEnvVars.dockerRegistryServiceConnection] = "dockerhubendpoint";
         process.env[shared.TestEnvVars.repository] = "testuser/testrepo";
@@ -107,7 +107,7 @@ describe("ContainerBuildV0 Suite", function () {
         done();
     });
 
-    it('Runs successfully for docker build and push with mutiple tags', (done:MochaDone) => {
+    it('Runs successfully for docker build and push with mutiple tags', (done:Mocha.Done) => {
         let tp = path.join(__dirname, 'TestSetup.js');
         process.env[shared.TestEnvVars.dockerRegistryServiceConnection] = "dockerhubendpoint";
         process.env[shared.TestEnvVars.repository] = "testuser/testrepo";
@@ -125,7 +125,7 @@ describe("ContainerBuildV0 Suite", function () {
         done();
     });
 
-    it('Runs successfully for docker build when registry other than Docker hub is used', (done:MochaDone) => {
+    it('Runs successfully for docker build when registry other than Docker hub is used', (done:Mocha.Done) => {
         let tp = path.join(__dirname, 'TestSetup.js');
         process.env[shared.TestEnvVars.dockerRegistryServiceConnection] = "acrendpoint";
         process.env[shared.TestEnvVars.repository] = "testrepo";
@@ -141,7 +141,7 @@ describe("ContainerBuildV0 Suite", function () {
         done();
     });
 
-    it('Runs successfully for docker build when registry type is ACR and registry URL contains uppercase characters', (done:MochaDone) => {
+    it('Runs successfully for docker build when registry type is ACR and registry URL contains uppercase characters', (done:Mocha.Done) => {
         let tp = path.join(__dirname, 'TestSetup.js');
         process.env[shared.TestEnvVars.dockerRegistryServiceConnection] = "acrendpoint2";
         process.env[shared.TestEnvVars.repository] = "testrepo";
@@ -157,7 +157,7 @@ describe("ContainerBuildV0 Suite", function () {
         done();
     });
 
-    it('Docker build should honour Dockerfile and buildcontext input', (done:MochaDone) => {
+    it('Docker build should honour Dockerfile and buildcontext input', (done:Mocha.Done) => {
         let tp = path.join(__dirname, 'TestSetup.js');
         process.env[shared.TestEnvVars.repository] = "testuser/testrepo";   
         process.env[shared.TestEnvVars.dockerFile] = shared.formatPath("a/w/meta/Dockerfile");
@@ -174,7 +174,7 @@ describe("ContainerBuildV0 Suite", function () {
     });
 
     //buildctl
-    it('Buildctl should honour Dockerfile and buildcontext input', (done:MochaDone) => {
+    it('Buildctl should honour Dockerfile and buildcontext input', (done:Mocha.Done) => {
         let tp = path.join(__dirname, 'TestSetup.js');
         process.env['RUNNING_ON'] = 'KUBERNETES';
         process.env[shared.TestEnvVars.repository] = "testuser/testrepo";   
@@ -191,7 +191,7 @@ describe("ContainerBuildV0 Suite", function () {
         done();
     });
 
-    it('Buildctl should perform build as well as push if dockerregistryserviceconnect is present', (done:MochaDone) => {
+    it('Buildctl should perform build as well as push if dockerregistryserviceconnect is present', (done:Mocha.Done) => {
         let tp = path.join(__dirname, 'TestSetup.js');
         process.env['RUNNING_ON'] = 'KUBERNETES';
         process.env[shared.TestEnvVars.dockerRegistryServiceConnection] = "dockerhubendpoint";
@@ -209,7 +209,7 @@ describe("ContainerBuildV0 Suite", function () {
         done();
     });
 
-    it('Runs successfully for buildctl build and push with multiple tags', (done:MochaDone) => {
+    it('Runs successfully for buildctl build and push with multiple tags', (done:Mocha.Done) => {
         let tp = path.join(__dirname, 'TestSetup.js');
         process.env['RUNNING_ON'] = 'KUBERNETES';
         process.env[shared.TestEnvVars.dockerRegistryServiceConnection] = "dockerhubendpoint";
@@ -227,7 +227,7 @@ describe("ContainerBuildV0 Suite", function () {
         done();
     });
 
-    it('Runs successfully for buildctl build when registry other than Docker hub is used', (done:MochaDone) => {
+    it('Runs successfully for buildctl build when registry other than Docker hub is used', (done:Mocha.Done) => {
         let tp = path.join(__dirname, 'TestSetup.js');
         process.env['RUNNING_ON'] = 'KUBERNETES';
         process.env[shared.TestEnvVars.dockerRegistryServiceConnection] = "acrendpoint";