[FtpUploadV2] Fail on exception when reading FTP options (#14742)

* fail on exceptions

* bump task version

* revert FtpUploadV1 changes

* fix automatic string conversion

Author: DaniilShmelev

Tasks/FtpUploadV2/Strings/resources.resjson/en-US/resources.resjson

@@ -36,6 +36,7 @@
   "loc.messages.Disconnected": "disconnected",
   "loc.messages.DisconnectHost": "disconnecting from: %s",
   "loc.messages.FTPConnected": "connected: %s",
+  "loc.messages.InvalidFTPOptions": "There was an error when reading FTP options: %s",
   "loc.messages.FTPNoHostSpecified": "The FTP server URL must include a host name",
   "loc.messages.FTPNoProtocolSpecified": "The FTP server URL must begin with ftp:// or ftps://",
   "loc.messages.NoFilesFound": "Could not find any files to upload",

Tasks/FtpUploadV2/ftpuploadtask.ts

@@ -261,7 +261,13 @@ async function run() {
     tl.setResourcePath(path.join(__dirname, "task.json"));
 
     const tries = 3;
-    const ftpOptions: FtpOptions = getFtpOptions();
+    let ftpOptions: FtpOptions;
+    try {
+        ftpOptions = getFtpOptions();
+    } catch (err) {
+        tl.setResult(tl.TaskResult.Failed, tl.loc('InvalidFTPOptions', err));
+        return;
+    }
 
     if (!ftpOptions.serverEndpointUrl.protocol) {
         tl.setResult(tl.TaskResult.Failed, tl.loc("FTPNoProtocolSpecified"));

Tasks/FtpUploadV2/task.json

@@ -19,7 +19,7 @@
     "version": {
         "Major": 2,
         "Minor": 186,
-        "Patch": 0
+        "Patch": 1
     },
     "minimumAgentVersion": "2.182.1",
     "instanceNameFormat": "FTP Upload: $(rootFolder)",
@@ -195,6 +195,7 @@
         "Disconnected": "disconnected",
         "DisconnectHost": "disconnecting from: %s",
         "FTPConnected": "connected: %s",
+        "InvalidFTPOptions": "There was an error when reading FTP options: %s",
         "FTPNoHostSpecified": "The FTP server URL must include a host name",
         "FTPNoProtocolSpecified": "The FTP server URL must begin with ftp:// or ftps://",
         "NoFilesFound": "Could not find any files to upload",
@@ -203,4 +204,4 @@
         "UploadSucceedRes": "FTP upload successful",
         "UploadFailed": "Ftp Upload failed"
     }
-}
+}

Tasks/FtpUploadV2/task.loc.json

@@ -19,7 +19,7 @@
   "version": {
     "Major": 2,
     "Minor": 186,
-    "Patch": 0
+    "Patch": 1
   },
   "minimumAgentVersion": "2.182.1",
   "instanceNameFormat": "ms-resource:loc.instanceNameFormat",
@@ -195,6 +195,7 @@
     "Disconnected": "ms-resource:loc.messages.Disconnected",
     "DisconnectHost": "ms-resource:loc.messages.DisconnectHost",
     "FTPConnected": "ms-resource:loc.messages.FTPConnected",
+    "InvalidFTPOptions": "ms-resource:loc.messages.InvalidFTPOptions",
     "FTPNoHostSpecified": "ms-resource:loc.messages.FTPNoHostSpecified",
     "FTPNoProtocolSpecified": "ms-resource:loc.messages.FTPNoProtocolSpecified",
     "NoFilesFound": "ms-resource:loc.messages.NoFilesFound",