Skip to content

Commit 7affcc0

Browse files
authored
Find 15.2 VS (#4525) (#4541)
1 parent b2c34af commit 7affcc0

File tree

11 files changed

+14
-17
lines changed

11 files changed

+14
-17
lines changed

Tasks/Common/MSBuildHelpers/PathFunctions.ps1

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -177,16 +177,13 @@ function Get-VisualStudio_15_0 {
177177
try {
178178
if (!$script:visualStudioCache.ContainsKey('15.0')) {
179179
try {
180-
# Query for the latest 15.0.* version.
180+
# Query for the latest 15.* version.
181181
#
182-
# Note, even though VS 15 Update 1 is sometimes referred to as "15.1", the actual installation
183-
# version number is 15.0.26403.7.
184-
#
185-
# Also note, the capability is registered as VisualStudio_15.0, so the following code should
186-
# query for 15.0.* versions only.
182+
# Note, the capability is registered as VisualStudio_15.0, however the actual version
183+
# may be something like 15.2.
187184
Write-Verbose "Getting latest Visual Studio 15 setup instance."
188185
$output = New-Object System.Text.StringBuilder
189-
Invoke-VstsTool -FileName "$PSScriptRoot\vswhere.exe" -Arguments "-version [15.0,15.1) -latest -format json" -RequireExitCodeZero 2>&1 |
186+
Invoke-VstsTool -FileName "$PSScriptRoot\vswhere.exe" -Arguments "-version [15.0,16.0) -latest -format json" -RequireExitCodeZero 2>&1 |
190187
ForEach-Object {
191188
if ($_ -is [System.Management.Automation.ErrorRecord]) {
192189
Write-Verbose "STDERR: $($_.Exception.Message)"

Tasks/Common/MSBuildHelpers/Tests/Get-VisualStudio_15_0.CachesNotFoundResult.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Register-Mock Invoke-VstsTool {
1010
$script:vsCount++
1111
"["
1212
"]"
13-
} -- -FileName (Resolve-Path $PSScriptRoot\..\vswhere.exe).Path -Arguments "-version [15.0,15.1) -latest -format json" -RequireExitCodeZero
13+
} -- -FileName (Resolve-Path $PSScriptRoot\..\vswhere.exe).Path -Arguments "-version [15.0,16.0) -latest -format json" -RequireExitCodeZero
1414
Register-Mock Invoke-VstsTool {
1515
$script:buildToolsCount++
1616
"["

Tasks/Common/MSBuildHelpers/Tests/Get-VisualStudio_15_0.CachesResult.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Register-Mock Invoke-VstsTool {
1010
" `"installationPath`": `"path1`""
1111
" }"
1212
"]"
13-
} -- -FileName (Resolve-Path $PSScriptRoot\..\vswhere.exe).Path -Arguments "-version [15.0,15.1) -latest -format json" -RequireExitCodeZero
13+
} -- -FileName (Resolve-Path $PSScriptRoot\..\vswhere.exe).Path -Arguments "-version [15.0,16.0) -latest -format json" -RequireExitCodeZero
1414

1515
# Act.
1616
$null = Get-VisualStudio_15_0

Tasks/Common/MSBuildHelpers/Tests/Get-VisualStudio_15_0.FallsBackToBuildTools.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ $script:buildToolsCount = 0
99
Register-Mock Invoke-VstsTool {
1010
$script:vsCount++
1111
"[]"
12-
} -- -FileName (Resolve-Path $PSScriptRoot\..\vswhere.exe).Path -Arguments "-version [15.0,15.1) -latest -format json" -RequireExitCodeZero
12+
} -- -FileName (Resolve-Path $PSScriptRoot\..\vswhere.exe).Path -Arguments "-version [15.0,16.0) -latest -format json" -RequireExitCodeZero
1313
Register-Mock Invoke-VstsTool {
1414
$script:buildToolsCount++
1515
"["

Tasks/Common/MSBuildHelpers/Tests/Get-VisualStudio_15_0.IgnoresStderr.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Register-Mock Invoke-VstsTool {
1111
" `"installationPath`": `"some path`""
1212
" }"
1313
"]"
14-
} -- -FileName (Resolve-Path $PSScriptRoot\..\vswhere.exe).Path -Arguments "-version [15.0,15.1) -latest -format json" -RequireExitCodeZero
14+
} -- -FileName (Resolve-Path $PSScriptRoot\..\vswhere.exe).Path -Arguments "-version [15.0,16.0) -latest -format json" -RequireExitCodeZero
1515

1616
# Act.
1717
$actual = Get-VisualStudio_15_0

Tasks/MSBuild/task.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"author": "Microsoft Corporation",
1212
"version": {
1313
"Major": 1,
14-
"Minor": 118,
14+
"Minor": 119,
1515
"Patch": 0
1616
},
1717
"demands": [

Tasks/MSBuild/task.loc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"author": "Microsoft Corporation",
1212
"version": {
1313
"Major": 1,
14-
"Minor": 118,
14+
"Minor": 119,
1515
"Patch": 0
1616
},
1717
"demands": [

Tasks/VSBuild/task.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"author": "Microsoft Corporation",
1212
"version": {
1313
"Major": 1,
14-
"Minor": 118,
14+
"Minor": 119,
1515
"Patch": 0
1616
},
1717
"demands": [

Tasks/VSBuild/task.loc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"author": "Microsoft Corporation",
1212
"version": {
1313
"Major": 1,
14-
"Minor": 118,
14+
"Minor": 119,
1515
"Patch": 0
1616
},
1717
"demands": [

Tasks/XamarinAndroid/task.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"author": "Microsoft Corporation",
1212
"version": {
1313
"Major": 1,
14-
"Minor": 118,
14+
"Minor": 119,
1515
"Patch": 0
1616
},
1717
"demands": [

0 commit comments

Comments
 (0)