Skip to content

Commit 7b5c75d

Browse files
DmitriiBobreshevAlexander Smolyakovfadnavistanmay
authored
Bug on windows machines in ci/verifyMinAgentDemands execution via pipeline (#3087) (#16459)
* Bug on windows machines in ci/verifyMinAgentDemands execution via pipeline (#3087) When you access another batch file from a batch file, you need to use the CALL command to return control to the parent process. Otherwise control is passed to the batch file being executed. So CmdLineV2 Task was replaced with 2 separated commands Because npm install on windows is a batch file which call npm-cli.js and you cant use "call npm install" command on Linux-based machines * Bug on windows machines in ci/verifyMinAgentDemands execution via pipeline (#3087) -- Fixed paddings -- Fixed Error Tasks which not fill mask x.xxx.x * Bug on windows machines in ci/verifyMinAgentDemands execution via pipeline (#3087) -- Fixed paddings Co-authored-by: Alexander Smolyakov <[email protected]> Co-authored-by: fadnavistanmay <[email protected]>
1 parent 4db1906 commit 7b5c75d

File tree

6 files changed

+20
-16
lines changed

6 files changed

+20
-16
lines changed

Tasks/PublishPipelineArtifactV0/task.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
},
1515
"groups": [],
1616
"demands": [],
17-
"minimumAgentVersion": "2.199",
17+
"minimumAgentVersion": "2.199.0",
1818
"preview": false,
1919
"deprecated": true,
2020
"inputs": [

Tasks/PublishPipelineArtifactV0/task.loc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
},
1515
"groups": [],
1616
"demands": [],
17-
"minimumAgentVersion": "2.199",
17+
"minimumAgentVersion": "2.199.0",
1818
"preview": false,
1919
"deprecated": true,
2020
"inputs": [

Tasks/PublishPipelineArtifactV1/task.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"groups": [],
1616
"demands": [],
1717
"preview": false,
18-
"minimumAgentVersion": "2.199",
18+
"minimumAgentVersion": "2.199.0",
1919
"inputs": [
2020
{
2121
"name": "path",

Tasks/PublishPipelineArtifactV1/task.loc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"groups": [],
1616
"demands": [],
1717
"preview": false,
18-
"minimumAgentVersion": "2.199",
18+
"minimumAgentVersion": "2.199.0",
1919
"inputs": [
2020
{
2121
"name": "path",

ci/build-all-steps.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,14 @@ steps:
3636
PACKAGE_TOKEN: $(Package.Token)
3737

3838
# Verify min agent version demands
39-
- script: |
40-
cd ci
41-
cd verifyMinAgentDemands
42-
npm install
43-
node index.js
44-
displayName: Verify all min agent demands are valid
39+
- task: Npm@1
40+
inputs:
41+
command: install
42+
workingDir: ci/verifyMinAgentDemands
43+
displayName: npm install min agent demands
44+
45+
- script: node ./ci/verifyMinAgentDemands/index.js
46+
displayName: Verify all min agent demands are valid (via npm)
4547

4648
# Build
4749
- script: node make.js build --task "$(task_pattern)"

ci/build-single-steps.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,14 @@ steps:
2020
displayName: npm install
2121

2222
# Verify min agent version demands
23-
- script: |
24-
cd ci
25-
cd verifyMinAgentDemands
26-
npm install
27-
node index.js
28-
displayName: Verify all min agent demands are valid
23+
- task: Npm@1
24+
inputs:
25+
command: install
26+
workingDir: ci/verifyMinAgentDemands
27+
displayName: npm install min agent demands
28+
29+
- script: node ./ci/verifyMinAgentDemands/index.js
30+
displayName: Verify all min agent demands are valid (via npm)
2931

3032
# Build
3133
- script: node make.js build --task "$(task)"

0 commit comments

Comments
 (0)