Merge pull request #4820 from Microsoft/users/lukillgo/publishccnofail

#1039811: PublishCodeCoverageResults: don't fail unless the checkbox …

Author: lkillgore

Tasks/PublishCodeCoverageResults/publishcodecoverageresults.ts

@@ -22,34 +22,36 @@ async function run() {
         var resolvedSummaryFile: string = resolvePathToSingleItem(workingDirectory, summaryFileLocation);
         if (failIfCoverageIsEmpty && await ccUtil.isCodeCoverageFileEmpty(resolvedSummaryFile, codeCoverageTool)) {
             throw tl.loc('NoCodeCoverage');
-        }
-
-        // Resolve the report directory.
-        // It may contain wildcards allowing the path to change between builds, such as for:
-        // $(System.DefaultWorkingDirectory)\artifacts***$(Configuration)\testresults\coverage
-        var resolvedReportDirectory: string = resolvePathToSingleItem(workingDirectory, reportDirectory);
+        } else if (!tl.exist(resolvedSummaryFile)) {
+            tl.warning(tl.loc('NoCodeCoverage'));
+        } else {
+            // Resolve the report directory.
+            // It may contain wildcards allowing the path to change between builds, such as for:
+            // $(System.DefaultWorkingDirectory)\artifacts***$(Configuration)\testresults\coverage
+            var resolvedReportDirectory: string = resolvePathToSingleItem(workingDirectory, reportDirectory);
 
-        // Get any 'Additional Files' to publish as build artifacts
-        if (additionalFiles) {
-            // Does the 'Additional Files' value contain wildcards?
-            if (containsWildcard(additionalFiles)) {
-                // Resolve matches of the 'Additional Files' pattern
-                var additionalFileMatches: string[] = tl.findMatch(
-                    workingDirectory,
-                    additionalFiles,
-                    { followSymbolicLinks: false, followSpecifiedSymbolicLink: false },
-                    { matchBase: true });
-                tl.debug(tl.loc('FoundNMatchesForPattern', additionalFileMatches.length, additionalFiles));
+            // Get any 'Additional Files' to publish as build artifacts
+            if (additionalFiles) {
+                // Does the 'Additional Files' value contain wildcards?
+                if (containsWildcard(additionalFiles)) {
+                    // Resolve matches of the 'Additional Files' pattern
+                    var additionalFileMatches: string[] = tl.findMatch(
+                        workingDirectory,
+                        additionalFiles,
+                        { followSymbolicLinks: false, followSpecifiedSymbolicLink: false },
+                        { matchBase: true });
+                    tl.debug(tl.loc('FoundNMatchesForPattern', additionalFileMatches.length, additionalFiles));
+                }
+                else {
+                    // Use the specific additional file (no wildcards)
+                    var additionalFileMatches: string[] = [additionalFiles];
+                }
             }
-            else {
-                // Use the specific additional file (no wildcards)
-                var additionalFileMatches: string[] = [additionalFiles];
-            }
-        }
 
-        // Publish code coverage data
-        var ccPublisher = new tl.CodeCoveragePublisher();
-        ccPublisher.publish(codeCoverageTool, resolvedSummaryFile, resolvedReportDirectory, additionalFileMatches);
+            // Publish code coverage data
+            var ccPublisher = new tl.CodeCoveragePublisher();
+            ccPublisher.publish(codeCoverageTool, resolvedSummaryFile, resolvedReportDirectory, additionalFileMatches);
+        }
     }
     catch (err) {
         tl.setResult(tl.TaskResult.Failed, err);

Tasks/PublishCodeCoverageResults/task.json

@@ -15,7 +15,7 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 1,
-        "Minor": 117,
+        "Minor": 121,
         "Patch": 0
     },
     "demands": [],

Tasks/PublishCodeCoverageResults/task.loc.json

@@ -15,7 +15,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 1,
-    "Minor": 117,
+    "Minor": 121,
     "Patch": 0
   },
   "demands": [],

Tests-Legacy/L0/PublishCodeCoverageResults/publishCCResponses.json

@@ -8,6 +8,9 @@
             "/someDir/someFile1"
         ]
     },
+    "exist": {
+        "/user/admin/summary.xml": true
+    },
     "findMatch": {
         "/some/*pattern": [
             "some/path/one",