Skip to content

Commit 8934f16

Browse files
PhilipsonJosephPhilipson Joseph V
andauthored
AzureFunctionAppContainer@1 sets WEBSITES_ENABLE_APP_SERVICE_STORAGE to false even if user provides 'appSettings: -WEBSITES_ENABLE_APP_SERVICE_STORAGE true' #14857 (#15252)
* 14857 sets WEBSITES_ENABLE_APP_SERVICE_STORAGE to false even if user provides on AppSettings is fixes * Task minor version Change * Review changes Completed Co-authored-by: Philipson Joseph V <[email protected]>
1 parent 82f880e commit 8934f16

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

Tasks/AzureFunctionAppContainerV1/azurefunctiononcontainerprovider.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ import { AzureResourceFilterUtility } from 'azure-pipelines-tasks-azurermdeployc
99
import tl = require('azure-pipelines-task-lib/task');
1010
import { addReleaseAnnotation } from 'azure-pipelines-tasks-azurermdeploycommon/operations/ReleaseAnnotationUtility';
1111
import { ContainerBasedDeploymentUtility } from 'azure-pipelines-tasks-azurermdeploycommon/operations/ContainerBasedDeploymentUtility';
12-
const linuxFunctionStorageSetting: string = '-WEBSITES_ENABLE_APP_SERVICE_STORAGE false';
12+
const linuxFunctionStorageSettingName: string = '-WEBSITES_ENABLE_APP_SERVICE_STORAGE';
13+
const linuxFunctionStorageSettingValue: string = 'false';
1314
import * as ParameterParser from 'azure-pipelines-tasks-azurermdeploycommon/operations/ParameterParserUtility';
1415

1516
export class AzureFunctionOnContainerDeploymentProvider{
@@ -48,7 +49,10 @@ export class AzureFunctionOnContainerDeploymentProvider{
4849

4950
let containerDeploymentUtility: ContainerBasedDeploymentUtility = new ContainerBasedDeploymentUtility(this.appService);
5051
await containerDeploymentUtility.deployWebAppImage(this.taskParams);
51-
52+
let linuxFunctionStorageSetting: string = '';
53+
if (!this.taskParams.AppSettings || this.taskParams.AppSettings.indexOf(linuxFunctionStorageSettingName) < 0) {
54+
linuxFunctionStorageSetting = `${linuxFunctionStorageSettingName} ${linuxFunctionStorageSettingValue}`;
55+
}
5256
this.taskParams.AppSettings = this.taskParams.AppSettings ? this.taskParams.AppSettings.trim() + " " + linuxFunctionStorageSetting : linuxFunctionStorageSetting;
5357
let customApplicationSettings = ParameterParser.parse(this.taskParams.AppSettings);
5458
await this.appServiceUtility.updateAndMonitorAppSettings(customApplicationSettings);

Tasks/AzureFunctionAppContainerV1/task.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"author": "Microsoft Corporation",
1818
"version": {
1919
"Major": 1,
20-
"Minor": 187,
20+
"Minor": 193,
2121
"Patch": 0
2222
},
2323
"minimumAgentVersion": "2.104.1",

Tasks/AzureFunctionAppContainerV1/task.loc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"author": "Microsoft Corporation",
1818
"version": {
1919
"Major": 1,
20-
"Minor": 187,
20+
"Minor": 193,
2121
"Patch": 0
2222
},
2323
"minimumAgentVersion": "2.104.1",

0 commit comments

Comments
 (0)