Skip to content

Commit 99b6c67

Browse files
Fix check-downgrading promise error handling (#19069)
* Add catch to main function * Update condition count base on tasks for downgrading check
1 parent 5bdfc46 commit 99b6c67

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

ci/build-all-steps.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ steps:
7474
condition: |
7575
and(
7676
succeeded(),
77-
ne(variables['numTasks'], 0),
77+
ne(variables['numTasksForDowngradingCheck'], 0),
7878
ne(variables['COURTESY_PUSH'], 'true'),
7979
eq(variables['build.reason'], 'PullRequest'),
8080
eq(variables['System.PullRequest.TargetBranch'], 'master')

ci/check-downgrading.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,4 +260,8 @@ async function main({ task, sprint, week }) {
260260
}
261261
}
262262

263-
main(argv);
263+
main(argv)
264+
.catch(error => {
265+
console.error(error);
266+
process.exit(1);
267+
});

ci/filter-tasks.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,7 @@ var setTaskVariables = function(tasks, tasksForDowngradingCheck) {
216216
console.log('##vso[task.setVariable variable=task_pattern;isOutput=true;]@(' + tasks.join('|') + ')');
217217
console.log('##vso[task.setVariable variable=task_pattern_fordowngradingcheck]@(' + tasksForDowngradingCheck.join('|') + ')');
218218
console.log('##vso[task.setVariable variable=numTasks]' + tasks.length);
219+
console.log('##vso[task.setVariable variable=numTasksForDowngradingCheck]' + tasksForDowngradingCheck.length);
219220
}
220221

221222
var buildReason = process.env['BUILD_REASON'].toLowerCase();

0 commit comments

Comments
 (0)