[HelmDeployV0] Added newline to comma conversion logic (#13579)

* Added newline to comma conversion logic

* Adding filter for removing null values

* Resolving PR comments

Author: shigupt202

Tasks/HelmDeployV0/Strings/resources.resjson/en-US/resources.resjson

@@ -41,7 +41,7 @@
   "loc.input.label.releaseName": "Release Name",
   "loc.input.help.releaseName": "Release name. If unspecified, it will autogenerate one for you.",
   "loc.input.label.overrideValues": "Set Values",
-  "loc.input.help.overrideValues": "Set values on the command line (can specify multiple or separate values with commas: key1=val1,key2=val2). The task will construct the helm command by using these set values. For example, helm install --set key1=val1 ./redis.",
+  "loc.input.help.overrideValues": "Set values on the command line (can specify multiple or separate values with commas or newlines: key1=val1,key2=val2 or <br>key1=val1<br>key2=val2<br>). The task will construct the helm command by using these set values. For example, helm install --set key1=val1 ./redis.",
   "loc.input.label.valueFile": "Value File",
   "loc.input.help.valueFile": "Specify values in a YAML file or a URL. For example, specifying myvalues.yaml will result in 'helm install --values=myvals.yaml'.",
   "loc.input.label.destination": "Destination",

Tasks/HelmDeployV0/src/helmcommands/helminstall.ts

@@ -42,7 +42,7 @@ export function addArguments(helmCli: helmcli): void {
     }
 
     if (overrideValues) {
-        helmCli.addArgument("--set ".concat(overrideValues));
+        helmCli.addArgument("--set ".concat(helmutil.replaceNewlinesWithCommas(overrideValues)));
     }
 
     if (updatedependency) {

Tasks/HelmDeployV0/src/helmcommands/helmupgrade.ts

@@ -54,7 +54,7 @@ export function addArguments(helmCli: helmcli): void {
     }
 
     if (overrideValues) {
-        helmCli.addArgument("--set ".concat(overrideValues));
+        helmCli.addArgument("--set ".concat(helmutil.replaceNewlinesWithCommas(overrideValues)));
     }
 
     if (waitForExecution) {

Tasks/HelmDeployV0/src/utils.ts

@@ -98,4 +98,9 @@ export function addVersion(helmCli: helmcli, version: string) {
         helmCli.addArgument("--version ".concat(version));
     else
         console.log("The given version is not valid. Running the helm install command with latest version");
+}
+
+export function replaceNewlinesWithCommas(overrideValues: string): string {
+    const keyValuePairs = overrideValues.split("\n").filter(pair => pair);
+    return keyValuePairs.join(",");
 }

Tasks/HelmDeployV0/task.json

@@ -13,8 +13,8 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 0,
-        "Minor": 175,
-        "Patch": 4
+        "Minor": 176,
+        "Patch": 0
     },
     "demands": [],
     "groups": [
@@ -253,7 +253,7 @@
             "name": "overrideValues",
             "label": "Set Values",
             "type": "string",
-            "helpMarkDown": "Set values on the command line (can specify multiple or separate values with commas: key1=val1,key2=val2). The task will construct the helm command by using these set values. For example, helm install --set key1=val1 ./redis.",
+            "helpMarkDown": "Set values on the command line (can specify multiple or separate values with commas or newlines: key1=val1,key2=val2 or <br>key1=val1<br>key2=val2<br>). The task will construct the helm command by using these set values. For example, helm install --set key1=val1 ./redis.",
             "defaultValue": "",
             "visibleRule": "command == install || command == upgrade",
             "groupName": "commands"

Tasks/HelmDeployV0/task.loc.json

@@ -13,8 +13,8 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 0,
-    "Minor": 175,
-    "Patch": 4
+    "Minor": 176,
+    "Patch": 0
   },
   "demands": [],
   "groups": [