Handle version input from artifact (#9969) (#9971)

* Handle version input from artifact

Author: gykuma

Tasks/DownloadGitHubReleaseV0/Strings/resources.resjson/en-US/resources.resjson

@@ -7,7 +7,7 @@
   "loc.input.help.connection": "GitHub service connection",
   "loc.input.label.userRepository": "Repository",
   "loc.input.help.userRepository": "GitHub repository full name",
-  "loc.input.label.defaultVersionType": "Default release version type",
+  "loc.input.label.defaultVersionType": "Default version",
   "loc.input.help.defaultVersionType": "Download assets from latest release or specific release version/tag",
   "loc.input.label.version": "Release",
   "loc.input.help.version": "Release version/tag to download",
@@ -17,6 +17,5 @@
   "loc.input.help.downloadPath": "Path on the agent machine where the release assets will be downloaded",
   "loc.messages.DownloadArtifacts": "Downloading assets of release '%s' from: %s",
   "loc.messages.ArtifactsSuccessfullyDownloaded": "Successfully downloaded release assets to '%s'",
-  "loc.messages.InvalidRelease": "The release Id/Tag input '%s' is not valid",
-  "loc.messages.InvalidDefaultVersionType": "The DefaultVersionType input '%s' is not valid"
+  "loc.messages.InvalidRelease": "The release version/tag input '%s' is not valid"
 }

Tasks/DownloadGitHubReleaseV0/main.ts

@@ -133,6 +133,10 @@ async function main(): Promise<void> {
         let version = tl.getInput("version", false);
         let release: Release = null;
 
+        if (!defaultVersionType) {
+            defaultVersionType = "latest";
+        }
+
         var token = tl.getEndpointAuthorizationParameter(connection, 'AccessToken', false);
         var retryLimit = parseInt(tl.getVariable("VSTS_HTTP_RETRY")) ? parseInt(tl.getVariable("VSTS_HTTP_RETRY")) : defaultRetryLimit;
 
@@ -159,30 +163,22 @@ async function main(): Promise<void> {
             }
         }
 
-        if (!!defaultVersionType) {
-            switch (defaultVersionType.toLowerCase()) {
-                case 'latest': release = await executeWithRetries("getLatestRelease", () => getLatestRelease(repositoryName, customCredentialHandler), retryLimit).catch((reason) => { reject(reason); });
-                    break;
-                case 'specifictag': release = await executeWithRetries("getTaggedRelease", () => getTaggedRelease(repositoryName, version, customCredentialHandler), retryLimit).catch((reason) => { reject(reason); });
-                    break;
-                case 'specificversion': release = await executeWithRetries("getSpecificRelease", () => getSpecificRelease(repositoryName, version, customCredentialHandler), retryLimit).catch((reason) => { reject(reason); });
-                    break;
-                default: release = null;
-            }
-        } else {
+        if (defaultVersionType.toLowerCase() == 'specificversion') {
+            release = await executeWithRetries("getSpecificRelease", () => getSpecificRelease(repositoryName, version, customCredentialHandler), retryLimit).catch((reason) => { reject(reason); });
+        }
+        else if (defaultVersionType.toLowerCase() == 'specifictag') {
+            release = await executeWithRetries("getTaggedRelease", () => getTaggedRelease(repositoryName, version, customCredentialHandler), retryLimit).catch((reason) => { reject(reason); });
+        }
+        else {
             if (!!version) {
                 release = await executeWithRetries("getTaggedRelease", () => getTaggedRelease(repositoryName, version, customCredentialHandler), retryLimit).catch((reason) => { reject(reason); });
-            } else {
+            }
+            else {
                 release = await executeWithRetries("getLatestRelease", () => getLatestRelease(repositoryName, customCredentialHandler), retryLimit).catch((reason) => { reject(reason); });
             }
         }
 
-        if (!release) {
-            reject(tl.loc("InvalidDefaultVersionType", defaultVersionType));
-            return;
-        }
-
-        if (!release.Id) {
+        if (!release || !release.Id) {
             reject(tl.loc("InvalidRelease", version));
             return;
         }

Tasks/DownloadGitHubReleaseV0/task.json

@@ -11,7 +11,7 @@
   "version": {
     "Major": 0,
     "Minor": 149,
-    "Patch": 0
+    "Patch": 1
   },
   "minimumAgentVersion": "1.99.0",
   "instanceNameFormat": "Download GitHub Release",
@@ -40,7 +40,7 @@
     {
       "name": "defaultVersionType",
       "type": "pickList",
-      "label": "Default release version type",
+      "label": "Default version",
       "defaultValue": "latest",
       "required": true,
       "options": {
@@ -116,7 +116,6 @@
   "messages": {
     "DownloadArtifacts": "Downloading assets of release '%s' from: %s",
     "ArtifactsSuccessfullyDownloaded": "Successfully downloaded release assets to '%s'",
-    "InvalidRelease": "The release Id/Tag input '%s' is not valid",
-    "InvalidDefaultVersionType": "The DefaultVersionType input '%s' is not valid"
+    "InvalidRelease": "The release version/tag input '%s' is not valid"
   }
 }

Tasks/DownloadGitHubReleaseV0/task.loc.json

@@ -11,7 +11,7 @@
   "version": {
     "Major": 0,
     "Minor": 149,
-    "Patch": 0
+    "Patch": 1
   },
   "minimumAgentVersion": "1.99.0",
   "instanceNameFormat": "ms-resource:loc.instanceNameFormat",
@@ -116,7 +116,6 @@
   "messages": {
     "DownloadArtifacts": "ms-resource:loc.messages.DownloadArtifacts",
     "ArtifactsSuccessfullyDownloaded": "ms-resource:loc.messages.ArtifactsSuccessfullyDownloaded",
-    "InvalidRelease": "ms-resource:loc.messages.InvalidRelease",
-    "InvalidDefaultVersionType": "ms-resource:loc.messages.InvalidDefaultVersionType"
+    "InvalidRelease": "ms-resource:loc.messages.InvalidRelease"
   }
 }