Skip to content

Commit b29b25f

Browse files
authored
Users/embetten/downloadpkg bugfix (#17146)
* Use Get Package API * update package version * update download package response * revert test changes * PR fix
1 parent efccf8b commit b29b25f

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

Tasks/DownloadPackageV1/package.ts

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export abstract class Package {
4949
this.executeWithRetries = builder.ExecuteWithRetries;
5050
}
5151

52-
protected abstract async getDownloadUrls(
52+
protected abstract getDownloadUrls(
5353
feedId: string,
5454
project: string,
5555
packageId: string,
@@ -144,20 +144,23 @@ export abstract class Package {
144144
): Promise<string> {
145145
const routeValues = {
146146
feedId: feedId,
147-
project: project
147+
project: project,
148+
packageId: packageId
148149
};
149150
const queryParams = {
150-
packageIdQuery: packageId,
151151
protocolType: this.packageProtocolAreaName
152152
};
153153

154154
return new Promise<string>(async (resolve, reject) => {
155155
this.getPackageMetadata(this.feedConnection, routeValues, queryParams, this.getPackagesAreaId)
156156
.then(packages => {
157-
tl.debug("Found " + packages["count"] + " packages matching search pattern " + packageId);
158-
for (let i = 0; i < packages["count"]; i++) {
159-
if (packages["value"][i]["id"] == packageId && packages["value"][i]["versions"][0]["isListed"]) {
160-
return resolve(packages["value"][i]["versions"][0]["normalizedVersion"]);
157+
if(packages["id"] == packageId){
158+
let versions = packages["versions"];
159+
tl.debug("Found " + versions?.length + " packages matching search pattern " + packageId);
160+
for (let i = 0; i < versions?.length; i++) {
161+
if (versions[i]["isLatest"] && versions[i]["isListed"]) {
162+
return resolve(versions[i]["normalizedVersion"]);
163+
}
161164
}
162165
}
163166
return reject("Latest version not found.");

Tasks/DownloadPackageV1/task.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"author": "ms-vscs-rm",
1010
"version": {
1111
"Major": 1,
12-
"Minor": 210,
12+
"Minor": 211,
1313
"Patch": 0
1414
},
1515
"demands": [],

Tasks/DownloadPackageV1/task.loc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"author": "ms-vscs-rm",
1010
"version": {
1111
"Major": 1,
12-
"Minor": 210,
12+
"Minor": 211,
1313
"Patch": 0
1414
},
1515
"demands": [],

0 commit comments

Comments
 (0)