Skip to content

Commit d6a57a0

Browse files
Merge pull request #10256 from jahsu-MSFT/users/jahsu/revert-changing-downloadPath-to-targetPath
Revert changes in https://github.com/Microsoft/azure-pipelines-tasks/pull/10215/files
2 parents 988c003 + ac38740 commit d6a57a0

File tree

3 files changed

+22
-22
lines changed

3 files changed

+22
-22
lines changed

Tasks/DownloadPipelineArtifactV1/Strings/resources.resjson/en-US/resources.resjson

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@
1414
"loc.input.label.buildVersionToDownload": "Build version to download",
1515
"loc.input.label.branchName": "Branch name",
1616
"loc.input.help.branchName": "Specify to filter on branch/ref name, for example: ```refs/heads/develop```.",
17-
"loc.input.label.pipelineId": "Pipeline",
18-
"loc.input.help.pipelineId": "The pipeline from which to download the artifacts.",
17+
"loc.input.label.buildId": "Build",
18+
"loc.input.help.buildId": "The build from which to download the artifacts.",
1919
"loc.input.label.tags": "Build Tags",
2020
"loc.input.help.tags": "A comma-delimited list of tags. Only builds with these tags will be returned.",
2121
"loc.input.label.artifactName": "Artifact name",
2222
"loc.input.help.artifactName": "The name of the artifact to download.",
2323
"loc.input.label.itemPattern": "Matching pattern",
2424
"loc.input.help.itemPattern": "Specify files to be downloaded as multi line minimatch pattern. [More Information](https://aka.ms/minimatchexamples).</p>",
25-
"loc.input.label.targetPath": "Destination directory",
26-
"loc.input.help.targetPath": "Path on the agent machine where the artifacts will be downloaded."
25+
"loc.input.label.downloadPath": "Destination directory",
26+
"loc.input.help.downloadPath": "Path on the agent machine where the artifacts will be downloaded."
2727
}

Tasks/DownloadPipelineArtifactV1/task.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"version": {
1010
"Major": 1,
1111
"Minor": 1,
12-
"Patch": 1
12+
"Patch": 2
1313
},
1414
"groups": [],
1515
"demands": [],
@@ -90,9 +90,9 @@
9090
"helpMarkDown": "Specify to filter on branch/ref name, for example: ```refs/heads/develop```."
9191
},
9292
{
93-
"name": "pipelineId",
93+
"name": "buildId",
9494
"aliases": [
95-
"buildId"
95+
"pipelineId"
9696
],
9797
"type": "pickList",
9898
"label": "Build",
@@ -139,9 +139,9 @@
139139
"helpMarkDown": "Specify files to be downloaded as multi line minimatch pattern. [More Information](https://aka.ms/minimatchexamples).</p>"
140140
},
141141
{
142-
"name": "targetPath",
142+
"name": "downloadPath",
143143
"aliases": [
144-
"downloadPath"
144+
"targetPath"
145145
],
146146
"type": "string",
147147
"label": "Destination directory",
@@ -177,7 +177,7 @@
177177
},
178178
{
179179
"endpointId": "tfs:teamfoundation",
180-
"target": "pipelineId",
180+
"target": "buildId",
181181
"endpointUrl": "{{endpoint.url}}/{{project}}/_apis/build/builds?definitions={{definition}}&resultFilter=succeeded,partiallySucceeded&$top=200",
182182
"resultSelector": "jsonpath:$.value[*]",
183183
"parameters": {
@@ -201,7 +201,7 @@
201201
"instanceNameFormat": "Download Pipeline Artifact",
202202
"execution": {
203203
"AgentPlugin": {
204-
"target": "Agent.Plugins.PipelineArtifact.DownloadPipelineArtifactTaskV1_1_1, Agent.Plugins"
204+
"target": "Agent.Plugins.PipelineArtifact.DownloadPipelineArtifactTaskV1_1_2, Agent.Plugins"
205205
}
206206
},
207207
"messages": {}

Tasks/DownloadPipelineArtifactV1/task.loc.json

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"version": {
1010
"Major": 1,
1111
"Minor": 1,
12-
"Patch": 1
12+
"Patch": 2
1313
},
1414
"groups": [],
1515
"demands": [],
@@ -90,20 +90,20 @@
9090
"helpMarkDown": "ms-resource:loc.input.help.branchName"
9191
},
9292
{
93-
"name": "pipelineId",
93+
"name": "buildId",
9494
"aliases": [
95-
"buildId"
95+
"pipelineId"
9696
],
9797
"type": "pickList",
98-
"label": "ms-resource:loc.input.label.pipelineId",
98+
"label": "ms-resource:loc.input.label.buildId",
9999
"defaultValue": "",
100100
"required": true,
101101
"visibleRule": "buildType == specific && buildVersionToDownload == specific",
102102
"properties": {
103103
"EditableOptions": "True",
104104
"DisableManageLink": "True"
105105
},
106-
"helpMarkDown": "ms-resource:loc.input.help.pipelineId"
106+
"helpMarkDown": "ms-resource:loc.input.help.buildId"
107107
},
108108
{
109109
"name": "tags",
@@ -139,15 +139,15 @@
139139
"helpMarkDown": "ms-resource:loc.input.help.itemPattern"
140140
},
141141
{
142-
"name": "targetPath",
142+
"name": "downloadPath",
143143
"aliases": [
144-
"downloadPath"
144+
"targetPath"
145145
],
146146
"type": "string",
147-
"label": "ms-resource:loc.input.label.targetPath",
147+
"label": "ms-resource:loc.input.label.downloadPath",
148148
"defaultValue": "$(System.ArtifactsDirectory)",
149149
"required": true,
150-
"helpMarkDown": "ms-resource:loc.input.help.targetPath"
150+
"helpMarkDown": "ms-resource:loc.input.help.downloadPath"
151151
}
152152
],
153153
"dataSourceBindings": [
@@ -177,7 +177,7 @@
177177
},
178178
{
179179
"endpointId": "tfs:teamfoundation",
180-
"target": "pipelineId",
180+
"target": "buildId",
181181
"endpointUrl": "{{endpoint.url}}/{{project}}/_apis/build/builds?definitions={{definition}}&resultFilter=succeeded,partiallySucceeded&$top=200",
182182
"resultSelector": "jsonpath:$.value[*]",
183183
"parameters": {
@@ -201,7 +201,7 @@
201201
"instanceNameFormat": "ms-resource:loc.instanceNameFormat",
202202
"execution": {
203203
"AgentPlugin": {
204-
"target": "Agent.Plugins.PipelineArtifact.DownloadPipelineArtifactTaskV1_1_1, Agent.Plugins"
204+
"target": "Agent.Plugins.PipelineArtifact.DownloadPipelineArtifactTaskV1_1_2, Agent.Plugins"
205205
}
206206
},
207207
"messages": {}

0 commit comments

Comments
 (0)