PR feedback

jmyersmsft · jmyersmsft · commit da8bef9b4f83 · 2016-08-02T17:03:52.000-07:00
diff --git a/Tasks/Common/nuget-task-common/NuGetToolRunner.ts b/Tasks/Common/nuget-task-common/NuGetToolRunner.ts
@@ -156,11 +156,11 @@ export function locateNuGetExe(userNuGetExePath: string): string {
     return toolPath;
 }
 
-function isHosted() {
+function isHosted(): boolean {
     // not an ideal way to detect hosted, but there isn't a variable for it, and we can't make network calls from here
     // due to proxy issues.
     const collectionUri = tl.getVariable("System.TeamFoundationCollectionUri");
-    const isHosted = /\.visualstudio\.com$/i.test(collectionUri);
+    return /\.visualstudio\.com$/i.test(collectionUri);
 }
 
 // Currently, there is a race condition of some sort that causes nuget to not send credentials sometimes

Original file line number	Diff line number	Diff line change
`@@ -156,11 +156,11 @@ export function locateNuGetExe(userNuGetExePath: string): string {`
`156`	`156`	`return toolPath;`
`157`	`157`	`}`
`158`	`158`
`159`		`-function isHosted() {`
	`159`	`+function isHosted(): boolean {`
`160`	`160`	`// not an ideal way to detect hosted, but there isn't a variable for it, and we can't make network calls from here`
`161`	`161`	`// due to proxy issues.`
`162`	`162`	`const collectionUri = tl.getVariable("System.TeamFoundationCollectionUri");`
`163`		`- const isHosted = /\.visualstudio\.com$/i.test(collectionUri);`
	`163`	`+ return /\.visualstudio\.com$/i.test(collectionUri);`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`// Currently, there is a race condition of some sort that causes nuget to not send credentials sometimes`