[Azure Keyvault] Adding default AzureKeyVaultDnsSuffix (#9480) (#9484)

* [Azure Keyvault] Adding default AzureKeyVaultDnsSuffix

* Adding default for AzureKeyVaultServiceEndpointResourceId

Author: thesattiraju

Tasks/AzureKeyVaultV1/models/KeyVaultTaskParameters.ts

@@ -25,19 +25,25 @@ export class KeyVaultTaskParameters {
         this.keyVaultName = tl.getInput("KeyVaultName", true);
         this.secretsFilter = tl.getDelimitedInput("SecretsFilter", ",", true);
         var azureKeyVaultDnsSuffix = tl.getEndpointDataParameter(connectedService, "AzureKeyVaultDnsSuffix", true);
+        if (!azureKeyVaultDnsSuffix) {
+            azureKeyVaultDnsSuffix = "vault.azure.net"
+        }
         this.servicePrincipalId = tl.getEndpointAuthorizationParameter(connectedService, 'serviceprincipalid', true);
         this.keyVaultUrl = util.format("https://%s.%s", this.keyVaultName, azureKeyVaultDnsSuffix);
         this.scheme = tl.getEndpointAuthorizationScheme(connectedService, false);
-        this.vaultCredentials = await this.getVaultCredentials(connectedService, azureKeyVaultDnsSuffix);
+        this.vaultCredentials = await this.getVaultCredentials(connectedService);
         return this;
     }
 
-    private async getVaultCredentials(connectedService: string, azureKeyVaultDnsSuffix: string): Promise<msRestAzure.ApplicationTokenCredentials> {
+    private async getVaultCredentials(connectedService: string): Promise<msRestAzure.ApplicationTokenCredentials> {
         const endpoint: AzureEndpoint = await new AzureRMEndpoint(connectedService).getEndpoint();
 
         if(!!endpoint.environment && endpoint.environment.toLowerCase() == this._environments.AzureStack) {
             endpoint.applicationTokenCredentials.activeDirectoryResourceId = endpoint.activeDirectoryResourceID.replace("management", "vault");
         } else {
+            if (!endpoint.azureKeyVaultServiceEndpointResourceId) {
+                endpoint.azureKeyVaultServiceEndpointResourceId = "https://vault.azure.net";
+            }
             endpoint.applicationTokenCredentials.baseUrl = endpoint.azureKeyVaultServiceEndpointResourceId;
             endpoint.applicationTokenCredentials.activeDirectoryResourceId = endpoint.azureKeyVaultServiceEndpointResourceId;
         }

Tasks/AzureKeyVaultV1/task.json

@@ -14,7 +14,7 @@
     "version": {
         "Major": 1,
         "Minor": 0,
-        "Patch": 27
+        "Patch": 28
     },
     "demands": [],
     "minimumAgentVersion": "2.0.0",

Tasks/AzureKeyVaultV1/task.loc.json

@@ -14,7 +14,7 @@
   "version": {
     "Major": 1,
     "Minor": 0,
-    "Patch": 27
+    "Patch": 28
   },
   "demands": [],
   "minimumAgentVersion": "2.0.0",