Skip to content

Commit e0693ba

Browse files
embettenAlexVTor
andauthored
NuGetAuthenticateV1: Add WIF Service Connection Support (#20299)
* Adding task changes * Adding TaskJsonOverride to support new input * Adding generated wif * Updating logic in main, adding locstrings * task bump && bump common package * removing groupname from task json * adding url check and spelling * Removing duplicate error checking, try parse url * Improved feed url check * Adding telemetry for federatedFeedAuthCount * bumping azure-pipelines-task-lib * UX improvements * merge conflict fix * Bump Task Version * run --write-updates * Fix Url Validation and PR Comments * --write-updates * bump common task * --write-updates * --write-updates * write updates * add input validation * write updates * build validation passes locally * revert en-us changes * Add en-us strings * fix strings part 2 * write updates --------- Co-authored-by: Alex Torres <[email protected]> Co-authored-by: Alex Torres <[email protected]>
1 parent 6623ded commit e0693ba

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+2698
-658
lines changed

Tasks/NuGetAuthenticateV1/Strings/resources.resjson/en-US/resources.resjson

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,14 @@
66
"loc.input.label.nuGetServiceConnections": "Service connection credentials for feeds outside this organization",
77
"loc.input.help.nuGetServiceConnections": "Comma-separated list of NuGet service connection names for feeds outside this organization/collection. For feeds in this organization/collection, leave this blank; the build’s credentials are used automatically.",
88
"loc.input.label.forceReinstallCredentialProvider": "Reinstall the credential provider even if already installed",
9-
"loc.input.help.forceReinstallCredentialProvider": "If the credential provider is already installed in the user profile, determines if it is overwritten with the task-provided credential provider. This may upgrade (or potentially downgrade) the credential provider."
9+
"loc.input.help.forceReinstallCredentialProvider": "If the credential provider is already installed in the user profile, determines if it is overwritten with the task-provided credential provider. This may upgrade (or potentially downgrade) the credential provider.",
10+
"loc.input.help.feedUrl": "If this is set, workloadIdentityServiceConnection is required. All other inputs are ignored. Not compatible with nuGetServiceConnections. Feed Url should be in the NuGet service index format, e.g. https://pkgs.dev.azure.com/{ORG_NAME}/{PROJECT}/_packaging/{FEED_NAME}/nuget/v3/index.json/",
11+
"loc.input.label.feedUrl": "Azure Artifacts URL",
12+
"loc.input.help.workloadIdentityServiceConnection": "If this is set, feedUrl is required. All other inputs are ignored.",
13+
"loc.input.label.workloadIdentityServiceConnection": "'Entra Workload ID-backed Azure DevOps user' Service Connection",
14+
"loc.messages.Error_ServiceConnectionExists": "An existing service connection already exists for the endpoint",
15+
"loc.messages.Error_MissingFeedUrlOrServiceConnection": "Both feedUrl and workloadIdentityServiceConnection must be set together.",
16+
"loc.messages.Info_AddingFederatedFeedAuth": "Unable to get federated credentials from service connection",
17+
"loc.messages.Info_SuccessAddingFederatedFeedAuth": "Adding auth information from service connection %s for feed %s",
18+
"loc.messages.FailedToGetServiceConnectionAuth": "Successfully added auth for feed %s."
1019
}

Tasks/NuGetAuthenticateV1/_buildConfigs/Node20/package-lock.json

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Tasks/NuGetAuthenticateV1/_buildConfigs/Node20/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
},
2424
"homepage": "https://github.com/Microsoft/azure-pipelines-tasks#readme",
2525
"dependencies": {
26-
"azure-pipelines-tasks-artifacts-common": "^2.244.0",
27-
"azure-pipelines-task-lib": "^4.0.0-preview",
28-
"@types/node": "^20.3.1"
26+
"@types/node": "^20.3.1",
27+
"azure-pipelines-task-lib": "^4.13.0",
28+
"azure-pipelines-tasks-artifacts-common": "^2.244.3"
2929
},
3030
"devDependencies": {
3131
"typescript": "5.1.6"

0 commit comments

Comments
 (0)