NuGetAuthenticateV1 - Enable WIF for internal and external feeds (#20592)

* Adding task changes

* Adding generated tasks

* removing unused string

* bumping common package version

* Removing commented out bit

Author: AlexVTor

Tasks/NuGetAuthenticateV1/_buildConfigs/Node20/package-lock.json

@@ -25,7 +25,7 @@
   "dependencies": {
     "@types/node": "^20.3.1",
     "azure-pipelines-task-lib": "^4.13.0",
-    "azure-pipelines-tasks-artifacts-common": "^2.244.4"
+    "azure-pipelines-tasks-artifacts-common": "^2.247.0"
   },
   "devDependencies": {
     "typescript": "5.1.6"

Tasks/NuGetAuthenticateV1/_buildConfigs/Node20/package.json

@@ -25,7 +25,7 @@
   "dependencies": {
     "@types/node": "^20.3.1",
     "azure-pipelines-task-lib": "^4.13.0",
-    "azure-pipelines-tasks-artifacts-common": "^2.244.4"
+    "azure-pipelines-tasks-artifacts-common": "^2.247.0"
   },
   "devDependencies": {
     "typescript": "5.1.6"

Tasks/NuGetAuthenticateV1/_buildConfigs/Wif/package-lock.json

@@ -3,7 +3,7 @@ import * as tl from 'azure-pipelines-task-lib/task';
 #if WIF
 import { configureEntraCredProvider } from "azure-pipelines-tasks-artifacts-common/credentialProviderUtils";
 #endif
-import { installCredProviderToUserProfile, configureCredProvider} from 'azure-pipelines-tasks-artifacts-common/credentialProviderUtils'
+import { installCredProviderToUserProfile, configureCredProvider, configureCredProviderForSameOrganizationFeeds} from 'azure-pipelines-tasks-artifacts-common/credentialProviderUtils'
 import { ProtocolType } from 'azure-pipelines-tasks-artifacts-common/protocols';
 import { getPackagingServiceConnections } from 'azure-pipelines-tasks-artifacts-common/serviceConnectionUtils'
 import { emitTelemetry } from 'azure-pipelines-tasks-artifacts-common/telemetry'
@@ -23,14 +23,21 @@ async function main(): Promise<void> {
         const feedUrl = tl.getInput("feedUrl");
         const entraWifServiceConnectionName = tl.getInput("workloadIdentityServiceConnection");
 
+        // Only cross-org feedUrls are supported with Azure Devops service connections. If feedUrl is internal, the task will fail.
         if (feedUrl && entraWifServiceConnectionName) {
             tl.debug(tl.loc("Info_AddingFederatedFeedAuth", entraWifServiceConnectionName, feedUrl));
-            await configureEntraCredProvider(ProtocolType.NuGet, feedUrl, entraWifServiceConnectionName);
+            await configureEntraCredProvider(ProtocolType.NuGet, entraWifServiceConnectionName, feedUrl);
+            federatedFeedAuthSuccessCount++;    
             console.log(tl.loc("Info_SuccessAddingFederatedFeedAuth", feedUrl));
-            federatedFeedAuthSuccessCount++;
 
             return;
-        }  else if (feedUrl || entraWifServiceConnectionName) {
+        }
+        // If the user doesn't provide a feedUrl, use the Azure Devops service connection to replace the Build Service
+        else if (!feedUrl && entraWifServiceConnectionName) {
+            configureCredProviderForSameOrganizationFeeds(ProtocolType.NuGet, entraWifServiceConnectionName);
+            return;
+        }  
+        else if (feedUrl) {
             throw new Error(tl.loc("Error_MissingFeedUrlOrServiceConnection"));
         }
 #endif

Tasks/NuGetAuthenticateV1/_buildConfigs/Wif/package.json

@@ -25,7 +25,7 @@
     "dependencies": {
         "@types/node": "10.17.0",
         "azure-pipelines-task-lib": "^4.13.0",
-        "azure-pipelines-tasks-artifacts-common": "^2.244.4"
+        "azure-pipelines-tasks-artifacts-common": "^2.247.0"
     },
     "devDependencies": {
         "typescript": "4.0.2"

Tasks/NuGetAuthenticateV1/main.ts

@@ -14,7 +14,7 @@
   "version": {
     "Major": 1,
     "Minor": 247,
-    "Patch": 0
+    "Patch": 3
   },
   "minimumAgentVersion": "2.144.0",
   "instanceNameFormat": "NuGet Authenticate",

Tasks/NuGetAuthenticateV1/package-lock.json

@@ -14,7 +14,7 @@
   "version": {
     "Major": 1,
     "Minor": 247,
-    "Patch": 0
+    "Patch": 3
   },
   "minimumAgentVersion": "2.144.0",
   "instanceNameFormat": "ms-resource:loc.instanceNameFormat",

Tasks/NuGetAuthenticateV1/package.json

@@ -1,3 +1,3 @@
-Default|1.247.0
-Node20_229_1|1.247.1
-wif_242|1.247.2
+Default|1.247.3
+Node20_229_1|1.247.4
+wif_242|1.247.5