Skip to content

Commit ee87882

Browse files
issacnitinmsftissacnitinmsft
authored
Adding error log pointing to trouble shooting guide for ARG task (#12752) (#12754)
* Adding error log pointing to trouble shooting guide for ARG task * Updating link
1 parent 89e419b commit ee87882

File tree

8 files changed

+23
-15
lines changed

8 files changed

+23
-15
lines changed

‎Tasks/AzureResourceGroupDeploymentV2/Strings/resources.resjson/en-US/resources.resjson‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,5 +196,6 @@
196196
"loc.messages.FindMoreDeploymentDetailsAzurePortal": "Task successfully created an Azure Resource Manager deployment, but the deployment failed. Please see more detailed Azure resource manager deployment logs at: (Please Copy-Paste the link) %s",
197197
"loc.messages.TemplateValidationFailure": "Validation errors were found in the Azure Resource Manager template. This can potentially cause template deployment to fail. %s. Please follow https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-syntax",
198198
"loc.messages.ManagedServiceIdentityDetails": "Please make sure the Managed Service Identity used for deployment is assigned the right roles for the Resource Group %s. Follow the link for more details: https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/howto-assign-access-portal",
199-
"loc.messages.DeploymentGroupConfigurationFailedOnVM": "Failure for Virtual Machine '%s': %s"
199+
"loc.messages.DeploymentGroupConfigurationFailedOnVM": "Failure for Virtual Machine '%s': %s",
200+
"loc.messages.TroubleshootingGuide": "Check out the troubleshooting guide to see if your issue is addressed: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment?view=azure-devops"
200201
}

‎Tasks/AzureResourceGroupDeploymentV2/main.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ tl.setResourcePath(path.join( __dirname, 'node_modules/azure-arm-rest-v2/module.
3737

3838
run().then((result) =>
3939
tl.setResult(tl.TaskResult.Succeeded, "")
40-
).catch((error) =>
41-
tl.setResult(tl.TaskResult.Failed, error)
42-
);
40+
).catch((error) => {
41+
tl.error(tl.loc("TroubleshootingGuide"));
42+
tl.setResult(tl.TaskResult.Failed, error);
43+
});

‎Tasks/AzureResourceGroupDeploymentV2/task.json‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"version": {
1616
"Major": 2,
1717
"Minor": 165,
18-
"Patch": 0
18+
"Patch": 1
1919
},
2020
"demands": [],
2121
"minimumAgentVersion": "2.119.1",
@@ -485,6 +485,7 @@
485485
"FindMoreDeploymentDetailsAzurePortal": "Task successfully created an Azure Resource Manager deployment, but the deployment failed. Please see more detailed Azure resource manager deployment logs at: (Please Copy-Paste the link) %s",
486486
"TemplateValidationFailure": "Validation errors were found in the Azure Resource Manager template. This can potentially cause template deployment to fail. %s. Please follow https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-syntax",
487487
"ManagedServiceIdentityDetails": "Please make sure the Managed Service Identity used for deployment is assigned the right roles for the Resource Group %s. Follow the link for more details: https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/howto-assign-access-portal",
488-
"DeploymentGroupConfigurationFailedOnVM": "Failure for Virtual Machine '%s': %s"
488+
"DeploymentGroupConfigurationFailedOnVM": "Failure for Virtual Machine '%s': %s",
489+
"TroubleshootingGuide": "Check out the troubleshooting guide to see if your issue is addressed: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment?view=azure-devops#troubleshooting"
489490
}
490491
}

‎Tasks/AzureResourceGroupDeploymentV2/task.loc.json‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"version": {
1616
"Major": 2,
1717
"Minor": 165,
18-
"Patch": 0
18+
"Patch": 1
1919
},
2020
"demands": [],
2121
"minimumAgentVersion": "2.119.1",
@@ -485,6 +485,7 @@
485485
"FindMoreDeploymentDetailsAzurePortal": "ms-resource:loc.messages.FindMoreDeploymentDetailsAzurePortal",
486486
"TemplateValidationFailure": "ms-resource:loc.messages.TemplateValidationFailure",
487487
"ManagedServiceIdentityDetails": "ms-resource:loc.messages.ManagedServiceIdentityDetails",
488-
"DeploymentGroupConfigurationFailedOnVM": "ms-resource:loc.messages.DeploymentGroupConfigurationFailedOnVM"
488+
"DeploymentGroupConfigurationFailedOnVM": "ms-resource:loc.messages.DeploymentGroupConfigurationFailedOnVM",
489+
"TroubleshootingGuide": "ms-resource:loc.messages.TroubleshootingGuide"
489490
}
490491
}

‎Tasks/AzureResourceManagerTemplateDeploymentV3/Strings/resources.resjson/en-US/resources.resjson‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,5 +87,6 @@
8787
"loc.messages.FindMoreDeploymentDetailsAzurePortal": "Task successfully created an Azure Resource Manager deployment, but the deployment failed. Please see more detailed Azure resource manager deployment logs at: (Please Copy-Paste the link) %s",
8888
"loc.messages.ManagedServiceIdentityDetails": "Please make sure the Managed Service Identity used for deployment is assigned the right roles for the Resource Group %s. Follow the link for more details: https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/howto-assign-access-portal",
8989
"loc.messages.CompleteDeploymentModeNotSupported": "Deployment mode 'Complete' is not supported for deployment at '%s' scope",
90-
"loc.messages.TemplateValidationFailure": "Validation errors were found in the Azure Resource Manager template. This can potentially cause template deployment to fail. %s. Please follow https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-syntax"
90+
"loc.messages.TemplateValidationFailure": "Validation errors were found in the Azure Resource Manager template. This can potentially cause template deployment to fail. %s. Please follow https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-syntax",
91+
"loc.messages.TroubleshootingGuide": "Check out the troubleshooting guide to see if your issue is addressed: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment?view=azure-devops"
9192
}

‎Tasks/AzureResourceManagerTemplateDeploymentV3/main.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ tl.setResourcePath(path.join( __dirname, 'node_modules/azure-arm-rest-v2/module.
6565

6666
run().then((result) =>
6767
tl.setResult(tl.TaskResult.Succeeded, "")
68-
).catch((error) =>
68+
).catch((error) => {
69+
tl.error(tl.loc("TroubleshootingGuide"));
6970
tl.setResult(tl.TaskResult.Failed, error)
70-
);
71+
});

‎Tasks/AzureResourceManagerTemplateDeploymentV3/task.json‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"version": {
1616
"Major": 3,
1717
"Minor": 1,
18-
"Patch": 19
18+
"Patch": 20
1919
},
2020
"preview": "true",
2121
"demands": [],
@@ -306,6 +306,7 @@
306306
"FindMoreDeploymentDetailsAzurePortal": "Task successfully created an Azure Resource Manager deployment, but the deployment failed. Please see more detailed Azure resource manager deployment logs at: (Please Copy-Paste the link) %s",
307307
"ManagedServiceIdentityDetails": "Please make sure the Managed Service Identity used for deployment is assigned the right roles for the Resource Group %s. Follow the link for more details: https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/howto-assign-access-portal",
308308
"CompleteDeploymentModeNotSupported": "Deployment mode 'Complete' is not supported for deployment at '%s' scope",
309-
"TemplateValidationFailure": "Validation errors were found in the Azure Resource Manager template. This can potentially cause template deployment to fail. %s. Please follow https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-syntax"
309+
"TemplateValidationFailure": "Validation errors were found in the Azure Resource Manager template. This can potentially cause template deployment to fail. %s. Please follow https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-syntax",
310+
"TroubleshootingGuide": "Check out the troubleshooting guide to see if your issue is addressed: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment?view=azure-devops#troubleshooting"
310311
}
311312
}

‎Tasks/AzureResourceManagerTemplateDeploymentV3/task.loc.json‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"version": {
1616
"Major": 3,
1717
"Minor": 1,
18-
"Patch": 19
18+
"Patch": 20
1919
},
2020
"preview": "true",
2121
"demands": [],
@@ -306,6 +306,7 @@
306306
"FindMoreDeploymentDetailsAzurePortal": "ms-resource:loc.messages.FindMoreDeploymentDetailsAzurePortal",
307307
"ManagedServiceIdentityDetails": "ms-resource:loc.messages.ManagedServiceIdentityDetails",
308308
"CompleteDeploymentModeNotSupported": "ms-resource:loc.messages.CompleteDeploymentModeNotSupported",
309-
"TemplateValidationFailure": "ms-resource:loc.messages.TemplateValidationFailure"
309+
"TemplateValidationFailure": "ms-resource:loc.messages.TemplateValidationFailure",
310+
"TroubleshootingGuide": "ms-resource:loc.messages.TroubleshootingGuide"
310311
}
311312
}

0 commit comments

Comments
 (0)