Update tasks owned by build to use new version of azure-pipelines-task-lib (#12374)

* Update tasks owned by build to use new version of azure-pipelines-task-lib

* Bump task versions of dependent tasks

* rebuild updated tasks

* Stop warning coming from xamarin tests

* logging error in NodeToolV0 tests

* Fix tool-lib mocks

Author: chweems

Tasks/CMakeV1/cmaketask.ts

@@ -1,8 +1,8 @@
 
 
 import path = require('path');
-import tl = require('vsts-task-lib/task');
-import trm = require('vsts-task-lib/toolrunner');
+import tl = require('azure-pipelines-task-lib/task');
+import trm = require('azure-pipelines-task-lib/toolrunner');
 
 async function run() {
     try {   

Tasks/CMakeV1/package-lock.json

@@ -17,6 +17,6 @@
   },
   "homepage": "https://github.com/Microsoft/azure-pipelines-tasks#readme",
   "dependencies": {
-    "vsts-task-lib": "^0.9.20"
+    "azure-pipelines-task-lib": "^2.9.3"
   }
 }

Tasks/CMakeV1/package.json

@@ -15,8 +15,8 @@
     ],
     "version": {
         "Major": 1,
-        "Minor": 151,
-        "Patch": 1
+        "Minor": 166,
+        "Patch": 0
     },
     "minimumAgentVersion": "1.91.0",
     "instanceNameFormat": "CMake $(cmakeArgs)",

Tasks/CMakeV1/task.json

@@ -15,8 +15,8 @@
   ],
   "version": {
     "Major": 1,
-    "Minor": 151,
-    "Patch": 1
+    "Minor": 166,
+    "Patch": 0
   },
   "minimumAgentVersion": "1.91.0",
   "instanceNameFormat": "ms-resource:loc.instanceNameFormat",

Tasks/CMakeV1/task.loc.json

@@ -1,5 +1,4 @@
-import tl = require('vsts-task-lib/task');
-import { ToolRunner } from 'vsts-task-lib/toolrunner';
+import tl = require('azure-pipelines-task-lib/task');
 
 /**
  * Finds the tool path for msbuild/xbuild based on specified msbuild version on Mac or Linux agent

Tasks/Common/MSBuildHelpers/msbuildhelpers.ts

@@ -17,6 +17,6 @@
   },
   "homepage": "https://github.com/Microsoft/azure-pipelines-tasks#readme",
   "dependencies": {
-    "vsts-task-lib": "^2.0.3-preview"
+    "azure-pipelines-task-lib": "^2.9.3"
   }
 }

Tasks/Common/MSBuildHelpers/package-lock.json

@@ -1,9 +1,11 @@
 import path = require('path');
-import tl = require('vsts-task-lib/task');
+import tl = require('azure-pipelines-task-lib/task');
+import minimatch = require('minimatch');
 
 tl.setResourcePath(path.join(__dirname, 'task.json'));
 
 var gruntFile = tl.getPathInput('gruntFile', true, true);
+tl.debug('check grunt file :' + gruntFile);
 var grunt = tl.which('grunt', false);
 var isCodeCoverageEnabled = tl.getBoolInput('enableCodeCoverage');
 var publishJUnitResults = tl.getBoolInput('publishJUnitResults');
@@ -15,33 +17,33 @@ tl.cd(cwd);
 tl.debug('check path : ' + grunt);
 if (!tl.exist(grunt)) {
 	tl.debug('not found global installed grunt-cli, try to find grunt-cli locally.');
-	var gt = tl.createToolRunner(tl.which('node', true));
+	var gt = tl.tool(tl.which('node', true));
 	var gtcli = tl.getInput('gruntCli', true);
 	gtcli = path.resolve(cwd, gtcli);
 	tl.debug('check path : ' + gtcli);
 	if (!tl.exist(gtcli)) {
 		tl.setResult(tl.TaskResult.Failed, tl.loc('GruntCliNotInstalled', gtcli));
 	}
-	gt.pathArg(gtcli);
+	gt.arg(gtcli);
 }
 else {
-	var gt = tl.createToolRunner(grunt);
+	var gt = tl.tool(grunt);
 }
 
 if (isCodeCoverageEnabled) {
-	var npm = tl.createToolRunner(tl.which('npm', true));
-	npm.argString('install istanbul');
+	var npm = tl.tool(tl.which('npm', true));
+	npm.line('install istanbul');
 	var testFramework = tl.getInput('testFramework', true);
 	var srcFiles = tl.getInput('srcFiles', false);
 	var testSrc = tl.getPathInput('testFiles', true, false);
-	var istanbul = tl.createToolRunner(tl.which('node', true));
+	var istanbul = tl.tool(tl.which('node', true));
 	istanbul.arg('./node_modules/istanbul/lib/cli.js');
-	istanbul.argString('cover --report cobertura --report html');
+	istanbul.line('cover --report cobertura --report html');
 	if (srcFiles) {
-		istanbul.argString('-i .' + path.sep + path.join(srcFiles));
+		istanbul.line('-i .' + path.sep + path.join(srcFiles));
 	}
 	if (testFramework.toLowerCase() == 'jasmine') {
-		istanbul.argString('./node_modules/jasmine/bin/jasmine.js JASMINE_CONFIG_PATH=node_modules/jasmine/lib/examples/jasmine.json');
+		istanbul.line('./node_modules/jasmine/bin/jasmine.js JASMINE_CONFIG_PATH=node_modules/jasmine/lib/examples/jasmine.json');
 	} else {
 		istanbul.arg('./node_modules/mocha/bin/_mocha');
 	}
@@ -52,9 +54,8 @@ if (isCodeCoverageEnabled) {
 
 // optional - no targets will concat nothing
 gt.arg(tl.getDelimitedInput('targets', ' ', false));
-gt.arg('--gruntfile');
-gt.pathArg(gruntFile);
-gt.argString(tl.getInput('arguments', false));
+gt.arg(['--gruntfile', gruntFile]);
+gt.line(tl.getInput('arguments', false));
 gt.exec().then(function (code) {
 	publishTestResults(publishJUnitResults, testResultsFiles);
 	if (isCodeCoverageEnabled) {
@@ -87,7 +88,7 @@ function publishTestResults(publishJUnitResults, testResultsFiles: string) {
             tl.debug('Pattern found in testResultsFiles parameter');
             var buildFolder = tl.getVariable('System.DefaultWorkingDirectory');
             var allFiles = tl.find(buildFolder);
-            var matchingTestResultsFiles = tl.match(allFiles, testResultsFiles, { matchBase: true });
+            var matchingTestResultsFiles = minimatch.match(allFiles, testResultsFiles, { matchBase: true });
         }
         else {
             tl.debug('No pattern found in testResultsFiles parameter');
@@ -99,7 +100,7 @@ function publishTestResults(publishJUnitResults, testResultsFiles: string) {
         }
         var tp = new tl.TestPublisher("JUnit");
         try {
-			tp.publish(matchingTestResultsFiles, true, "", "", "", true);
+			tp.publish(matchingTestResultsFiles, 'true', "", "", "", 'true');
 		} catch (error) {
 			tl.warning(error);
 		}