allow passwords starting with a hyphen (#12909) (#13019)

* allow passwords starting with a hyphen

* updates AzureCLIV1 per review comments.

Co-authored-by: David Kendall <[email protected]>
Co-authored-by: Nitin Issac Joy <[email protected]>

Co-authored-by: David Kendall <[email protected]>
Co-authored-by: David Kendall <[email protected]>

Author: 3 people

Tasks/AzureCLIV1/azureclitask.ts

@@ -147,7 +147,7 @@ export class azureclitask {
             let escapedCliPassword = cliPassword.replace(/"/g, '\\"');
             tl.setSecret(escapedCliPassword.replace(/\\/g, '\"'));
             //login using svn
-            this.throwIfError(tl.execSync("az", `login --service-principal -u "${servicePrincipalId}" -p "${escapedCliPassword}" --tenant "${tenantId}"`), tl.loc("LoginFailed"));
+            this.throwIfError(tl.execSync("az", `login --service-principal -u "${servicePrincipalId}" --password="${escapedCliPassword}" --tenant "${tenantId}"`), tl.loc("LoginFailed"));
         }
         else if(authScheme.toLowerCase() == "managedserviceidentity") {
             //login using msi

Tasks/AzureCLIV1/task.json

@@ -20,7 +20,7 @@
     "version": {
         "Major": 1,
         "Minor": 163,
-        "Patch": 1
+        "Patch": 3
     },
     "minimumAgentVersion": "2.0.0",
     "instanceNameFormat": "Azure CLI $(scriptPath)",

Tasks/AzureCLIV1/task.loc.json

@@ -20,7 +20,7 @@
   "version": {
     "Major": 1,
     "Minor": 163,
-    "Patch": 1
+    "Patch": 3
   },
   "minimumAgentVersion": "2.0.0",
   "instanceNameFormat": "ms-resource:loc.instanceNameFormat",

Tasks/AzureCLIV2/azureclitask.ts

@@ -134,7 +134,7 @@ export class azureclitask {
             let escapedCliPassword = cliPassword.replace(/"/g, '\\"');
             tl.setSecret(escapedCliPassword.replace(/\\/g, '\"'));
             //login using svn
-            Utility.throwIfError(tl.execSync("az", `login --service-principal -u "${servicePrincipalId}" -p "${escapedCliPassword}" --tenant "${tenantId}" --allow-no-subscriptions`), tl.loc("LoginFailed"));
+            Utility.throwIfError(tl.execSync("az", `login --service-principal -u "${servicePrincipalId}" --password="${escapedCliPassword}" --tenant "${tenantId}" --allow-no-subscriptions`), tl.loc("LoginFailed"));
         }
         else if(authScheme.toLowerCase() == "managedserviceidentity") {
             //login using msi

Tasks/AzureCLIV2/task.json

@@ -20,7 +20,7 @@
     "version": {
         "Major": 2,
         "Minor": 0,
-        "Patch": 14
+        "Patch": 16
     },
     "minimumAgentVersion": "2.0.0",
     "instanceNameFormat": "Azure CLI $(scriptPath)",

Tasks/AzureCLIV2/task.loc.json

@@ -20,7 +20,7 @@
   "version": {
     "Major": 2,
     "Minor": 0,
-    "Patch": 14
+    "Patch": 16
   },
   "minimumAgentVersion": "2.0.0",
   "instanceNameFormat": "ms-resource:loc.instanceNameFormat",