Fix download of fileshare artifact when location contains spaces. (#6053)

* Fix download of fileshare artifact when location contains spaces.

* bump up artifact-engine version

Author: omeshp

Tasks/AzureVmssDeployment/package.json

@@ -3,6 +3,6 @@
   "main": "main.js",
   "dependencies": {
     "vsts-task-lib": "2.1.0",
-    "artifact-engine": "0.1.13"
+    "artifact-engine": "0.1.14"
   }
 }

Tasks/Common/azure-blobstorage-artifactProvider/package.json

@@ -14,7 +14,7 @@
   "homepage": "https://github.com/Microsoft/vsts-tasks#readme",
   "dependencies": {
     "q": "1.4.1",
-    "artifact-engine": "0.1.13",
+    "artifact-engine": "0.1.14",
     "azure-storage": "2.2.1",
     "vsts-task-lib": "2.1.0"
   }

Tasks/DownloadBuildArtifacts/main.ts

@@ -44,7 +44,7 @@ function publishEvent(feature, properties: any): void {
         else {
             if (feature === 'reliability') {
                 let reliabilityData = properties;
-                telemetry = "##vso[task.logissue type=error;code=" + reliabilityData.issueType + ";agentVersion=" + tl.getVariable('Agent.Version') + ";taskId=" + area + "-" + taskJson.version + ";]" + reliabilityData.errorMessage
+                telemetry = "##vso[task.logissue type=error;code=" + reliabilityData.issueType + ";agentVersion=" + tl.getVariable('Agent.Version') + ";taskId=" + area + "-" + JSON.stringify(taskJson.version) + ";]" + reliabilityData.errorMessage
             }
         }
         console.log(telemetry);;
@@ -163,7 +163,7 @@ async function main(): Promise<void> {
                 }
                 else if (artifact.resource.type.toLowerCase() === "filepath") {
                     let downloader = new engine.ArtifactEngine();
-                    let downloadUrl = artifact.resource.downloadUrl.replace("file:", "");
+                    let downloadUrl = decodeURI(artifact.resource.downloadUrl.replace("file:", ""));
                     let artifactLocation = downloadUrl + '/' + artifact.name;
                     if (!fs.existsSync(artifactLocation)) {
                         console.log(tl.loc("ArtifactNameDirectoryNotFound", artifactLocation, downloadUrl));

Tasks/DownloadBuildArtifacts/package.json

@@ -19,6 +19,6 @@
   "dependencies": {
     "vsts-task-lib": "2.1.0",
     "vso-node-api": "^6.2.8-preview",
-    "artifact-engine": "0.1.13"
+    "artifact-engine": "0.1.14"
   }
 }

Tasks/DownloadBuildArtifacts/task.json

@@ -10,7 +10,7 @@
   "version": {
     "Major": 0,
     "Minor": 127,
-    "Patch": 4
+    "Patch": 5
   },
   "groups": [
     {

Tasks/DownloadBuildArtifacts/task.loc.json

@@ -10,7 +10,7 @@
   "version": {
     "Major": 0,
     "Minor": 127,
-    "Patch": 4
+    "Patch": 5
   },
   "groups": [
     {

Tasks/JenkinsDownloadArtifacts/jenkinsdownloadartifacts.ts

@@ -68,7 +68,7 @@ function publishEvent(feature, properties: any): void {
         else {
             if (feature === 'reliability') {
                 let reliabilityData = properties;
-                telemetry = "##vso[task.logissue type=error;code=" + reliabilityData.issueType + ";agentVersion=" + tl.getVariable('Agent.Version') + ";taskId=" + area + "-" + taskJson.version + ";]" + reliabilityData.errorMessage
+                telemetry = "##vso[task.logissue type=error;code=" + reliabilityData.issueType + ";agentVersion=" + tl.getVariable('Agent.Version') + ";taskId=" + area + "-" + JSON.stringify(taskJson.version) + ";]" + reliabilityData.errorMessage
             }
         }
         console.log(telemetry);;

Tasks/JenkinsDownloadArtifacts/package.json

@@ -8,7 +8,7 @@
   "author": "Microsoft Corporation",
   "license": "MIT",
   "dependencies": {
-    "artifact-engine": "0.1.13",
+    "artifact-engine": "0.1.14",
     "azure-arm-rest": "file:../../_build/Tasks/Common/azure-arm-rest",
     "azure-blobstorage-artifactProvider": "file:../../_build/Tasks/Common/azure-blobstorage-artifactProvider",
     "request": "2.74.0",

Tasks/JenkinsDownloadArtifacts/task.json

@@ -18,7 +18,7 @@
     "version": {
         "Major": 1,
         "Minor": 127,
-        "Patch": 3
+        "Patch": 4
     },
     "groups": [
         {

Tasks/JenkinsDownloadArtifacts/task.loc.json

@@ -18,7 +18,7 @@
   "version": {
     "Major": 1,
     "Minor": 127,
-    "Patch": 3
+    "Patch": 4
   },
   "groups": [
     {