Skip to content

Commit ff6cc82

Browse files
authored
Moves token security closest to the location where the token enters t… (#194)
* Moves token security closest to the location where the token enters the task * Update id-token-generator.ts
1 parent 4d8ae33 commit ff6cc82

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

Tasks/TerraformTask/TerraformTaskV4/src/azure-terraform-command-handler.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ export class TerraformCommandHandlerAzureRM extends BaseTerraformCommandHandler
3737
var workloadIdentityFederationCredentials = await this.getWorkloadIdentityFederationCredentials(backendServiceName);
3838
this.backendConfig.set('client_id', workloadIdentityFederationCredentials.servicePrincipalId);
3939
this.backendConfig.set('oidc_token', workloadIdentityFederationCredentials.idToken);
40-
console.log('##vso[task.setsecret]' + workloadIdentityFederationCredentials.idToken);
4140
this.backendConfig.set('use_oidc', 'true');
4241
break;
4342

@@ -148,4 +147,4 @@ enum AuthorizationScheme {
148147
ServicePrincipal = "serviceprincipal",
149148
ManagedServiceIdentity = "managedserviceidentity",
150149
WorkloadIdentityFederation = "workloadidentityfederation"
151-
}
150+
}

Tasks/TerraformTask/TerraformTaskV4/src/id-token-generator.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ export interface ITokenGenerator {
1111

1212
export class TokenGenerator implements ITokenGenerator {
1313
public async generate(connectedService : string): Promise<string> {
14-
return await getFederatedToken(connectedService);
14+
const token = await getFederatedToken(connectedService);
15+
console.log('##vso[task.setsecret]' + token);
16+
return token;
1517
}
16-
}
18+
}

0 commit comments

Comments
 (0)