Add Retries to Tool Retrieval (#55)

* Add Retries to Tool Retrieval

Per #10170

* nit: misspelled test name and var name

* Wrote test for timeouts on downloadTool

* Update tests and dependencies (#2)

* Updated dependencies, fixed timeout test

* Updated gitignore to ignore vscode files

* Removed vscode directory

* Removed weird spacing change

* Remove old retry code, fix max retries

* Updated dependencies, fixed timeout test

* Updated gitignore to ignore vscode files

* Removed vscode directory

* Removed weird spacing change

* Removed old retry code, fixed max retries to match tests.

*  Removed retry on timeout test (#4)

* Updated dependencies, fixed timeout test

* Updated gitignore to ignore vscode files

* Removed vscode directory

* Removed weird spacing change

* Removed old retry code, fixed max retries to match tests.

* Removed retry on timeout test

Author: magleaso

.gitignore

@@ -45,4 +45,7 @@ package-lock.json
 .node_repl_history
 
 # Temp directories
-TEMP
+TEMP
+
+# VS Code Files
+.vscode

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "azure-pipelines-tool-lib",
-  "version": "0.13.0",
+  "version": "0.13.1",
   "description": "Azure Pipelines Tool Installer Lib for CI/CD Tasks",
   "main": "tool.js",
   "scripts": {
@@ -24,22 +24,22 @@
   "homepage": "https://github.com/microsoft/azure-pipelines-tool-lib#readme",
   "dependencies": {
     "@types/semver": "^5.3.0",
-    "@types/uuid": "^3.0.1",
+    "@types/uuid": "^3.4.5",
     "azure-pipelines-task-lib": "^2.8.0",
-    "semver": "^5.3.0",
+    "semver": "^5.7.0",
     "semver-compare": "^1.0.0",
-    "typed-rest-client": "1.0.9",
-    "uuid": "^3.0.1"
+    "typed-rest-client": "1.5.0",
+    "uuid": "^3.3.2"
   },
   "devDependencies": {
-    "typescript": "3.1.5",
-    "@types/node": "^8.0.19",
-    "nock": "9.6.1",
-    "mocha": "^3.2.0",
     "@types/mocha": "^2.2.41",
+    "@types/node": "^8.10.50",
+    "@types/shelljs": "^0.7.9",
+    "@types/xml2js": "^0.4.4",
+    "mocha": "^3.2.0",
+    "nock": "9.6.1",
     "shelljs": "^0.7.6",
-    "@types/shelljs": "^0.7.4",
-    "xml2js": "^0.4.17",
-    "@types/xml2js": "^0.4.0"
+    "typescript": "3.1.5",
+    "xml2js": "^0.4.17"
   }
 }

package.json

@@ -69,18 +69,18 @@ describe('Tool Tests', function () {
         });
     });
 
-    it('downloads to an aboslute path', function () {
+    it('downloads to an absolute path', function () {
         this.timeout(5000);
 
         return new Promise<void>(async(resolve, reject)=> {
             try {
                 let tempDownloadFolder: string = 'temp_' + Math.floor(Math.random() * 2000000000);
-                let aboslutePath: string = path.join(tempPath, tempDownloadFolder);
-                let downPath: string = await toolLib.downloadTool("http://httpbin.org/bytes/100", aboslutePath);
+                let absolutePath: string = path.join(tempPath, tempDownloadFolder);
+                let downPath: string = await toolLib.downloadTool("http://httpbin.org/bytes/100", absolutePath);
                 toolLib.debug('downloaded path: ' + downPath);
 
                 assert(tl.exist(downPath), 'downloaded file exists');
-                assert(aboslutePath == downPath);
+                assert(absolutePath == downPath);
 
                 resolve();
             }

test/tests/toolTests.ts

@@ -17,7 +17,10 @@ let userAgent = 'vsts-task-installer/' + pkg.version;
 let requestOptions = {
     // ignoreSslError: true,
     proxy: tl.getHttpProxyConfiguration(),
-    cert: tl.getHttpCertConfiguration()
+    cert: tl.getHttpCertConfiguration(),
+    allowRedirects: true,
+    allowRetries: true,
+    maxRetries: 2
 } as ifm.IRequestOptions;
 tl.setResourcePath(path.join(__dirname, 'lib.json'));
 
@@ -225,18 +228,7 @@ export async function downloadTool(url: string, fileName?: string, handlers?: if
             }
 
             tl.debug('downloading');
-            const statusCodesToRetry = [httpm.HttpCodes.BadGateway, httpm.HttpCodes.ServiceUnavailable, httpm.HttpCodes.GatewayTimeout];
-            let retryCount: number = 1;
-            const maxRetries: number = 3;
             let response: httpm.HttpClientResponse = await http.get(url);
-
-            while(retryCount < maxRetries && statusCodesToRetry.indexOf(response.message.statusCode) > -1) {
-                tl.debug(`Download attempt "${retryCount}" of "${maxRetries}" failed with status code "${response.message.statusCode}".`);
-                retryCount += 1;
-                await delay(1000);
-                tl.debug(`Downloading attempt "${retryCount}" of "${maxRetries}"`);
-                response = await http.get(url);
-            }
 
             if (response.message.statusCode != 200) {
                 let err: Error = new Error('Unexpected HTTP response: ' + response.message.statusCode);