Merge pull request #6864 from microsoft/bugfixes-combobox

wangmingliang-ms · web-flow · commit 05be79b81cc6 · 2022-08-25T17:20:00.000+08:00
fix miscellaneous bugs found in feature test about cosmos db.
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-appservice/src/main/java/com/microsoft/azure/toolkit/intellij/legacy/function/runner/FunctionRunLineMarkerProvider.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-appservice/src/main/java/com/microsoft/azure/toolkit/intellij/legacy/function/runner/FunctionRunLineMarkerProvider.java
@@ -23,7 +23,6 @@
 public class FunctionRunLineMarkerProvider extends RunLineMarkerContributor {
     @Nullable
     @Override
-    @ExceptionNotification
     public Info getInfo(@NotNull PsiElement e) {
         if (isIdentifier(e)) {
             final PsiElement parentElement = e.getParent();
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-cosmos/src/main/resources/META-INF/azure-intellij-plugin-cosmos-dbtools.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-cosmos/src/main/resources/META-INF/azure-intellij-plugin-cosmos-dbtools.xml
@@ -9,6 +9,7 @@
         <extensionFallback dbms="AZ_COSMOS_CASSANDRA" fallbackDbms="CASSANDRA"/>
         <driversConfig config="databaseDrivers/azure-cosmos-mongo-drivers.xml"/>
         <driversConfig config="databaseDrivers/azure-cosmos-cassandra-drivers.xml"/>
+        <artifactsConfig config="databaseDrivers/azure-cosmos-cassandra-drivers-extension.xml"/>
         <urlParamEditorProvider implementation="com.microsoft.azure.toolkit.intellij.cosmos.dbtools.MongoCosmosDbAccountTypeFactory" order="first"/>
         <urlParamEditorProvider implementation="com.microsoft.azure.toolkit.intellij.cosmos.dbtools.CassandraCosmosDbAccountTypeFactory" order="first"/>
     </extensions>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-cosmos/src/main/resources/databaseDrivers/azure-cosmos-cassandra-drivers-extension.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-cosmos/src/main/resources/databaseDrivers/azure-cosmos-cassandra-drivers-extension.xml
@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<artifacts>
+    <artifact name="Azure Cosmos Extensions for Apache Cassandra">
+        <version version="1.1.2">
+            <item type="maven" url="com.azure:azure-cosmos-cassandra-driver-4-extensions:1.1.2"/>
+        </version>
+        <version version="1.1.1">
+            <item type="maven" url="com.azure:azure-cosmos-cassandra-driver-4-extensions:1.1.1"/>
+        </version>
+        <version version="1.1.0">
+            <item type="maven" url="com.azure:azure-cosmos-cassandra-driver-4-extensions:1.1.0"/>
+        </version>
+        <version version="1.0.1">
+            <item type="maven" url="com.azure:azure-cosmos-cassandra-driver-4-extensions:1.0.1"/>
+        </version>
+        <version version="1.0.0">
+            <item type="maven" url="com.azure:azure-cosmos-cassandra-driver-4-extensions:1.0.0"/>
+        </version>
+    </artifact>
+</artifacts>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-cosmos/src/main/resources/databaseDrivers/azure-cosmos-cassandra-drivers.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-cosmos/src/main/resources/databaseDrivers/azure-cosmos-cassandra-drivers.xml
@@ -6,6 +6,7 @@
             dialect="CassandraQL" driver-class="com.dbschema.CassandraJdbcDriver">
         <url-template name="default" template="jdbc:cassandra://&lt;\,,{host::localhost}?[:{port::10350}]&gt;[/{database:::keyspace}?[/{account:cosmos_account_cassandra}?][\?&lt;&amp;,user={user},password={password},{:identifier}={:identifier}&gt;]]"/>
         <artifact name="Cassandra" use="true" rolling="true"/>
+        <artifact name="Azure Cosmos Extensions for Apache Cassandra" use="true" rolling="true"/>
         <option name="auto-sync" value="true"/>
         <property name="appName" value="DataGrip"/>
     </driver>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-cosmos/src/main/resources/databaseDrivers/azure-cosmos-mongo-drivers.xml b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-cosmos/src/main/resources/databaseDrivers/azure-cosmos-mongo-drivers.xml
@@ -3,7 +3,7 @@
     <!--driver will use same icon as that of DBMS if not configured according to com/intellij/database/dataSource/DatabaseDriverImpl.class:644-->
     <driver id="az_cosmos_mongo" name="Azure Cosmos DB (MongoDB)"
             dbms="AZ_COSMOS_MONGO" forced-dbms="AZ_COSMOS_MONGO"
-            dialect="MongoJS" driver-class="com.dbschema.MongoJdbcDriver">
+            dialect="MongoDB" driver-class="com.dbschema.MongoJdbcDriver">
         <url-template name="default" template="[jdbc:]mongodb[+srv]://[{user:identifier}[:{password:param}]@]&lt;\,,{host::localhost}?[:{port::27017}]&gt;[/{database}?[/{account:cosmos_account_mongo}?][\?&lt;&amp;,{:identifier}={:param}&gt;]]"/>
         <artifact name="MongoDB" use="true" rolling="true"/>
         <option name="auto-sync" value="true"/>
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-lib/src/main/java/com/microsoft/azure/toolkit/intellij/common/AzureComboBox.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-lib/src/main/java/com/microsoft/azure/toolkit/intellij/common/AzureComboBox.java
@@ -171,12 +171,11 @@ private void refreshValue() {
             final List<T> items = this.getItems();
             if (this.value instanceof AzureComboBox.ItemReference) {
                 items.stream().filter(i -> ((ItemReference<?>) this.value).is(i)).findFirst().ifPresent(this::setValue);
+            } else if (items.contains(this.value)) {
+                super.setSelectedItem(this.value);
             } else if (this.value instanceof AbstractAzResource && ((AbstractAzResource<?, ?, ?>) this.value).isDraftForCreating()) {
-                // todo: unify model for custom created resource
                 super.addItem((T) this.value);
                 super.setSelectedItem(this.value);
-            } else if (items.contains(this.value)) {
-                super.setSelectedItem(this.value);
             } else {
                 super.setSelectedItem(null);
             }
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-lib/src/main/java/com/microsoft/azure/toolkit/intellij/common/AzureFormInputComponent.java b/PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-lib/src/main/java/com/microsoft/azure/toolkit/intellij/common/AzureFormInputComponent.java
@@ -32,7 +32,7 @@ default JComponent getInputComponent() {
     @Override
     default boolean needValidation() {
         final JComponent comp = this.getInputComponent();
-        return AzureFormInput.super.needValidation() && comp.isEnabled() && comp.isVisible();
+        return AzureFormInput.super.needValidation() && comp.isVisible();
     }
 
     @Override
diff --git a/PluginsAndFeatures/azure-toolkit-for-intellij/src/main/java/com/microsoft/intellij/ui/ServicePrincipalLoginDialog.java b/PluginsAndFeatures/azure-toolkit-for-intellij/src/main/java/com/microsoft/intellij/ui/ServicePrincipalLoginDialog.java
@@ -93,7 +93,7 @@ public ServicePrincipalLoginDialog(@Nonnull Project project) {
         initJsonData();
 
         // initialize cert file select
-        FileChooserDescriptor pem = FileChooserDescriptorFactory.createSingleFileDescriptor("pem");
+        final FileChooserDescriptor pem = FileChooserDescriptorFactory.createSingleFileDescriptor("pem");
         pem.withFileFilter(file -> StringUtils.equalsIgnoreCase(file.getExtension(), "pem"));
         certFileTextField.addActionListener(new ComponentWithBrowseButton.BrowseFolderActionListener<>("Select Certificate File", null, certFileTextField, null,
             pem, TextComponentAccessor.TEXT_FIELD_WHOLE_TEXT) {
@@ -131,20 +131,20 @@ public void documentChanged(@NotNull DocumentEvent event) {
 
     @Override
     protected @NotNull List<ValidationInfo> doValidateAll() {
-        List<ValidationInfo> res = new ArrayList<>();
-        AuthConfiguration data = getValue();
+        final List<ValidationInfo> res = new ArrayList<>();
+        final AuthConfiguration data = getValue();
         if (StringUtils.isBlank(data.getTenant())) {
-            res.add(new ValidationInfo("tenant is required.", tenantIdTextField));
+            res.add(new ValidationInfo("Tenant is required.", tenantIdTextField));
         }
-        if (!isGuid(data.getTenant())) {
-            res.add(new ValidationInfo("tenant should be a valid guid.", tenantIdTextField));
+        if (notGuid(data.getTenant())) {
+            res.add(new ValidationInfo("Tenant should be a valid guid.", tenantIdTextField));
         }
 
         if (StringUtils.isBlank(data.getClient())) {
-            res.add(new ValidationInfo("clientId(appId) is required.", clientIdTextField));
+            res.add(new ValidationInfo("ClientId(appId) is required.", clientIdTextField));
         }
-        if (!isGuid(data.getClient())) {
-            res.add(new ValidationInfo("clientId(appId) should be a valid guid.", clientIdTextField));
+        if (notGuid(data.getClient())) {
+            res.add(new ValidationInfo("ClientId(appId) should be a valid guid.", clientIdTextField));
         }
 
         if (this.passwordRadioButton.isSelected()) {
@@ -182,17 +182,17 @@ private void createUIComponents() {
     }
 
     private EditorTextField buildCodeViewer() {
-        EditorTextFieldProvider service = ApplicationManager.getApplication().getService(EditorTextFieldProvider.class);
-        Set<EditorCustomization> editorFeatures = new HashSet<>();
+        final EditorTextFieldProvider service = ApplicationManager.getApplication().getService(EditorTextFieldProvider.class);
+        final Set<EditorCustomization> editorFeatures = new HashSet<>();
         editorFeatures.add(SoftWrapsEditorCustomization.ENABLED);
         editorFeatures.add(SpellCheckingEditorCustomization.getInstance(false));
-        EditorTextField editorTextField = service.getEditorField(Objects.requireNonNull(Language.findLanguageByID("JSON")), project, editorFeatures);
+        final EditorTextField editorTextField = service.getEditorField(Objects.requireNonNull(Language.findLanguageByID("JSON")), project, editorFeatures);
         editorTextField.setMinimumSize(new Dimension(200, 100));
         return editorTextField;
     }
 
     public AuthConfiguration getValue() {
-        AuthConfiguration data = new AuthConfiguration(AuthType.SERVICE_PRINCIPAL);
+        final AuthConfiguration data = new AuthConfiguration(AuthType.SERVICE_PRINCIPAL);
 
         data.setClient(clientIdTextField.getText());
         data.setTenant(tenantIdTextField.getText());
@@ -220,7 +220,7 @@ public List<AzureValidationInfo> validateData() {
     }
 
     private void initJsonData() {
-        String textFromClip = findTextInClipboard(str ->
+        final String textFromClip = findTextInClipboard(str ->
             StringUtils.contains(str, "appId") && StringUtils.contains(str, "tenant") &&
                 (StringUtils.contains(str, "password") || StringUtils.contains(str, "fileWithCertAndPrivateKey"))
         );
@@ -235,14 +235,14 @@ public static String findTextInClipboard(Predicate<String> func) {
         if (func == null) {
             return null;
         }
-        for (Transferable currentItem : CopyPasteManager.getInstance().getAllContents()) {
+        for (final Transferable currentItem : CopyPasteManager.getInstance().getAllContents()) {
             if (currentItem.isDataFlavorSupported(DataFlavor.stringFlavor)) {
                 try {
-                    String itemStr = currentItem.getTransferData(DataFlavor.stringFlavor).toString();
+                    final String itemStr = currentItem.getTransferData(DataFlavor.stringFlavor).toString();
                     if (func.test(itemStr)) {
                         return itemStr;
                     }
-                } catch (Exception e) {
+                } catch (final Exception e) {
                     e.printStackTrace();
                 }
             }
@@ -258,18 +258,18 @@ private void uiTextComponents2Json() {
             return;
         }
         try {
-            Map<String, String> map = new LinkedHashMap<>();
-            AuthConfiguration data = getValue();
+            final Map<String, String> map = new LinkedHashMap<>();
+            final AuthConfiguration data = getValue();
 
             if (this.certificateRadioButton.isSelected()) {
                 map.put("fileWithCertAndPrivateKey", data.getCertificate());
             } else {
-                String password = StringUtils.isNotBlank(data.getKey()) ? "<hidden>" : "<empty>";
+                final String password = StringUtils.isNotBlank(data.getKey()) ? "<hidden>" : "<empty>";
                 map.put("password", password);
             }
             map.put("appId", data.getClient());
             map.put("tenant", data.getTenant());
-            String text = JsonUtils.toJson(map);
+            final String text = JsonUtils.toJson(map);
             if (!StringUtils.equals(jsonDataEditor.getText(), text)) {
                 this.jsonDataEditor.setText(text);
                 this.jsonDataEditor.setCaretPosition(0);
@@ -314,7 +314,7 @@ private void json2UIComponents(String json) {
                 });
             }
 
-        } catch (JsonSyntaxException ex) {
+        } catch (final JsonSyntaxException ex) {
             // ignore all json errors
         }
     }
@@ -323,11 +323,11 @@ private static boolean isPlaceHolder(String password) {
         return Arrays.asList("<hidden>", "<empty>").contains(password);
     }
 
-    private static boolean isGuid(String str) {
+    private static boolean notGuid(String str) {
         if (StringUtils.isBlank(str)) {
-            return false;
+            return true;
         }
-        return GUID_PATTERN.matcher(str).matches();
+        return !GUID_PATTERN.matcher(str).matches();
     }
 
     // CHECKSTYLE IGNORE check FOR NEXT 1 LINES
diff --git a/Utils/azure-toolkit-ide-libs/azure-toolkit-ide-appservice-lib/src/main/java/com/microsoft/azure/toolkit/ide/appservice/model/AppServiceConfig.java b/Utils/azure-toolkit-ide-libs/azure-toolkit-ide-appservice-lib/src/main/java/com/microsoft/azure/toolkit/ide/appservice/model/AppServiceConfig.java
@@ -6,6 +6,7 @@
 package com.microsoft.azure.toolkit.ide.appservice.model;
 
 import com.azure.core.management.AzureEnvironment;
+import com.azure.resourcemanager.resources.fluentcore.arm.ResourceId;
 import com.microsoft.azure.toolkit.lib.Azure;
 import com.microsoft.azure.toolkit.lib.appservice.config.AppServicePlanConfig;
 import com.microsoft.azure.toolkit.lib.appservice.model.PricingTier;
@@ -16,12 +17,13 @@
 import com.microsoft.azure.toolkit.lib.resource.ResourceGroupConfig;
 import lombok.AllArgsConstructor;
 import lombok.Builder;
-import lombok.EqualsAndHashCode;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import lombok.Setter;
 import lombok.experimental.SuperBuilder;
 import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.builder.EqualsBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
 
 import java.nio.file.Path;
 import java.text.SimpleDateFormat;
@@ -34,7 +36,6 @@
 @Setter
 @NoArgsConstructor
 @AllArgsConstructor
-@EqualsAndHashCode
 @SuperBuilder(toBuilder = true)
 public abstract class AppServiceConfig {
     protected static final SimpleDateFormat DATE_FORMAT = new SimpleDateFormat("yyMMddHHmmss");
@@ -91,8 +92,36 @@ public static boolean isSameApp(AppServiceConfig first, AppServiceConfig second)
             return first == second;
         }
         return StringUtils.equalsIgnoreCase(first.resourceId, second.resourceId) ||
-                (StringUtils.equalsIgnoreCase(first.name, second.name) &&
-                        StringUtils.equalsIgnoreCase(first.getResourceGroupName(), second.getResourceGroupName()) &&
-                        StringUtils.equalsIgnoreCase(first.getSubscriptionId(), second.getSubscriptionId()));
+            (StringUtils.equalsIgnoreCase(first.name, second.name) &&
+                StringUtils.equalsIgnoreCase(first.getResourceGroupName(), second.getResourceGroupName()) &&
+                StringUtils.equalsIgnoreCase(first.getSubscriptionId(), second.getSubscriptionId()));
+    }
+
+    @Override
+    public boolean equals(Object o) {
+        if (this == o) return true;
+        if (o == null || getClass() != o.getClass()) return false;
+        final AppServiceConfig that = (AppServiceConfig) o;
+
+        final ResourceId thisId = Optional.ofNullable(this.resourceId).map(ResourceId::fromString).orElse(null);
+        final String thisName = Optional.ofNullable(thisId).map(ResourceId::name).orElse(this.getName());
+        final String thisRg = Optional.ofNullable(thisId).map(ResourceId::resourceGroupName).orElse(this.getResourceGroupName());
+        final String thisSub = Optional.ofNullable(thisId).map(ResourceId::subscriptionId).orElse(this.getSubscriptionId());
+
+        final ResourceId thatId = Optional.ofNullable(that.resourceId).map(ResourceId::fromString).orElse(null);
+        final String thatName = Optional.ofNullable(thatId).map(ResourceId::name).orElse(that.getName());
+        final String thatRg = Optional.ofNullable(thatId).map(ResourceId::resourceGroupName).orElse(that.getResourceGroupName());
+        final String thatSub = Optional.ofNullable(thatId).map(ResourceId::subscriptionId).orElse(that.getSubscriptionId());
+
+        return new EqualsBuilder().append(thisSub, thatSub).append(thisName, thatName).append(thisRg, thatRg).isEquals();
+    }
+
+    @Override
+    public int hashCode() {
+        final ResourceId thisId = Optional.ofNullable(this.resourceId).map(ResourceId::fromString).orElse(null);
+        final String thisName = Optional.ofNullable(thisId).map(ResourceId::name).orElse(this.getName());
+        final String thisRg = Optional.ofNullable(thisId).map(ResourceId::resourceGroupName).orElse(this.getResourceGroupName());
+        final String thisSub = Optional.ofNullable(thisId).map(ResourceId::subscriptionId).orElse(this.getSubscriptionId());
+        return new HashCodeBuilder(17, 37).append(thisSub).append(thisRg).append(thisName).toHashCode();
     }
 }
diff --git a/Utils/azure-toolkit-ide-libs/azure-toolkit-ide-appservice-lib/src/main/java/com/microsoft/azure/toolkit/ide/appservice/webapp/model/WebAppConfig.java b/Utils/azure-toolkit-ide-libs/azure-toolkit-ide-appservice-lib/src/main/java/com/microsoft/azure/toolkit/ide/appservice/webapp/model/WebAppConfig.java
@@ -31,7 +31,6 @@
 @Setter
 @NoArgsConstructor
 @AllArgsConstructor
-@EqualsAndHashCode(callSuper = true)
 @SuperBuilder(toBuilder = true)
 public class WebAppConfig extends AppServiceConfig {
     public static final Runtime DEFAULT_RUNTIME = Runtime.LINUX_JAVA8_TOMCAT9;
diff --git a/Utils/azure-toolkit-ide-libs/azure-toolkit-ide-common-lib/src/main/java/com/microsoft/azure/toolkit/ide/common/favorite/FavoriteDraft.java b/Utils/azure-toolkit-ide-libs/azure-toolkit-ide-common-lib/src/main/java/com/microsoft/azure/toolkit/ide/common/favorite/FavoriteDraft.java
@@ -14,7 +14,7 @@
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
-import java.util.Objects;
+import java.util.Optional;
 
 public class FavoriteDraft extends Favorite implements AzResource.Draft<Favorite, AbstractAzResource<?, ?, ?>> {
     @Getter
@@ -48,7 +48,7 @@ public void reset() {
         type = AzureOperation.Type.SERVICE
     )
     public AbstractAzResource<?, ?, ?> createResourceInAzure() {
-        Favorites.getInstance().favorites.add(0, resource.getId());
+        Favorites.getInstance().favorites.add(0, resource.getId().toLowerCase());
         Favorites.getInstance().persist();
         return this.resource;
     }
@@ -67,4 +67,9 @@ public boolean isModified() {
     public void setResource(AbstractAzResource<?, ?, ?> resource) {
         this.resource = resource;
     }
+
+    public AbstractAzResource<?, ?, ?> getResource() {
+        //noinspection unchecked,rawtypes
+        return Optional.ofNullable(this.resource).orElseGet(() -> (AbstractAzResource) super.getResource());
+    }
 }
diff --git a/Utils/azure-toolkit-ide-libs/azure-toolkit-ide-common-lib/src/main/java/com/microsoft/azure/toolkit/ide/common/favorite/Favorites.java b/Utils/azure-toolkit-ide-libs/azure-toolkit-ide-common-lib/src/main/java/com/microsoft/azure/toolkit/ide/common/favorite/Favorites.java
@@ -81,7 +81,7 @@ public synchronized List<Favorite> list() {
             return Collections.emptyList();
         }
         final List<Favorite> result = new LinkedList<>(super.list());
-        result.sort(Comparator.comparing(item -> this.favorites.indexOf(item.getName())));
+        result.sort(Comparator.comparing(item -> this.favorites.indexOf(item.getName().toLowerCase())));
         return result;
     }
 
@@ -96,7 +96,7 @@ public synchronized List<Favorite> list() {
             final ObjectMapper mapper = new ObjectMapper();
             try {
                 this.favorites = new LinkedList<>(Arrays.asList(mapper.readValue(favorites, String[].class))).stream()
-                    .distinct().collect(Collectors.toList());
+                    .map(String::toLowerCase).distinct().collect(Collectors.toList());
             } catch (final JsonProcessingException ex) {
                 AzureMessager.getMessager().error("failed to load favorites.");
                 this.favorites = new LinkedList<>();
@@ -109,7 +109,7 @@ public synchronized List<Favorite> list() {
     @Nullable
     @Override
     protected AbstractAzResource<?, ?, ?> loadResourceFromAzure(@Nonnull String name, @Nullable String resourceGroup) {
-        if (this.favorites.contains(name)) {
+        if (this.favorites.contains(name.toLowerCase())) {
             return Azure.az().getById(name);
         }
         return null;
@@ -119,7 +119,7 @@ public synchronized List<Favorite> list() {
     @SneakyThrows
     protected void deleteResourceFromAzure(@Nonnull String favoriteId) {
         final String resourceId = URLDecoder.decode(ResourceId.fromString(favoriteId).name(), StandardCharsets.UTF_8.name());
-        this.favorites.remove(resourceId);
+        this.favorites.remove(resourceId.toLowerCase());
         this.persist();
     }
 
@@ -157,7 +157,7 @@ public String getResourceTypeName() {
     }
 
     public boolean exists(@Nonnull String resourceId) {
-        return this.favorites.contains(resourceId);
+        return this.favorites.contains(resourceId.toLowerCase());
     }
 
     public void unpinAll() {
diff --git a/Utils/azure-toolkit-ide-libs/azure-toolkit-ide-vm-lib/src/main/java/com/microsoft/azure/toolkit/ide/vm/VirtualMachineActionsContributor.java b/Utils/azure-toolkit-ide-libs/azure-toolkit-ide-vm-lib/src/main/java/com/microsoft/azure/toolkit/ide/vm/VirtualMachineActionsContributor.java
@@ -33,7 +33,7 @@ public class VirtualMachineActionsContributor implements IActionsContributor {
 
     @Override
     public void registerActions(AzureActionManager am) {
-        final ActionView.Builder addSshConfigView = new ActionView.Builder("Add SSH Configuration", AzureIcons.Action.ADD.getIconPath())
+        final ActionView.Builder addSshConfigView = new ActionView.Builder("Add/Edit SSH Configuration", AzureIcons.Action.ADD.getIconPath())
             .title(s -> Optional.ofNullable(s).map(r -> description("vm.add_ssh_config.vm", ((VirtualMachine) r).getName())).orElse(null))
             .enabled(s -> s instanceof VirtualMachine && ((VirtualMachine) s).getFormalStatus().isRunning());
         am.registerAction(ADD_SSH_CONFIG, new Action<>(ADD_SSH_CONFIG, addSshConfigView));

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ default JComponent getInputComponent() {`
`32`	`32`	`@Override`
`33`	`33`	`default boolean needValidation() {`
`34`	`34`	`final JComponent comp = this.getInputComponent();`
`35`		`- return AzureFormInput.super.needValidation() && comp.isEnabled() && comp.isVisible();`
	`35`	`+ return AzureFormInput.super.needValidation() && comp.isVisible();`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`@Override`