Fix Spark Run configuration cast issues

Author: wezhang

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/hdinsight/spark/actions/SparkSubmitJobAction.kt

@@ -82,7 +82,7 @@ open class SparkSubmitJobAction : AzureAnAction() {
 
         runConfigurationSetting.isEditBeforeRun = true
 
-        val runConfiguration = runConfigurationSetting.configuration as LivySparkBatchJobRunConfiguration
+        val runConfiguration = runConfigurationSetting.configuration as? LivySparkBatchJobRunConfiguration ?: return
         val model = runConfiguration.model
         model.focusedTabIndex = 1   // Select remote job submission tab
 

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/hdinsight/spark/console/SparkScalaLivyConsoleRunConfigurationFactory.kt

@@ -36,19 +36,20 @@ class SparkScalaLivyConsoleRunConfigurationFactory(sparkConsoleType: SparkScalaL
 
     override fun createConfiguration(name: String?, template: RunConfiguration): RunConfiguration =
             // Create a Spark Scala Livy run configuration based on Spark Batch run configuration
-            if (template is CosmosSparkRunConfiguration) {
-                CosmosSparkScalaLivyConsoleRunConfiguration(
-                        template.project,
-                        this,
-                        template,
-                        "${template.name} >> Azure Data Lake Spark Livy Interactive Session Console(Scala)"
-                )
-            } else {
-                SparkScalaLivyConsoleRunConfiguration(
-                        template.project,
-                        this,
-                        template as LivySparkBatchJobRunConfiguration,
-                        "${template.name} >> Spark Livy Interactive Session Console(Scala)"
-                )
+            when (template) {
+                is CosmosSparkRunConfiguration ->
+                    CosmosSparkScalaLivyConsoleRunConfiguration(
+                            template.project,
+                            this,
+                            template,
+                            "${template.name} >> Azure Data Lake Spark Livy Interactive Session Console(Scala)")
+                is LivySparkBatchJobRunConfiguration ->
+                    SparkScalaLivyConsoleRunConfiguration(
+                            template.project,
+                            this,
+                            template,
+                            "${template.name} >> Spark Livy Interactive Session Console(Scala)")
+                else -> throw UnsupportedOperationException(
+                        "Spark Livy Console doesn't support starting from the configuration ${template.name}(type: ${template.type.displayName})")
             }
 }

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/hdinsight/spark/console/SparkScalaLocalConsoleRunConfigurationFactory.kt

@@ -38,14 +38,15 @@ class SparkScalaLocalConsoleRunConfigurationFactory(sparkConsoleType: SparkScala
         // Create a Spark Scala Console run configuration based on Spark Batch run configuration
         val localClassModule =
                 (template as? LivySparkBatchJobRunConfiguration)?.model?.localRunConfigurableModel?.classpathModule
+                ?: throw UnsupportedOperationException("Spark Local Console doesn't support starting from the configuration ${template.name}(type: ${template.type.displayName})")
 
         val configuration = createTemplateConfiguration(template.project) as SparkScalaLocalConsoleRunConfiguration
         configuration.name = "${template.name} >> Spark Local Console(Scala)"
         val moduleManager = ModuleManager.getInstance(template.project)
-        configuration.module = localClassModule?.let { moduleManager.findModuleByName(it) }
+        configuration.module = localClassModule.let { moduleManager.findModuleByName(it) }
                 ?: moduleManager.modules.first { it.name.equals(template.project.name, ignoreCase = true) }
 
-        configuration.batchRunConfiguration = template as LivySparkBatchJobRunConfiguration
+        configuration.batchRunConfiguration = template
 
         return configuration
     }

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/hdinsight/spark/run/SparkBatchJobLocalRunConfigurationProducer.java

@@ -26,6 +26,7 @@
 import com.intellij.execution.actions.ConfigurationFromContext;
 import com.intellij.execution.configurations.ConfigurationFactory;
 import com.intellij.execution.configurations.ConfigurationType;
+import com.intellij.execution.configurations.RunConfiguration;
 import com.intellij.execution.junit.JavaRunConfigurationProducerBase;
 import com.intellij.openapi.module.Module;
 import com.intellij.openapi.util.Comparing;
@@ -117,11 +118,18 @@ public boolean isConfigurationFromContext(LivySparkBatchJobRunConfiguration jobC
 
                     if (!Comparing.equal(context.getModule(), configurationModule)) {
 
-                        LivySparkBatchJobRunConfiguration template = (LivySparkBatchJobRunConfiguration)context
+                        RunConfiguration template = context
                                 .getRunManager()
                                 .getConfigurationTemplate(getConfigurationFactory())
                                 .getConfiguration();
-                        final Module predefinedModule = template.getConfigurationModule().getModule();
+
+                        if (!(template instanceof LivySparkBatchJobRunConfiguration)) {
+                            return false;
+                        }
+
+                        final Module predefinedModule = ((LivySparkBatchJobRunConfiguration)template)
+                                .getConfigurationModule()
+                                .getModule();
 
                         if (!Comparing.equal(predefinedModule, configurationModule)) {
                             return false;

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/hdinsight/spark/run/action/SparkRunConfigurationAction.kt

@@ -25,7 +25,6 @@ package com.microsoft.azure.hdinsight.spark.run.action
 import com.intellij.execution.Executor
 import com.intellij.execution.RunManagerEx
 import com.intellij.execution.RunnerAndConfigurationSettings
-import com.intellij.execution.RunnerRegistry
 import com.intellij.execution.runners.ExecutionEnvironmentBuilder
 import com.intellij.execution.runners.ProgramRunner
 import com.intellij.openapi.actionSystem.AnActionEvent
@@ -130,6 +129,8 @@ abstract class SparkRunConfigurationAction : AzureAnAction, ILogger {
                     val savedIsEditBeforeRun = selectedConfigSettings.isEditBeforeRun
 
                     selectedConfigSettings.isEditBeforeRun = true
+
+                    // canRun() has checked configuration is LivySparkBatchJobRunConfiguration or not
                     (selectedConfigSettings.configuration as LivySparkBatchJobRunConfiguration).submitModel.mainClassName =
                             className