Skip to content

Commit 25e441f

Browse files
Merge pull request #6350 from microsoft/fix-app-service-label
Fix endless loop while getting operating system modifier for app service
2 parents c16d65f + 11259e5 commit 25e441f

File tree

1 file changed

+2
-9
lines changed
  • Utils/azure-toolkit-ide-libs/azure-toolkit-ide-appservice-lib/src/main/java/com/microsoft/azure/toolkit/ide/appservice/webapp

1 file changed

+2
-9
lines changed

Utils/azure-toolkit-ide-libs/azure-toolkit-ide-appservice-lib/src/main/java/com/microsoft/azure/toolkit/ide/appservice/webapp/WebAppExplorerContributor.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@
1919
import com.microsoft.azure.toolkit.lib.appservice.model.OperatingSystem;
2020
import com.microsoft.azure.toolkit.lib.appservice.service.IAppService;
2121
import com.microsoft.azure.toolkit.lib.appservice.service.impl.WebApp;
22-
import com.microsoft.azure.toolkit.lib.common.event.AzureEventBus;
23-
import com.microsoft.azure.toolkit.lib.common.task.AzureTaskManager;
2422

2523
import java.util.Arrays;
2624
import java.util.Collections;
@@ -52,13 +50,8 @@ public Node<?> getModuleNode() {
5250
}
5351

5452
private static AzureIcon.Modifier getOperatingSystemModifier(IAppService<?> resource) {
55-
if (resource.getRawEntity() == null) {
56-
// do not add os modifier in loading status as runtime request may have high cost
57-
AzureTaskManager.getInstance().runOnPooledThreadAsObservable(resource::getRuntime)
58-
.subscribe(ignore -> AzureEventBus.emit("resource.status_changed.resource", resource));
59-
return null;
60-
}
61-
return resource.getRuntime().getOperatingSystem() != OperatingSystem.WINDOWS ? AzureIcon.Modifier.LINUX : null;
53+
return resource.getFormalStatus().isWaiting() ? null :
54+
resource.getRuntime().getOperatingSystem() != OperatingSystem.WINDOWS ? AzureIcon.Modifier.LINUX : null;
6255
}
6356

6457
private static List<WebApp> listWebApps(AzureWebApp webAppModule) {

0 commit comments

Comments
 (0)