Fix lateinit property not initialzed issue (#3512)

Author: t-rufang

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/hdinsight/spark/run/ArcadiaSparkBatchRunner.kt

@@ -24,6 +24,7 @@ package com.microsoft.azure.hdinsight.spark.run
 
 import com.intellij.execution.ExecutionException
 import com.intellij.execution.configurations.RunProfile
+import com.intellij.execution.configurations.RuntimeConfigurationError
 import com.microsoft.azure.hdinsight.common.MessageInfoType
 import com.microsoft.azure.hdinsight.common.WasbUri
 import com.microsoft.azure.hdinsight.spark.common.*
@@ -32,10 +33,10 @@ import com.microsoft.azure.hdinsight.spark.run.configuration.ArcadiaSparkSubmitM
 import com.microsoft.azure.projectarcadia.common.ArcadiaSparkComputeManager
 import com.microsoft.azuretools.securestore.SecureStore
 import com.microsoft.azuretools.service.ServiceManager
+import org.apache.commons.lang3.exception.ExceptionUtils
 import rx.Observer
 import java.net.URI
-import java.util.AbstractMap
-import java.util.NoSuchElementException
+import java.util.*
 
 class ArcadiaSparkBatchRunner : SparkBatchJobRunner() {
     override fun canRun(executorId: String, profile: RunProfile): Boolean {
@@ -50,7 +51,13 @@ class ArcadiaSparkBatchRunner : SparkBatchJobRunner() {
 
     @Throws(ExecutionException::class)
     override fun buildSparkBatchJob(submitModel: SparkSubmitModel, ctrlSubject: Observer<AbstractMap.SimpleImmutableEntry<MessageInfoType, String>>): ISparkBatchJob {
-        val arcadiaModel = submitModel as ArcadiaSparkSubmitModel
+        val arcadiaModel = (submitModel as ArcadiaSparkSubmitModel).apply {
+            if (sparkCompute == null || tenantId == null || sparkWorkspace == null) {
+                log().warn("Arcadia Spark Compute is not selected. " +
+                        "spark compute: $sparkCompute, tenant id: $tenantId, spark workspace: $sparkWorkspace")
+                throw ExecutionException("Arcadia Spark Compute is not selected")
+            }
+        }
         val submission = SparkBatchArcadiaSubmission(
                 arcadiaModel.tenantId, arcadiaModel.sparkWorkspace, URI.create(arcadiaModel.livyUri))
 
@@ -66,7 +73,7 @@ class ArcadiaSparkBatchRunner : SparkBatchJobRunner() {
                         .first()
             } catch (ex: NoSuchElementException) {
                 throw ExecutionException(
-                        "Can't find Arcadia spark compute (${arcadiaModel.sparkWorkspace}:${arcadiaModel.sparkCompute})"
+                        "Can't find Arcadia Spark Compute (${arcadiaModel.sparkWorkspace}:${arcadiaModel.sparkCompute})"
                                 + " at tenant ${arcadiaModel.tenantId}.")
             }
 

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/hdinsight/spark/run/configuration/ArcadiaSparkConfiguration.kt

@@ -38,4 +38,8 @@ class ArcadiaSparkConfiguration (name: String, val module: ArcadiaSparkConfigura
     override fun getSuggestedNamePrefix(): String {
         return "[Spark on Arcadia]"
     }
+
+    override fun getErrorMessageClusterNull(): String {
+        return "The Spark Compute should be selected as the target for Spark application submission"
+    }
 }

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/hdinsight/spark/run/configuration/ArcadiaSparkSubmitModel.kt

@@ -28,13 +28,13 @@ import com.microsoft.azure.hdinsight.spark.common.SparkSubmitModel
 
 class ArcadiaSparkSubmitModel(project: Project) : SparkSubmitModel(project) {
     @Attribute("livy_uri")
-    lateinit var livyUri: String
+    var livyUri: String? = null
     @Attribute("spark_workspace")
-    lateinit var sparkWorkspace: String
+    var sparkWorkspace: String? = null
     @Attribute("spark_compute")
-    lateinit var sparkCompute: String
+    var sparkCompute: String? = null
     @Attribute("tenant_id")
-    lateinit var tenantId: String
+    var tenantId: String? = null
 
     override fun getSparkClusterTypeDisplayName(): String = "Arcadia Spark cluster"
 }

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/projectarcadia/spark/console/ArcadiaSparkScalaLivyConsoleRunConfiguration.kt

@@ -32,6 +32,7 @@ import com.intellij.execution.runners.ExecutionEnvironment
 import com.intellij.execution.runners.ProgramRunner
 import com.intellij.openapi.project.Project
 import com.microsoft.azure.arcadia.sdk.common.livy.interactive.ArcadiaSparkSession
+import com.microsoft.azure.hdinsight.common.logger.ILogger
 import com.microsoft.azure.hdinsight.spark.console.SparkScalaConsoleBuilder
 import com.microsoft.azure.hdinsight.spark.console.SparkScalaLivyConsoleRunConfiguration
 import com.microsoft.azure.hdinsight.spark.console.SparkScalaLivyConsoleRunConfigurationFactory
@@ -48,7 +49,7 @@ class ArcadiaSparkScalaLivyConsoleRunConfiguration(project: Project,
                                                    batchRunConfiguration: LivySparkBatchJobRunConfiguration?,
                                                    name: String)
     : SparkScalaLivyConsoleRunConfiguration(
-        project, configurationFactory, batchRunConfiguration, name) {
+        project, configurationFactory, batchRunConfiguration, name), ILogger {
     override val runConfigurationTypeName: String = "Arcadia Spark Run Configuration"
 
     override fun getState(executor: Executor, env: ExecutionEnvironment): RunProfileState? {
@@ -63,8 +64,14 @@ class ArcadiaSparkScalaLivyConsoleRunConfiguration(project: Project,
     }
 
     override fun checkRunnerSettings(runner: ProgramRunner<*>, runnerSettings: RunnerSettings?, configurationPerRunnerSettings: ConfigurationPerRunnerSettings?) {
-        val arcadiaModel = (submitModel as? ArcadiaSparkSubmitModel)
-                ?: throw RuntimeConfigurationError("Can't cast submitModel to ArcadiaSparkSubmitModel")
+        val arcadiaModel = (submitModel as? ArcadiaSparkSubmitModel)?.apply {
+            if (sparkCompute == null || tenantId == null || sparkWorkspace == null) {
+                log().warn("Arcadia Spark Compute is not selected. " +
+                            "spark compute: $sparkCompute, tenant id: $tenantId, spark workspace: $sparkWorkspace")
+                throw RuntimeConfigurationError("Arcadia Spark Compute is not selected")
+            }
+        }
+            ?: throw RuntimeConfigurationError("Can't cast submitModel to ArcadiaSparkSubmitModel")
 
         cluster = try {
             ArcadiaSparkComputeManager.getInstance()