active deployment may not be ready when opening properties editor, causing getting active deployment from UI thread, in which case, cache1 would return the last value(maybe null) instead.

Author: wangmingliang-ms

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-springcloud/src/main/java/com/microsoft/azure/toolkit/intellij/springcloud/properties/SpringCloudAppPropertiesEditor.java

@@ -49,6 +49,7 @@ public class SpringCloudAppPropertiesEditor extends AzResourcePropertiesEditor<S
     private final SpringCloudApp app;
     @Nonnull
     private final SpringCloudAppDraft draft;
+    private SpringCloudDeploymentDraft deploymentDraft;
 
     public SpringCloudAppPropertiesEditor(@Nonnull Project project, @Nonnull SpringCloudApp app, @Nonnull final VirtualFile virtualFile) {
         super(virtualFile, app, project);
@@ -61,16 +62,22 @@ public SpringCloudAppPropertiesEditor(@Nonnull Project project, @Nonnull SpringC
 
     @Override
     protected void rerender() {
-        this.setEnabled(false);
-        AzureTaskManager.getInstance().runLater(() -> {
-            this.formConfig.updateForm(this.draft);
-            this.panelInstances.setApp(this.draft);
-            this.lblSubscription.setText(this.draft.getSubscription().getName());
-            this.lblCluster.setText(this.draft.getParent().getName());
-            this.lblApp.setText(this.draft.getName());
-            this.refreshToolbar();
-            this.formConfig.setValue(this.draft);
-            this.setEnabled(true);
+        final AzureTaskManager tm = AzureTaskManager.getInstance();
+        tm.runLater(() -> {
+            this.setEnabled(false);
+            tm.runOnPooledThread(() -> {
+                this.deploymentDraft = this.draft.updateOrCreateActiveDeployment();
+                tm.runLater(() -> {
+                    this.formConfig.updateForm(this.draft);
+                    this.panelInstances.setApp(this.draft);
+                    this.lblSubscription.setText(this.draft.getSubscription().getName());
+                    this.lblCluster.setText(this.draft.getParent().getName());
+                    this.lblApp.setText(this.draft.getName());
+                    this.refreshToolbar();
+                    this.formConfig.setValue(this.draft);
+                    this.setEnabled(true);
+                });
+            });
         });
     }
 
@@ -128,7 +135,7 @@ private void reset() {
 
     @Override
     public boolean isModified() {
-        return this.draft.isModified() || this.draft.updateOrCreateActiveDeployment().isModified();
+        return this.draft.isModified() || this.deploymentDraft.isModified();
     }
 
     protected void refresh() {