Update based on review comments

Author: t-rufang

Utils/hdinsight-node-common/src/com/microsoft/azure/hdinsight/sdk/common/HttpObservable.java

@@ -34,7 +34,6 @@
 import org.apache.http.auth.UsernamePasswordCredentials;
 import org.apache.http.client.CookieStore;
 import org.apache.http.client.CredentialsProvider;
-import org.apache.http.client.HttpResponseException;
 import org.apache.http.client.config.AuthSchemes;
 import org.apache.http.client.config.CookieSpecs;
 import org.apache.http.client.config.RequestConfig;
@@ -238,7 +237,7 @@ public static Observable<HttpResponse> toStringOnlyOkResponse(CloseableHttpRespo
 
                         if (status.getStatusCode() >= 300) {
                             Header requestIdHeader = streamResp.getFirstHeader("x-ms-request-id");
-                            return Observable.error(new HttpResponseWithRequestIdException(status.getStatusCode(),
+                            return Observable.error(new SparkAzureDataLakePoolServiceException(status.getStatusCode(),
                                     status.getReasonPhrase(),
                                     requestIdHeader != null ? requestIdHeader.getValue() : ""));
                         }

Utils/hdinsight-node-common/src/com/microsoft/azure/hdinsight/sdk/common/HttpResponseWithRequestIdException.java renamed to Utils/hdinsight-node-common/src/com/microsoft/azure/hdinsight/sdk/common/SparkAzureDataLakePoolServiceException.java

@@ -24,11 +24,11 @@
 
 import com.microsoft.azuretools.azurecommons.helpers.Nullable;
 
-public class HttpResponseWithRequestIdException extends AzureDataLakeException {
+public class SparkAzureDataLakePoolServiceException extends AzureDataLakeException {
     @Nullable
     private String requestId;
 
-    public HttpResponseWithRequestIdException(final int statusCode, final String s, @Nullable final String requestId) {
+    public SparkAzureDataLakePoolServiceException(final int statusCode, final String s, @Nullable final String requestId) {
         super(statusCode, s);
         this.requestId = requestId;
     }

Utils/hdinsight-node-common/src/com/microsoft/azure/sparkserverless/serverexplore/SparkServerlessClusterProvisionCtrlProvider.java

@@ -24,7 +24,7 @@
 import com.microsoft.azure.hdinsight.common.logger.ILogger;
 import com.microsoft.azure.hdinsight.common.mvc.IdeSchedulers;
 import com.microsoft.azure.hdinsight.common.mvc.SettableControl;
-import com.microsoft.azure.hdinsight.sdk.common.HttpResponseWithRequestIdException;
+import com.microsoft.azure.hdinsight.sdk.common.SparkAzureDataLakePoolServiceException;
 import com.microsoft.azure.hdinsight.sdk.common.azure.serverless.AzureSparkServerlessAccount;
 import com.microsoft.azure.hdinsight.sdk.common.azure.serverless.AzureSparkServerlessCluster;
 import com.microsoft.azuretools.azurecommons.helpers.NotNull;
@@ -137,8 +137,8 @@ public Observable<SparkServerlessClusterProvisionSettingsModel> validateAndProvi
                                 .map(cluster -> toUpdate)
                                 .onErrorReturn(err -> {
                                     log().warn("Error provision a cluster. " + ExceptionUtils.getStackTrace(err));
-                                    if (err instanceof HttpResponseWithRequestIdException) {
-                                        String requestId = ((HttpResponseWithRequestIdException) err).getRequestId();
+                                    if (err instanceof SparkAzureDataLakePoolServiceException) {
+                                        String requestId = ((SparkAzureDataLakePoolServiceException) err).getRequestId();
                                         toUpdate.setRequestId(requestId);
                                         log().info("x-ms-request-id: " + requestId);
                                     }

Utils/hdinsight-node-common/src/com/microsoft/azure/sparkserverless/serverexplore/SparkServerlessClusterUpdateCtrlProvider.java

@@ -3,7 +3,7 @@
 import com.microsoft.azure.hdinsight.common.logger.ILogger;
 import com.microsoft.azure.hdinsight.common.mvc.IdeSchedulers;
 import com.microsoft.azure.hdinsight.common.mvc.SettableControl;
-import com.microsoft.azure.hdinsight.sdk.common.HttpResponseWithRequestIdException;
+import com.microsoft.azure.hdinsight.sdk.common.SparkAzureDataLakePoolServiceException;
 import com.microsoft.azure.hdinsight.sdk.common.azure.serverless.AzureSparkServerlessCluster;
 import com.microsoft.azuretools.azurecommons.helpers.NotNull;
 import org.apache.commons.lang3.StringUtils;
@@ -67,8 +67,8 @@ public Observable<SparkServerlessClusterProvisionSettingsModel> validateAndUpdat
                                 .map(cluster -> toUpdate)
                                 .onErrorReturn(err -> {
                                     log().warn("Error update a cluster. " + ExceptionUtils.getStackTrace(err));
-                                    if (err instanceof HttpResponseWithRequestIdException) {
-                                        String requestId = ((HttpResponseWithRequestIdException) err).getRequestId();
+                                    if (err instanceof SparkAzureDataLakePoolServiceException) {
+                                        String requestId = ((SparkAzureDataLakePoolServiceException) err).getRequestId();
                                         toUpdate.setRequestId(requestId);
                                         log().info("x-ms-request-id: " + requestId);
                                     }