Skip to content

Commit 6a46ec5

Browse files
authored
Merge pull request #4420 from Flanker32/hanxiao/fixIntelliJ
Fix IntelliJ regression issues
2 parents 0a188d8 + 04db2f1 commit 6a46ec5

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

PluginsAndFeatures/azure-toolkit-for-intellij/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ dependencies {
113113
}
114114
compile 'com.microsoft.azure:azure-tools-common:0.2.0'
115115
compile group: 'com.microsoft.azure.appplatform.v2019_05_01_preview', name: 'azure-mgmt-appplatform', version: '1.0.0-beta-2'
116-
compile 'com.spotify:docker-client:8.16.0'
117116

118117
compile group: 'org.dom4j', name: 'dom4j', version: '2.1.3'
119118
compile group: 'jaxen', name: 'jaxen', version: '1.2.0'

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/intellij/runner/container/dockerhost/DockerHostRunState.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import static com.microsoft.azuretools.telemetry.TelemetryConstants.DEPLOY_WEBAPP_DOCKERLOCAL;
2626
import static com.microsoft.azuretools.telemetry.TelemetryConstants.WEBAPP;
2727

28-
import com.google.common.collect.ImmutableList;
2928
import com.intellij.execution.process.ProcessEvent;
3029
import com.intellij.execution.process.ProcessListener;
3130
import com.intellij.execution.process.ProcessOutputTypes;
@@ -43,6 +42,7 @@
4342
import com.spotify.docker.client.DockerClient;
4443
import com.spotify.docker.client.messages.Container;
4544

45+
import com.spotify.docker.client.shaded.com.google.common.collect.ImmutableList;
4646
import org.jetbrains.annotations.NotNull;
4747

4848
import java.io.FileNotFoundException;

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/intellij/runner/webapp/webappconfig/slimui/WebAppSlimSettingPanel.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -271,11 +271,11 @@ public synchronized void fillWebApps(List<ResourceEx<WebApp>> webAppLists) {
271271
lblCreateWebApp.setVisible(false);
272272
cbxWebApp.setVisible(true);
273273
cbxWebApp.addItem(CREATE_NEW_WEBAPP);
274+
// Need calculated target id first or fill combo box will trigger event to change selectedWebApp
275+
final String configurationWebAppId = webAppConfiguration.getWebAppId();
276+
final String targetId = (StringUtils.isEmpty(configurationWebAppId) && selectedWebApp != null) ?
277+
selectedWebApp.getResource().id() : configurationWebAppId;
274278
sortedWebAppLists.forEach(webAppResourceEx -> cbxWebApp.addItem(webAppResourceEx));
275-
// Find webapp which id equals to selected web app(when cancel creation) or configuration
276-
// Use the first one as fallback
277-
final String targetId = selectedWebApp == null ? webAppConfiguration.getWebAppId() :
278-
selectedWebApp.getResource().id();
279279
final ResourceEx<WebApp> selectWebApp = sortedWebAppLists
280280
.stream()
281281
.filter(webAppResourceEx -> StringUtils.equals(webAppResourceEx.getResource().id(), targetId))

0 commit comments

Comments
 (0)