Fix PluginException caused by JavaFX deprecation in IntelliJ 2020.2 issue (#5001)

* Fix JavaFX deprecated in IntelliJ 2020.2 issue

* Fix format

* Fix build break caused by symbol JobViewPanel not found

* Remove unused javafx context

Author: t-rufang

PluginsAndFeatures/azure-toolkit-for-intellij/gradle.properties

@@ -5,4 +5,4 @@ intellij_version=IC-2020.2
 dep_plugins=org.intellij.scala:2020.2.14
 applicationinsights.key=57cc111a-36a8-44b3-b044-25d293b8b77c
 updateVersionRange=true
-patchPluginXmlSinceBuild=202.6397.20
+patchPluginXmlSinceBuild=202.6397.94

PluginsAndFeatures/azure-toolkit-for-intellij/resources/META-INF/plugin.xml

@@ -42,7 +42,7 @@
   </change-notes>
 
   <!-- please see https://confluence.jetbrains.com/display/IDEADEV/Build+Number+Ranges for description -->
-  <idea-version since-build="202.6397.20" until-build="202.*"/>
+  <idea-version since-build="202.6397.94" until-build="202.*"/>
   <resource-bundle>com.microsoft.azure.toolkit.operation.titles</resource-bundle>
   <resource-bundle>com.microsoft.intellij.ui.messages.messages</resource-bundle>
   <resource-bundle>com.microsoft.intellij.hdinsight.messages.messages</resource-bundle>

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/hdinsight/jobs/framework/JobViewEditor.java

@@ -12,7 +12,6 @@
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.util.Key;
 import com.intellij.openapi.vfs.VirtualFile;
-import com.microsoft.azure.hdinsight.spark.jobs.framework.JobViewPanel;
 import com.microsoft.azuretools.telemetry.AppInsightsClient;
 import com.microsoft.azuretools.telemetry.TelemetryConstants;
 import com.microsoft.azuretools.telemetrywrapper.EventType;
@@ -44,7 +43,7 @@ public JobViewEditor(@NotNull final Project project, @NotNull final VirtualFile
         myProvider = provider;
         myVirtualFile = file;
         uuid = file.getUserData(JobViewEditorProvider.JOB_VIEW_UUID);
-        myComponent = new JobViewPanel(PluginUtil.getPluginRootDirectory(), uuid);
+        myComponent = new JobViewPanel(PluginUtil.getPluginRootDirectory(), uuid).getComponent();
         AppInsightsClient.create(HDInsightBundle.message("HDInsightSparkJobview"), null);
         EventUtil.logEvent(EventType.info, TelemetryConstants.HDINSIGHT,
             HDInsightBundle.message("HDInsightSparkJobview"), null);

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/hdinsight/jobs/framework/JobViewPanel.kt

@@ -0,0 +1,44 @@
+/*
+ * Copyright (c) Microsoft Corporation. All rights reserved.
+ * Licensed under the MIT License. See License.txt in the project root for license information.
+ */
+package com.microsoft.azure.hdinsight.jobs.framework
+
+import com.intellij.ui.jcef.JBCefApp
+import com.intellij.ui.jcef.JBCefBrowser
+import com.microsoft.azure.hdinsight.spark.jobs.JobViewHttpServer
+import java.awt.BorderLayout
+import javax.swing.JComponent
+import javax.swing.JPanel
+
+class JobViewPanel(private val rootPath: String, private val clusterName: String) {
+    private val QUERY_TEMPLATE = "?clusterName=%s&port=%s"
+    private val myComponent: JComponent
+
+    init {
+        val url = String.format("file:///%s/com.microsoft.hdinsight/hdinsight/job/html/index.html", rootPath)
+/*
+        // for debug only
+        final String ideaSystemPath = System.getProperty("idea.system.path");
+        if(!StringHelper.isNullOrWhiteSpace(ideaSystemPath) && ideaSystemPath.contains("idea-sandbox")) {
+            final String workFolder = System.getProperty("user.dir");
+            final String path = "Utils/hdinsight-node-common/resources/htmlResources/hdinsight/job/html/index.html";
+            url = String.format("file:///%s/%s", workFolder, path);
+        }
+*/
+        val queryString = String.format(QUERY_TEMPLATE, clusterName, JobViewHttpServer.getPort())
+        val webUrl = url + queryString
+
+        if (!JBCefApp.isSupported()) {
+            throw RuntimeException("JCEF is not enabled in current IDE. Please follow the instruction to enable JCEF first. https://youtrack.jetbrains" +
+                    ".com/issue/IDEA-231833#focus=streamItem-27-3993099.0-0")
+        }
+
+        val panel = JPanel(BorderLayout())
+        panel.add(JBCefBrowser(webUrl).component)
+        myComponent = panel
+    }
+
+    val component: JComponent
+        get() = myComponent
+}

Utils/hdinsight-node-common/resources/htmlResources/hdinsight/job/html/sparkjobview.js

@@ -141,7 +141,6 @@ function getBasicInfoFromUrl() {
 
     spark.sourceType = spark.queriresMap['sourcetype'] === undefined ? "intellij" : "eclipse";
     spark.clusterName = spark.queriresMap['clusterName'];
-    spark.engineType = spark.queriresMap['engineType'];
     spark.queryPort = spark.queriresMap['port'];
     spark.localhost = 'http://localhost:{0}'.format(spark.queryPort);
 

Utils/hdinsight-node-common/src/com/microsoft/azure/hdinsight/common/JobViewManager.java

@@ -5,15 +5,12 @@
 
 package com.microsoft.azure.hdinsight.common;
 
+import com.microsoft.azure.hdinsight.sdk.cluster.IClusterDetail;
 import com.microsoft.azure.hdinsight.sdk.rest.spark.Application;
 import com.microsoft.azure.hdinsight.spark.jobs.ApplicationKey;
-import com.microsoft.azure.hdinsight.spark.jobs.framework.JobViewPanel;
-import com.microsoft.azure.hdinsight.sdk.cluster.IClusterDetail;
 import com.microsoft.azuretools.azurecommons.helpers.NotNull;
 import com.microsoft.azuretools.azurecommons.helpers.Nullable;
-import javafx.util.Pair;
 
-import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;

Utils/hdinsight-node-common/src/com/microsoft/azure/hdinsight/spark/jobs/framework/JobViewPanel.java

@@ -1,6 +1,6 @@
 ARTIFACTS_DIR=artifacts
 INJECT_INTELLIJ_VERSION=true
-IJ_VERSION_MAJOR_BUILD=202.6397.20
+IJ_VERSION_MAJOR_BUILD=202.6397.94
 IJ_VERSION_MAJOR=2020.2
 IJ_VERSION_MINOR=
 IJ_SCALA_VERSION_LATEST=2020.2.14