Remove cache for validation and related deprecated codes

Author: Flanker32

PluginsAndFeatures/azure-toolkit-for-intellij/src/main/java/com/microsoft/azure/toolkit/intellij/webapp/runner/webappconfig/WebAppConfiguration.java

@@ -16,7 +16,6 @@
 import com.intellij.openapi.options.SettingsEditor;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.util.InvalidDataException;
-import com.intellij.openapi.util.WriteExternalException;
 import com.microsoft.azure.toolkit.intellij.common.AzureArtifact;
 import com.microsoft.azure.toolkit.intellij.common.AzureArtifactManager;
 import com.microsoft.azure.toolkit.intellij.common.AzureArtifactType;
@@ -85,12 +84,6 @@ public RunProfileState getState(@NotNull Executor executor, @NotNull ExecutionEn
         return new WebAppRunState(getProject(), this);
     }
 
-    @Override
-    public void writeExternal(Element element) throws WriteExternalException {
-        element.getChildren().forEach(child -> element.removeChild(child.getName()));
-        super.writeExternal(element);
-    }
-
     @Override
     public void readExternal(final Element element) throws InvalidDataException {
         super.readExternal(element);

PluginsAndFeatures/azure-toolkit-for-intellij/src/main/java/com/microsoft/azure/toolkit/intellij/webapp/runner/webappconfig/WebAppRunState.java

@@ -28,7 +28,6 @@
 import com.microsoft.azuretools.utils.AzureUIRefreshEvent;
 import com.microsoft.azuretools.utils.WebAppUtils;
 import com.microsoft.intellij.RunProcessHandler;
-import com.microsoft.intellij.util.ValidationUtils;
 import org.apache.commons.collections4.MapUtils;
 import org.apache.commons.compress.utils.FileNameUtils;
 import org.apache.commons.lang3.StringUtils;
@@ -165,9 +164,7 @@ private IWebApp getOrCreateWebappFromAppSettingModel(AzureAppService azureAppSer
         }
         if (webAppSettingModel.isCreatingNew()) {
             processHandler.setText(message("webapp.deploy.hint.creatingWebApp"));
-            final IWebApp webAppFromSettingModel = AzureWebAppMvpModel.getInstance().createWebAppFromSettingModel(webAppSettingModel);
-            ValidationUtils.evictCacheForAppServiceNameValidation(webAppSettingModel.getSubscriptionId(), webAppSettingModel.getWebAppName());
-            return webAppFromSettingModel;
+            return AzureWebAppMvpModel.getInstance().createWebAppFromSettingModel(webAppSettingModel);
         } else {
             processHandler.setText(message("appService.deploy.hint.failed"));
             throw new Exception(message("webapp.deploy.error.noWebApp"));

PluginsAndFeatures/azure-toolkit-for-intellij/src/main/java/com/microsoft/azure/toolkit/lib/function/FunctionAppService.java

@@ -24,7 +24,6 @@
 import com.microsoft.azure.toolkit.lib.common.telemetry.AzureTelemetry;
 import com.microsoft.azure.toolkit.lib.resource.AzureGroup;
 import com.microsoft.azuretools.sdkmanage.IdentityAzureManager;
-import com.microsoft.intellij.util.ValidationUtils;
 import org.apache.commons.lang3.StringUtils;
 import org.zeroturnaround.zip.ZipUtil;
 
@@ -102,7 +101,6 @@ public IFunctionApp createFunctionApp(final FunctionAppConfig config) {
                 .withAppSettings(appSettings)
                 .withDiagnosticConfig(config.getMonitorConfig().getDiagnosticConfig())
                 .commit();
-        ValidationUtils.evictCacheForAppServiceNameValidation(config.getSubscriptionId(), config.getName());
         AzureMessager.getMessager().info(String.format(CREATE_FUNCTION_APP_DONE, result.name()));
         return result;
     }

PluginsAndFeatures/azure-toolkit-for-intellij/src/main/java/com/microsoft/azure/toolkit/lib/webapp/WebAppService.java

@@ -20,7 +20,6 @@
 import com.microsoft.azuretools.telemetrywrapper.EventUtil;
 import com.microsoft.azuretools.telemetrywrapper.Operation;
 import com.microsoft.azuretools.telemetrywrapper.TelemetryManager;
-import com.microsoft.intellij.util.ValidationUtils;
 import org.apache.commons.lang3.StringUtils;
 
 import javax.annotation.Nonnull;
@@ -53,7 +52,6 @@ public IWebApp createWebApp(final WebAppConfig config) {
             EventUtil.logError(operation, ErrorType.userError, e, properties, null);
             throw e;
         } finally {
-            ValidationUtils.evictCacheForAppServiceNameValidation(config.getSubscriptionId(), config.getName());
             operation.complete();
         }
     }

PluginsAndFeatures/azure-toolkit-for-intellij/src/main/java/com/microsoft/intellij/util/ValidationUtils.java

@@ -8,8 +8,6 @@
 import com.azure.core.management.exception.ManagementException;
 import com.microsoft.azure.toolkit.lib.Azure;
 import com.microsoft.azure.toolkit.lib.appservice.AzureAppService;
-import com.microsoft.azure.toolkit.lib.common.cache.CacheManager;
-import com.microsoft.azure.toolkit.lib.common.cache.Cacheable;
 import com.microsoft.azure.toolkit.lib.common.entity.CheckNameAvailabilityResultEntity;
 import com.microsoft.azure.toolkit.lib.common.model.ResourceGroup;
 import com.microsoft.azure.toolkit.lib.resource.AzureGroup;
@@ -19,7 +17,6 @@
 import java.util.HashSet;
 import java.util.Objects;
 import java.util.Set;
-import java.util.concurrent.ExecutionException;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
@@ -57,7 +54,6 @@ public static boolean isValidVersion(String version) {
         return version != null && version.matches(VERSION_REGEX);
     }
 
-    @Cacheable(cacheName = "appservice/validation/name", key = "$subscriptionId/$appServiceName")
     public static void validateAppServiceName(String subscriptionId, String appServiceName) {
         if (StringUtils.isEmpty(subscriptionId)) {
             throw new IllegalArgumentException(message("appService.subscription.validate.empty"));
@@ -71,16 +67,6 @@ public static void validateAppServiceName(String subscriptionId, String appServi
         }
     }
 
-    // todo: move validation and related cache management to toolkit lib
-    public static void evictCacheForAppServiceNameValidation(String subscriptionId, String appServiceName) {
-        try {
-            CacheManager.evictCache("appservice/validation/name", String.format("%s/%s", subscriptionId, appServiceName));
-        } catch (ExecutionException e) {
-            // swallow exception for clear cache
-        }
-    }
-
-    @Cacheable(cacheName = "resourcegroup/validation/name", key = "$subscriptionId/$resourceGroup")
     public static void validateResourceGroupName(String subscriptionId, String resourceGroup) {
         if (StringUtils.isEmpty(subscriptionId)) {
             throw new IllegalArgumentException(message("appService.subscription.validate.empty"));