add error border/popup to input component on realtime validation error.

Author: wangmingliang-ms

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-lib/src/main/java/com/microsoft/azure/toolkit/intellij/common/AzureDialog.java

@@ -4,23 +4,22 @@
  */
 package com.microsoft.azure.toolkit.intellij.common;
 
+import com.intellij.openapi.Disposable;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.ui.DialogWrapper;
 import com.intellij.openapi.ui.ValidationInfo;
+import com.intellij.openapi.util.Disposer;
 import com.microsoft.azure.toolkit.lib.common.form.AzureForm;
 import com.microsoft.azure.toolkit.lib.common.form.AzureFormInput;
 import com.microsoft.azure.toolkit.lib.common.form.AzureValidationInfo;
 import com.microsoft.azure.toolkit.lib.common.messager.AzureMessager;
 import lombok.extern.java.Log;
 
-import javax.swing.*;
 import java.util.List;
 import java.util.Objects;
-import java.util.Optional;
 import java.util.stream.Collectors;
 
 import static com.microsoft.azure.toolkit.lib.common.form.AzureValidationInfo.Type.SUCCESS;
-import static com.microsoft.azure.toolkit.lib.common.form.AzureValidationInfo.Type.WARNING;
 
 @Log
 public abstract class AzureDialog<T> extends DialogWrapper {
@@ -36,6 +35,16 @@ public AzureDialog() {
         this(null);
     }
 
+    @Override
+    protected void init() {
+        super.init();
+        for (final AzureFormInput<?> input : this.getForm().getInputs()) {
+            if (input instanceof Disposable) {
+                Disposer.register(this.getDisposable(), (Disposable) input);
+            }
+        }
+    }
+
     @Override
     protected void doOKAction() {
         try {
@@ -57,23 +66,13 @@ public void close() {
     @Override
     protected List<ValidationInfo> doValidateAll() {
         final List<AzureValidationInfo> infos = this.getForm().getAllValidationInfos(true);
-        this.setOKActionEnabled(infos.stream().allMatch(AzureValidationInfo::isValid));
+        // this.setOKActionEnabled(infos.stream().allMatch(AzureValidationInfo::isValid));
         return infos.stream()
             .filter(i -> i.getType() != SUCCESS)
-            .map(AzureDialog::toIntellijValidationInfo)
+            .map(AzureFormInputComponent::toIntellijValidationInfo)
             .collect(Collectors.toList());
     }
 
-    private static ValidationInfo toIntellijValidationInfo(final AzureValidationInfo info) {
-        final AzureFormInput<?> input = info.getInput();
-        final JComponent component = input instanceof AzureFormInputComponent ? ((AzureFormInputComponent<?>) input).getInputComponent() : null;
-        final ValidationInfo v = new ValidationInfo(Optional.ofNullable(info.getMessage()).orElse("Unknown error"), component);
-        if (info.getType() == WARNING) {
-            v.asWarning();
-        }
-        return v;
-    }
-
     public abstract AzureForm<T> getForm();
 
     protected abstract String getDialogTitle();

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-lib/src/main/java/com/microsoft/azure/toolkit/intellij/common/AzureFormInputComponent.java

@@ -5,22 +5,29 @@
 
 package com.microsoft.azure.toolkit.intellij.common;
 
+import com.intellij.openapi.Disposable;
+import com.intellij.openapi.ui.ComponentValidator;
+import com.intellij.openapi.ui.ValidationInfo;
 import com.microsoft.azure.toolkit.lib.common.form.AzureFormInput;
 import com.microsoft.azure.toolkit.lib.common.form.AzureValidationInfo;
+import com.microsoft.azure.toolkit.lib.common.task.AzureTaskManager;
 
 import javax.accessibility.AccessibleRelation;
 import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
 import javax.swing.*;
+import java.util.Objects;
 import java.util.Optional;
 
-public interface AzureFormInputComponent<T> extends AzureFormInput<T> {
+import static com.microsoft.azure.toolkit.lib.common.form.AzureValidationInfo.Type.PENDING;
+import static com.microsoft.azure.toolkit.lib.common.form.AzureValidationInfo.Type.SUCCESS;
+import static com.microsoft.azure.toolkit.lib.common.form.AzureValidationInfo.Type.WARNING;
+
+public interface AzureFormInputComponent<T> extends AzureFormInput<T>, Disposable {
     default JComponent getInputComponent() {
         return (JComponent) this;
     }
 
-    /**
-     * NOTE: don't override
-     */
     @Nonnull
     @Override
     default AzureValidationInfo validateInternal(T value) {
@@ -30,11 +37,47 @@ default AzureValidationInfo validateInternal(T value) {
         return AzureFormInput.super.validateInternal(value);
     }
 
+    @Override
+    default void setValidationInfo(@Nullable AzureValidationInfo vi) {
+        AzureFormInput.super.setValidationInfo(vi);
+        final ValidationInfo info = Objects.nonNull(vi) && (vi.getType() == PENDING || vi.getType() == SUCCESS) ? null : toIntellijValidationInfo(vi);
+        final String state = Objects.isNull(info) ? null : info.warning ? "warning" : "error";
+        final JComponent input = this.getInputComponent();
+        // see com.intellij.openapi.ui.ComponentValidator.updateInfo
+        input.putClientProperty("JComponent.outline", state);
+        input.revalidate();
+        input.repaint();
+        // see com.intellij.openapi.ui.DialogWrapper.setErrorInfoAll
+        final ComponentValidator v = ComponentValidator.getInstance(input).orElseGet(() -> (new ComponentValidator(this)).installOn(input));
+        if (v != null) {
+            AzureTaskManager.getInstance().runLater(() -> v.updateInfo(info));
+        }
+    }
+
     @Override
     default String getLabel() {
         final JLabel label = (JLabel) this.getInputComponent().getClientProperty(AccessibleRelation.LABELED_BY);
         return Optional.ofNullable(label).map(JLabel::getText)
             .map(t -> t.endsWith(":") ? t.substring(0, t.length() - 1) : t)
             .orElse(this.getClass().getSimpleName());
     }
+
+    @Nullable
+    static ValidationInfo toIntellijValidationInfo(@Nullable final AzureValidationInfo info) {
+        if (Objects.isNull(info)) {
+            return null;
+        }
+        final AzureFormInput<?> input = info.getInput();
+        final JComponent component = input instanceof AzureFormInputComponent ? ((AzureFormInputComponent<?>) input).getInputComponent() : null;
+        final ValidationInfo v = new ValidationInfo(Optional.ofNullable(info.getMessage()).orElse("Unknown error"), component);
+        if (info.getType() == WARNING) {
+            v.asWarning();
+        }
+        return v;
+    }
+
+    @Override
+    default void dispose() {
+        this.clearAll();
+    }
 }